From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AB60042B85 for ; Wed, 27 Apr 2022 15:18:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E13E68B469; Wed, 27 Apr 2022 18:18:23 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 37F6F689CFC for ; Wed, 27 Apr 2022 18:18:16 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id D31322DA8D6 for ; Wed, 27 Apr 2022 17:18:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1651072695; bh=UjS8m9DYMSvhu/ZJnP+3RFgu3c0nJB0c7MyaAPk70MQ=; h=Date:Subject:To:References:From:In-Reply-To; b=Fg+CqbQ74cSSurRo3Rbe2EGUpFnVx+vU3BtlKJ4VJ2gHGRIixX/+qlBHlBUZFUNAh ASLTIol82u5xHx+MdXCtGQ0w5tteZHH36LrkGMwf7NpwT1dNSyAPrTklnTQWmTeM0C Qf6Ce0Z3AbevG0OjuWyXuFCKr+8q6IFUCAC3SgbKLU3zmXuLimbycsHqzJJU8+DDzZ 4msW/r+zaOFgXNRj3ujV4tS6xpnfDNP/dovp+qfRaJsrft4cxPl5J6FyEmJmCzByjf 40PV6TjwNPGzyQ0H2NQSjjCYI0gb+NAU3NCaNJd5Wqe9gOUCDowfYkWob+TLPATGxG PNo6+/3o3qifA== Message-ID: Date: Wed, 27 Apr 2022 17:18:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <5cb6218e-8647-0817-fd8f-aa815d3bf30a@rothenpieler.org> From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] Guidance needed for a semi-breaking change X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 27.04.2022 16:07, MCC CS wrote: > The default for AAC_AT is to produce highest quality audio, which I'll keep undoubtedly > in the same direction. However, the question is this: > > Should the one who explicitly set `-aac_at_quality 0` (highest quality available) be moved from HIGH to MAX, > HOWEVER causing the side effect of moving everyone up in the quality-speed tradeoff by one, > > (or we can eliminate HIGH and just replace it with MAX which has no tradeoffs AFAIK) > > OR add `-1`, so that only those who entered no `aac_at_quality` be moved to -1, > and keeping explicit people having set `-aac_at_quality 0` at HIGH for them, > although they might have meant MAX when they started using it? > (i.e. no regression nor improvement for them) The strictly correct approach here would be to add version guards, and switch to the new behaviour next major bump. I do agree though that that seems a bit over the top for this, and specially if there is a higher quality than what ffmpeg currently offers, I could definitely see keeping 0 as "highest possible quality". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".