From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] Guidance needed for a semi-breaking change
Date: Wed, 27 Apr 2022 17:18:14 +0200
Message-ID: <b459734b-c8a5-545c-6e3f-689770742d4e@rothenpieler.org> (raw)
In-Reply-To: <trinity-422816ff-5d2a-41f3-846c-f92d97b9b3b2-1651068423260@3c-app-mailcom-bs13>
On 27.04.2022 16:07, MCC CS wrote:
> The default for AAC_AT is to produce highest quality audio, which I'll keep undoubtedly
> in the same direction. However, the question is this:
>
> Should the one who explicitly set `-aac_at_quality 0` (highest quality available) be moved from HIGH to MAX,
> HOWEVER causing the side effect of moving everyone up in the quality-speed tradeoff by one,
>
> (or we can eliminate HIGH and just replace it with MAX which has no tradeoffs AFAIK)
>
> OR add `-1`, so that only those who entered no `aac_at_quality` be moved to -1,
> and keeping explicit people having set `-aac_at_quality 0` at HIGH for them,
> although they might have meant MAX when they started using it?
> (i.e. no regression nor improvement for them)
The strictly correct approach here would be to add version guards, and
switch to the new behaviour next major bump.
I do agree though that that seems a bit over the top for this, and
specially if there is a higher quality than what ffmpeg currently
offers, I could definitely see keeping 0 as "highest possible quality".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-27 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 12:42 MCC CS
2022-04-27 12:49 ` Timo Rothenpieler
2022-04-27 13:06 ` MCC CS
2022-04-27 13:15 ` Timo Rothenpieler
2022-04-27 13:18 ` Nicolas George
2022-04-27 14:07 ` MCC CS
2022-04-27 15:18 ` Timo Rothenpieler [this message]
2022-04-27 18:05 ` MCC CS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b459734b-c8a5-545c-6e3f-689770742d4e@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git