From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3960442B43 for ; Mon, 25 Apr 2022 23:05:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2EA4768AFB1; Tue, 26 Apr 2022 02:05:18 +0300 (EEST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9BE768A4DC for ; Tue, 26 Apr 2022 02:05:11 +0300 (EEST) Received: by mail-ot1-f42.google.com with SMTP id k29-20020a056830243d00b006040caa0988so11880356ots.6 for ; Mon, 25 Apr 2022 16:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=coGU2HGQrdIZLUqNRM3kOsNjO09LxIxgHV9ftEDsyCU=; b=ZUMdcG2n/M95bRTcP1b7H/jKuiJDjxXr0aLdLCxyIKjUjOfe66NWKbPhOLYFi8S3EY 6uMQ1ALdPbcP5rccY5Qb4TzYb9uGhLzjbu+2Hwhm67xzfuifCJIl07rxrGXNxxM5QvGo Du9dTq7DpStuoH1n1aBVK6N63IkpoV1CvzXVZszQOsqZ6c8POQPi950FtptVmkJpxuKg 8qn4lM5Ovn7U5o1CpXsMGVlI/8MqSk3EPYLBdB8VmTTAmFntewRtWzTueeIOFFBRnO7G erWLkicDreDOKFsDJWnYNoAHvQHwm0aUAWVPmIyBRlPsR7B7Z/qXfujgLn7Li62yJva4 S+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=coGU2HGQrdIZLUqNRM3kOsNjO09LxIxgHV9ftEDsyCU=; b=m3xyHbReoTYm9UEJt9bqPHyGpyqFv1Lod/noN/XaJg5xUV3iB8SUcJ9fB+Ms8+kovf MHFOhBN7uBI8CFSKt4c0cp2ZMrf/hgt01yDS4plzFlAHQxU+154iuTpXvcd6Ghue92sB gS6lrFgSFpx7sp/nC+rTPWHOVmYvtbt91UeEx1ToAee7SnaH/06ToAZwYLF+2dU/dVU1 LjAj0pukiokAw843xV94kh7Ygu9hK/ImoR4TeIivaT+skEnYDjAG6ItNZV7STNVPOJOP O1OzktaAhWpc6ZG1/30QIfhmeT4yd0DX5Kojc/ttYEBq5g7wJN03n/Y1np0oypGDxKlf RTsA== X-Gm-Message-State: AOAM533+XjR59NMKgEA6MOPgCiPNILDWIe1Xyi0iBaDALp96hip8IgjV DBNZ5OVo70wfo/SnOOPnR58+JI22wiw= X-Google-Smtp-Source: ABdhPJw+WHAZrIX7TgwrA5boRIb2uYEcZP5FRA0m9gGPpeBwuKm8+atzUkNrWk7wmLw4BpezRHM5/w== X-Received: by 2002:a05:6830:3109:b0:605:887c:184f with SMTP id b9-20020a056830310900b00605887c184fmr6326055ots.270.1650927910120; Mon, 25 Apr 2022 16:05:10 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id u144-20020acaab96000000b00324edac04f2sm3827578oie.37.2022.04.25.16.05.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 16:05:09 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 20:05:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220425223719.432161-1-ccom@randomderp.com> <20220425225438.434800-1-ccom@randomderp.com> From: James Almer In-Reply-To: <20220425225438.434800-1-ccom@randomderp.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass pict_type to library X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/25/2022 7:54 PM, Christopher Degawa wrote: > match the behavior of SvtAv1EncApp to ensure pic_type is always set > before passing it to the library. > > The other options for pic_type aren't currently used inside the library, > so they aren't introduced in this patch. > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 2e3d96ce37..088b9bab02 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -404,6 +404,16 @@ static int eb_send_frame(AVCodecContext *avctx, const AVFrame *frame) > headerPtr->p_app_private = NULL; > headerPtr->pts = frame->pts; > > + switch (frame->pict_type) { > + case AV_PICTURE_TYPE_I: > + headerPtr->pic_type = EB_AV1_KEY_PICTURE; > + break; > + default: > + // Actually means auto, or default. > + headerPtr->pic_type = EB_AV1_INVALID_PICTURE; > + break; > + } > + > svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr); > > return 0; Should be ok. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".