Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

[Martin Storsjö]

On Mon, 24 Mar 2025, Gyan Doshi wrote:

> ffmpeg | branch: master | Gyan Doshi <ffmpeg@gyani.pro> | Sat Mar 15 16:51:05 2025 +0530| [cbbc927a67f142a02bfc5d047c03587599ee5b55] | committer: Gyan Doshi
>
> ffmpeg: add per-stream input option drop_changed
>
> This is a replacement in ffmpeg for the deprecated avcodec flag AV_CODEC_FLAG_DROPCHANGED.
>
> This option is meant to be used when the filtergraph should not be
> reinited upon input parameter changes as that leads to loss of state
> in the filtergraph potentially leading to broken or aborted output,
> e.g. inserting of silence with first_pts specified in aresample.
>
> Generally useful to avoid corrupted yet decodable packets in live
> streaming inputs.
>
> This option when enabled takes precedence over reinit_filters
>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=cbbc927a67f142a02bfc5d047c03587599ee5b55
> ---

This change is causing failed fate tests in many different configurations; 
I'm seeing null pointer dereferences and similar, on both msvc/arm, 
msvc/x86_32, macos/aarch64. Please investigate.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Martin
> Storsjö
> Sent: Montag, 24. März 2025 13:32
> To: ffmpeg-devel@ffmpeg.org; Gyan Doshi <ffmpeg@gyani.pro>
> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input
> option drop_changed
> 
> On Mon, 24 Mar 2025, Gyan Doshi wrote:
> 
> > ffmpeg | branch: master | Gyan Doshi <ffmpeg@gyani.pro> | Sat Mar 15
> 16:51:05 2025 +0530| [cbbc927a67f142a02bfc5d047c03587599ee5b55] |
> committer: Gyan Doshi
> >
> > ffmpeg: add per-stream input option drop_changed
> >
> > This is a replacement in ffmpeg for the deprecated avcodec flag
> AV_CODEC_FLAG_DROPCHANGED.
> >
> > This option is meant to be used when the filtergraph should not be
> > reinited upon input parameter changes as that leads to loss of state
> > in the filtergraph potentially leading to broken or aborted output,
> > e.g. inserting of silence with first_pts specified in aresample.
> >
> > Generally useful to avoid corrupted yet decodable packets in live
> > streaming inputs.
> >
> > This option when enabled takes precedence over reinit_filters
> >
> >>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=cbbc927a67f142
> a02bfc5d047c03587599ee5b55
> > ---
> 
> This change is causing failed fate tests in many different
> configurations;
> I'm seeing null pointer dereferences and similar, on both msvc/arm,
> msvc/x86_32, macos/aarch64. Please investigate.
> 
> // Martin
> 
> _______________________________________________


I'm seeing the same (there was a disk space warning though, that's why I was hesitating).

If you need a log you can look here: 

https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=83609&view=logs&j=f4a2bb40-7e70-5f50-d570-7d7c5c8ca123&t=28db4af1-c17a-5ad6-7967-acadf04ad18b

Best
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 1452 bytes --]

On 3/24/2025 9:31 AM, Martin Storsjö wrote:
> On Mon, 24 Mar 2025, Gyan Doshi wrote:
> 
>> ffmpeg | branch: master | Gyan Doshi <ffmpeg@gyani.pro> | Sat Mar 15 
>> 16:51:05 2025 +0530| [cbbc927a67f142a02bfc5d047c03587599ee5b55] | 
>> committer: Gyan Doshi
>>
>> ffmpeg: add per-stream input option drop_changed
>>
>> This is a replacement in ffmpeg for the deprecated avcodec flag 
>> AV_CODEC_FLAG_DROPCHANGED.
>>
>> This option is meant to be used when the filtergraph should not be
>> reinited upon input parameter changes as that leads to loss of state
>> in the filtergraph potentially leading to broken or aborted output,
>> e.g. inserting of silence with first_pts specified in aresample.
>>
>> Generally useful to avoid corrupted yet decodable packets in live
>> streaming inputs.
>>
>> This option when enabled takes precedence over reinit_filters
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/? 
>>> a=commit;h=cbbc927a67f142a02bfc5d047c03587599ee5b55
>> ---
> 
> This change is causing failed fate tests in many different 
> configurations; I'm seeing null pointer dereferences and similar, on 
> both msvc/arm, msvc/x86_32, macos/aarch64. Please investigate.

I pushed a quick fix, but nonetheless, the log message in question is 
being printed for one stream (the last one handled by the scheduler) 
rather than every stream where the option was the for, so it needs to be 
properly done still.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

[Gyan Doshi]

On 2025-03-24 06:42 pm, James Almer wrote:
> On 3/24/2025 9:31 AM, Martin Storsjö wrote:
>> On Mon, 24 Mar 2025, Gyan Doshi wrote:
>>
>>> ffmpeg | branch: master | Gyan Doshi <ffmpeg@gyani.pro> | Sat Mar 15 
>>> 16:51:05 2025 +0530| [cbbc927a67f142a02bfc5d047c03587599ee5b55] | 
>>> committer: Gyan Doshi
>>>
>>> ffmpeg: add per-stream input option drop_changed
>>>
>>> This is a replacement in ffmpeg for the deprecated avcodec flag 
>>> AV_CODEC_FLAG_DROPCHANGED.
>>>
>>> This option is meant to be used when the filtergraph should not be
>>> reinited upon input parameter changes as that leads to loss of state
>>> in the filtergraph potentially leading to broken or aborted output,
>>> e.g. inserting of silence with first_pts specified in aresample.
>>>
>>> Generally useful to avoid corrupted yet decodable packets in live
>>> streaming inputs.
>>>
>>> This option when enabled takes precedence over reinit_filters
>>>
>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/? 
>>>> a=commit;h=cbbc927a67f142a02bfc5d047c03587599ee5b55
>>> ---
>>
>> This change is causing failed fate tests in many different 
>> configurations; I'm seeing null pointer dereferences and similar, on 
>> both msvc/arm, msvc/x86_32, macos/aarch64. Please investigate.
>
> I pushed a quick fix, but nonetheless, the log message in question is 
> being printed for one stream (the last one handled by the scheduler) 
> rather than every stream where the option was the for, so it needs to 
> be properly done still.

Thanks. FATE passed here and on Patchwork as well.

If ifp can be NULL, how come this pre-existing line above,

           if (ifp->type_src == AVMEDIA_TYPE_SUBTITLE) {

didn't lead to FATE failures?

Re: log, the final log is printed for each stream:

e.g., from the log of a command with option applied to aud and vid,

[af#0:1 @ 000001b4af668380] Total changed input frames dropped : 234
[vf#0:0 @ 000001b4af3e0540] Total changed input frames dropped : 149

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: add per-stream input option drop_changed

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 2197 bytes --]

On 3/24/2025 10:29 AM, Gyan Doshi wrote:
> 
> 
> On 2025-03-24 06:42 pm, James Almer wrote:
>> On 3/24/2025 9:31 AM, Martin Storsjö wrote:
>>> On Mon, 24 Mar 2025, Gyan Doshi wrote:
>>>
>>>> ffmpeg | branch: master | Gyan Doshi <ffmpeg@gyani.pro> | Sat Mar 15 
>>>> 16:51:05 2025 +0530| [cbbc927a67f142a02bfc5d047c03587599ee5b55] | 
>>>> committer: Gyan Doshi
>>>>
>>>> ffmpeg: add per-stream input option drop_changed
>>>>
>>>> This is a replacement in ffmpeg for the deprecated avcodec flag 
>>>> AV_CODEC_FLAG_DROPCHANGED.
>>>>
>>>> This option is meant to be used when the filtergraph should not be
>>>> reinited upon input parameter changes as that leads to loss of state
>>>> in the filtergraph potentially leading to broken or aborted output,
>>>> e.g. inserting of silence with first_pts specified in aresample.
>>>>
>>>> Generally useful to avoid corrupted yet decodable packets in live
>>>> streaming inputs.
>>>>
>>>> This option when enabled takes precedence over reinit_filters
>>>>
>>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/? 
>>>>> a=commit;h=cbbc927a67f142a02bfc5d047c03587599ee5b55
>>>> ---
>>>
>>> This change is causing failed fate tests in many different 
>>> configurations; I'm seeing null pointer dereferences and similar, on 
>>> both msvc/arm, msvc/x86_32, macos/aarch64. Please investigate.
>>
>> I pushed a quick fix, but nonetheless, the log message in question is 
>> being printed for one stream (the last one handled by the scheduler) 
>> rather than every stream where the option was the for, so it needs to 
>> be properly done still.
> 
> Thanks. FATE passed here and on Patchwork as well.
> 
> If ifp can be NULL, how come this pre-existing line above,
> 
>            if (ifp->type_src == AVMEDIA_TYPE_SUBTITLE) {
> 
> didn't lead to FATE failures?

The goto read_frames before ifp is ever set.

> 
> Re: log, the final log is printed for each stream:
> 
> e.g., from the log of a command with option applied to aud and vid,
> 
> [af#0:1 @ 000001b4af668380] Total changed input frames dropped : 234
> [vf#0:0 @ 000001b4af3e0540] Total changed input frames dropped : 149

Oh, i see.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".