From: "Martin Storsjö" <martin@martin.st> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d12va: remove unused variables Date: Thu, 21 Dec 2023 14:42:36 +0200 (EET) Message-ID: <b3c471-9156-5986-120-a5f69e2c1ec@martin.st> (raw) In-Reply-To: <20231221123453.8125-3-jamrial@gmail.com> On Thu, 21 Dec 2023, James Almer wrote: > Removes -Wunused-variable warnings. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > Were this meant to be used? Or are just a remnant of a previous interation of > the set? > > libavutil/hwcontext_d3d12va.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c > index 4ce29f250c..46832fd19b 100644 > --- a/libavutil/hwcontext_d3d12va.c > +++ b/libavutil/hwcontext_d3d12va.c > @@ -173,7 +173,6 @@ fail: > > static void d3d12va_frames_uninit(AVHWFramesContext *ctx) > { > - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; > D3D12VAFramesContext *s = ctx->internal->priv; Here, I'd prefer to get rid of the extra spaces once the other line, which it was aligned to, is gone. > static int d3d12va_frames_init(AVHWFramesContext *ctx) > { > AVD3D12VAFramesContext *hwctx = ctx->hwctx; > - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; > - D3D12VAFramesContext *s = ctx->internal->priv; Ditto // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-21 12:42 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-21 12:34 [FFmpeg-devel] [PATCH 1/3] avutil/hwcontext_d3d12va: cast the input pointer array argument on av_image_copy calls James Almer 2023-12-21 12:34 ` [FFmpeg-devel] [PATCH 2/3] avutil/hwcontext_d3d12va: fix indentation in d3d12va_transfer_data() James Almer 2023-12-21 12:34 ` [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d12va: remove unused variables James Almer 2023-12-21 12:42 ` Martin Storsjö [this message] 2023-12-21 12:46 ` James Almer 2023-12-21 12:53 ` Wu, Tong1
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b3c471-9156-5986-120-a5f69e2c1ec@martin.st \ --to=martin@martin.st \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git