From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0349644D79 for ; Sat, 25 Mar 2023 11:40:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DD7568C78A; Sat, 25 Mar 2023 13:40:35 +0200 (EET) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 115E568C479 for ; Sat, 25 Mar 2023 13:40:29 +0200 (EET) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-17ec8963db8so4427988fac.8 for ; Sat, 25 Mar 2023 04:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679744427; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=BRrr/cW2St02lPy1iJXZFfY2aLwN5I/GgxNa3Pw4SW8=; b=os5Ocnch2VF+G1FPwf/vWiJXjrIFz+ed5CVQ6dkc49P2VIIZrvN42zuttVG3IHC2iQ IJp3jr38SXnMhCVp+pblvk6HMv+N6DHbP5spufhwsg0JIOAhPJ78nOizno+XCdqgYVof bIby4DjE4Y1M9AFHZZ2t1kQL8YlbfR0ssRr/D4q3IQVlzxTXF+2tlHXwhCsCe5qpZe3S ODykJcq2TLSqJZNgPbbT4uT35UVS84N6E2/HrB38270ENDiH3XyxTRNhjXuhZd2Wduf5 9QAyXebnw1IrSQHnxnwVEer8tXA77I8BqBpvYvz9EOKk7FSVp3wEFBz/iGr6ouRMvFIF vv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679744427; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRrr/cW2St02lPy1iJXZFfY2aLwN5I/GgxNa3Pw4SW8=; b=tdfMN1jrt84YUO3E4q/G2OV/906tMwhrGpaghJqSI9vClDEZ8hJy7VKUe5t7bwIXp2 uhLN+lJyjftjkvqNXj2YU4hYYIWpCbUZyPqhnYFfstnukbhOYPBeTIMGVTfTYPRZ+nXB 1eKKSX+UayKzdMf5mc7r/CAUOpbit6Ohg6F+lXHeCNTXzVkGGK29J+5TIPxgghZ9n+VN 871uKdkqeObGxaxs/9POpxOomZ495gfsTgCmbuFd1c3HPtjmCnS8j+0e8GTCYbYngKQA PtGuY1jy7uinA2dgW+NL2XUmpmgOhiIY1LAgSn40450f4bntd96Wzo75Vzw8qATHONes 6aqg== X-Gm-Message-State: AO0yUKU0NGRLcuC8OhbqTndelOAyZUBnmJbv+e3iQ8s9qIY8eQoygCAu jzr20mvKAWXD3ci4cZtEBu6aiyh+2KA= X-Google-Smtp-Source: AK7set+7B0Fyv2yjSeww+QUfQfyuqL7fMN4uBJ84zO9NVDa7K1gvQFlIY0JucJ284Zqje3a7DBwKWw== X-Received: by 2002:a05:6870:ea9b:b0:176:6c0b:cd5c with SMTP id s27-20020a056870ea9b00b001766c0bcd5cmr4095999oap.22.1679744427041; Sat, 25 Mar 2023 04:40:27 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id yb10-20020a05687167ca00b001727d67f2dbsm8080420oab.40.2023.03.25.04.40.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 04:40:26 -0700 (PDT) Message-ID: Date: Sat, 25 Mar 2023 08:40:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: ffmpeg-devel@ffmpeg.org References: <20230324155213.3493-1-jamrial@gmail.com> <20230324155213.3493-5-jamrial@gmail.com> <20230325113922.GS375355@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20230325113922.GS375355@pb2> Subject: Re: [FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/25/2023 8:39 AM, Michael Niedermayer wrote: > On Fri, Mar 24, 2023 at 12:52:11PM -0300, James Almer wrote: >> A non zero value is mandatory for Matroska if the track has blocks with BlockAdditions. >> >> Signed-off-by: James Almer >> --- >> libavformat/matroskaenc.c | 39 +++++++++++++++++-- >> tests/ref/fate/aac-autobsf-adtstoasc | 4 +- >> tests/ref/fate/matroska-avoid-negative-ts | 4 +- >> tests/ref/fate/matroska-dovi-write-config7 | 4 +- >> tests/ref/fate/matroska-dovi-write-config8 | 4 +- >> tests/ref/fate/matroska-dvbsub-remux | 4 +- >> tests/ref/fate/matroska-encoding-delay | 14 +++---- >> tests/ref/fate/matroska-flac-extradata-update | 4 +- >> tests/ref/fate/matroska-h264-remux | 4 +- >> .../fate/matroska-mastering-display-metadata | 4 +- >> tests/ref/fate/matroska-move-cues-to-front | 4 +- >> tests/ref/fate/matroska-mpegts-remux | 4 +- >> tests/ref/fate/matroska-ms-mode | 4 +- >> tests/ref/fate/matroska-ogg-opus-remux | 10 ++--- >> tests/ref/fate/matroska-opus-remux | 10 ++--- >> tests/ref/fate/matroska-pgs-remux | 4 +- >> tests/ref/fate/matroska-pgs-remux-durations | 4 +- >> tests/ref/fate/matroska-qt-mode | 4 +- >> tests/ref/fate/matroska-spherical-mono-remux | 4 +- >> tests/ref/fate/matroska-vp8-alpha-remux | 4 +- >> tests/ref/fate/matroska-zero-length-block | 4 +- >> tests/ref/fate/rgb24-mkv | 4 +- >> tests/ref/fate/shortest-sub | 4 +- >> tests/ref/lavf-fate/av1.mkv | 4 +- >> tests/ref/lavf/mka | 4 +- >> tests/ref/lavf/mkv | 4 +- >> tests/ref/lavf/mkv_attachment | 4 +- >> 27 files changed, 98 insertions(+), 67 deletions(-) > > breaks fate-seek-lavf-mkv Yes, forgot to update that ref. Also for 6/7. Amended both locally. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".