From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element
Date: Sat, 25 Mar 2023 08:40:35 -0300
Message-ID: <b35f37d6-1d67-eabd-924f-ac3ae097167c@gmail.com> (raw)
In-Reply-To: <20230325113922.GS375355@pb2>
On 3/25/2023 8:39 AM, Michael Niedermayer wrote:
> On Fri, Mar 24, 2023 at 12:52:11PM -0300, James Almer wrote:
>> A non zero value is mandatory for Matroska if the track has blocks with BlockAdditions.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavformat/matroskaenc.c | 39 +++++++++++++++++--
>> tests/ref/fate/aac-autobsf-adtstoasc | 4 +-
>> tests/ref/fate/matroska-avoid-negative-ts | 4 +-
>> tests/ref/fate/matroska-dovi-write-config7 | 4 +-
>> tests/ref/fate/matroska-dovi-write-config8 | 4 +-
>> tests/ref/fate/matroska-dvbsub-remux | 4 +-
>> tests/ref/fate/matroska-encoding-delay | 14 +++----
>> tests/ref/fate/matroska-flac-extradata-update | 4 +-
>> tests/ref/fate/matroska-h264-remux | 4 +-
>> .../fate/matroska-mastering-display-metadata | 4 +-
>> tests/ref/fate/matroska-move-cues-to-front | 4 +-
>> tests/ref/fate/matroska-mpegts-remux | 4 +-
>> tests/ref/fate/matroska-ms-mode | 4 +-
>> tests/ref/fate/matroska-ogg-opus-remux | 10 ++---
>> tests/ref/fate/matroska-opus-remux | 10 ++---
>> tests/ref/fate/matroska-pgs-remux | 4 +-
>> tests/ref/fate/matroska-pgs-remux-durations | 4 +-
>> tests/ref/fate/matroska-qt-mode | 4 +-
>> tests/ref/fate/matroska-spherical-mono-remux | 4 +-
>> tests/ref/fate/matroska-vp8-alpha-remux | 4 +-
>> tests/ref/fate/matroska-zero-length-block | 4 +-
>> tests/ref/fate/rgb24-mkv | 4 +-
>> tests/ref/fate/shortest-sub | 4 +-
>> tests/ref/lavf-fate/av1.mkv | 4 +-
>> tests/ref/lavf/mka | 4 +-
>> tests/ref/lavf/mkv | 4 +-
>> tests/ref/lavf/mkv_attachment | 4 +-
>> 27 files changed, 98 insertions(+), 67 deletions(-)
>
> breaks fate-seek-lavf-mkv
Yes, forgot to update that ref. Also for 6/7. Amended both locally.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-25 11:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 15:52 [FFmpeg-devel] [PATCH v2 1/7] avformat/matroskadec: support parsing more than one BlockMore element James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v2 2/7] avformat/matroskadec: set the default value for BlockAddIDType James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v2 3/7] avformat/matroskadec: export Dynamic HDR10+ packet side data James Almer
2023-03-30 0:43 ` Andreas Rheinhardt
2023-03-30 1:51 ` James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v2 4/7] avformat/matroska: add a few more Block Addition ID Type enum values James Almer
2023-03-30 0:43 ` Andreas Rheinhardt
2023-03-30 0:48 ` James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element James Almer
2023-03-25 11:39 ` Michael Niedermayer
2023-03-25 11:40 ` James Almer [this message]
2023-03-30 0:44 ` Andreas Rheinhardt
2023-03-30 1:28 ` James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v3 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data James Almer
2023-03-28 15:33 ` [FFmpeg-devel] [PATCH v4 " James Almer
2023-03-30 0:44 ` [FFmpeg-devel] [PATCH v3 " Andreas Rheinhardt
2023-03-30 1:41 ` James Almer
2023-03-24 15:52 ` [FFmpeg-devel] [PATCH v3 7/7] fate/matroska: add HDR10+ muxing tests James Almer
2023-03-30 0:43 ` [FFmpeg-devel] [PATCH v2 1/7] avformat/matroskadec: support parsing more than one BlockMore element Andreas Rheinhardt
2023-03-30 0:57 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35f37d6-1d67-eabd-924f-ac3ae097167c@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git