From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5886B456CE for ; Sat, 18 Feb 2023 13:15:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7ADE68BE0B; Sat, 18 Feb 2023 15:15:21 +0200 (EET) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C513C68BD8A for ; Sat, 18 Feb 2023 15:15:15 +0200 (EET) Received: by mail-oo1-f43.google.com with SMTP id w9-20020a4a2749000000b0051f842ba672so46278oow.4 for ; Sat, 18 Feb 2023 05:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=+xlV2UudZ8fOpxu8GsFz1jfK824zvNd9RzeINfvJx3w=; b=fwnPs08Pt2CaCHgPMlhEmnUOab3yi8l81iaYKCWSZsEg+R14Rnc0PEmxpPZbL4+YW4 sQuye1z586Z6Cbpg78XyrvnqSielUspK4ppkB5vcOt9dhubqL6b8y6pqCGcT5yrVqiiR M+FEeIm4pqlDadwq1j97wA3z9CqS/dL7PBJv+cXHNhDdTw9kl5Elv8SGuDRr8qV4CUU9 bJVoS6epARV68AjXXTx5lVOm9Scv2O8yUlalqExHEhzKqr98KX19H/cHtfFeghSqyeym /Z9aaYVAxskm92+v3vuJGEkyn3jAx2nLEOWJZ4+Hu+jg2YGAuEHBVNx/xA+PJm0Db7xL 2iIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+xlV2UudZ8fOpxu8GsFz1jfK824zvNd9RzeINfvJx3w=; b=jcQWaPGjw8kqppf2+6cNiqaybsDbyCEkuGxlxIDLky6e9s9B9rQZc/GMNfMHN6/ABZ PSKI7SPELSc9lb5FXg8IIItJioiEiUA+EkzYUSmCZn0X611bc9x65y2/lOHfSY37FiOq 8qL3zPv6i3sVP3NPK66offk3EQcbmgO2RtPkmFJqLgWslZc6cM52a6/+gYpWcMl0Z1Y8 UYHWAv8hWH+eB0N98S6IiiT7Cm3hSN8H1XonPFzK/u3K7T3GYBKSO4dzVoEBcCelg8qq CRYLeVYdw8hxEQEBC5ySvkGCndqMLqgSMbAfMJfpTH/aVZCnvXnwmKBXTU/b8RJNhE+e JvcQ== X-Gm-Message-State: AO0yUKXXKiX5md/9kG3QqhtvOHhcEWs7JQe8K/9rQ685nOl48YESVpVA SDS4La7v1SxxJIpYyr1M62imsprPShQ= X-Google-Smtp-Source: AK7set/9IIUHFLKHL0fe9fCti1P6Oyk+nScvRwYwq4XAbX1kRYwFJpp3R9CiM1CBOjNGLB4dWAZdMA== X-Received: by 2002:a05:6820:131:b0:51a:a89a:4be3 with SMTP id i17-20020a056820013100b0051aa89a4be3mr2390179ood.9.1676726113787; Sat, 18 Feb 2023 05:15:13 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id h10-20020a4a940a000000b005175b972e52sm2939386ooi.31.2023.02.18.05.15.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 05:15:13 -0800 (PST) Message-ID: Date: Sat, 18 Feb 2023 10:15:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: ffmpeg-devel@ffmpeg.org References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/18/2023 8:52 AM, Lynne wrote: > Feb 18, 2023, 01:00 by h.leppkes@gmail.com: > >> On Fri, Feb 17, 2023 at 7:45 PM Lynne wrote: >> >>> >>> Feb 17, 2023, 18:08 by jamrial@gmail.com: >>> >>>> On 2/17/2023 1:54 PM, Lynne wrote: >>>> >>>>> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >>>>> >>>>> All filters and all codecs (except wmavoice) have been ported for the >>>>> lavu/tx API. >>>>> >>>>> The noise should be minimal. >>>>> >>>> >>>> It isn't. I'm getting more than two thousand lines of warnings after applying this patch from >>>> >>>> libavfilter/vf_spp.c >>>> libavfilter/x86/vf_spp.c >>>> libavcodec/asvenc.c >>>> libavcodec/avdct.c >>>> libavcodec/avfft.c >>>> libavcodec/dct.c >>>> libavcodec/fdctdsp.c >>>> libavcodec/fft_float.c >>>> libavcodec/fft_init_table.c >>>> libavcodec/idctdsp.c >>>> libavcodec/jfdctfst.c >>>> libavcodec/jfdctint.c >>>> libavcodec/jrevdct.c >>>> libavcodec/mpegaudiodsp.c >>>> libavcodec/mpegvideo_enc.c >>>> libavcodec/rdft.c >>>> libavcodec/wmavoice.c >>>> libavcodec/x86/dct_init.c >>>> libavcodec/x86/fft_init.c >>>> libavcodec/x86/mpegvideoenc.c >>>> >>>> It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. >>>> This patch is also missing the schedule FF_API deprecation wrapper. >>>> >>> >>> Is the noise acceptable if I just deprecate the functions? >>> It wasn't before, but it should be much less now. >>> >> >> An API we still use internally doesn't seem very deprecated to me. >> Should get rid of it, then there won't be any warnings. >> > > git grep av_fft_init | cut -d ':' -f 1 | uniq > libavcodec/avfft.c > libavcodec/avfft.h > libavcodec/tests/fft.c > > git grep av_dct_init | cut -d ':' -f 1 | uniq > libavcodec/avfft.c > libavcodec/avfft.h > libavcodec/tests/fft.c > > git grep av_rdft_init | cut -d ':' -f 1 | uniq > fftools/ffplay.c > libavcodec/avfft.c > libavcodec/avfft.h > libavcodec/tests/fft.c > > git grep av_mdct_init | cut -d ':' -f 1 | uniq > libavcodec/avfft.c > libavcodec/avfft.h > libavcodec/tests/fft.c > > git grep av_tx_init | cut -d ':' -f 1 | uniq > libavcodec/aacdec_template.c > libavcodec/aacenc.c > libavcodec/aacsbr_template.c > libavcodec/ac3dec.c > libavcodec/ac3enc_fixed.c > libavcodec/ac3enc_float.c > libavcodec/atrac1.c > libavcodec/atrac3.c > libavcodec/atrac3plusdec.c > libavcodec/atrac9dec.c > libavcodec/binkaudio.c > libavcodec/cook.c > libavcodec/dca_core.c > libavcodec/dca_lbr.c > libavcodec/dcaenc.c > libavcodec/dolby_e.c > libavcodec/hcadec.c > libavcodec/imc.c > libavcodec/nellymoserdec.c > libavcodec/nellymoserenc.c > libavcodec/on2avc.c > libavcodec/opusdec_celt.c > libavcodec/opusenc.c > libavcodec/opusenc_psy.c > libavcodec/qdm2.c > libavcodec/qdmc.c > libavcodec/siren.c > libavcodec/twinvq.c > libavcodec/vorbisdec.c > libavcodec/vorbisenc.c > libavcodec/wmadec.c > libavcodec/wmaenc.c > libavcodec/wmaprodec.c > libavfilter/af_adrc.c > libavfilter/af_afftdn.c > libavfilter/af_afftfilt.c > libavfilter/af_afir.c > libavfilter/af_apsyclip.c > libavfilter/af_arnndn.c > libavfilter/af_aspectralstats.c > libavfilter/af_atempo.c > libavfilter/af_dialoguenhance.c > libavfilter/af_firequalizer.c > libavfilter/af_headphone.c > libavfilter/af_sofalizer.c > libavfilter/af_superequalizer.c > libavfilter/af_surround.c > libavfilter/afir_template.c > libavfilter/asrc_afirsrc.c > libavfilter/asrc_sinc.c > libavfilter/avf_showcqt.c > libavfilter/avf_showcwt.c > libavfilter/avf_showfreqs.c > libavfilter/avf_showspatial.c > libavfilter/avf_showspectrum.c > libavfilter/vaf_spectrumsynth.c > libavfilter/vf_bm3d.c > libavfilter/vf_convolve.c > libavfilter/vf_fftdnoiz.c > libavfilter/vf_fftfilt.c > libavutil/tx.c > libavutil/tx.h > tests/checkasm/av_tx.c > tests/checkasm/synth_filter.c > > ...I rest my case. This is getting deprecated as soon as we reach a consensus > on what to mark as deprecated. git grep avcodec_dct_init | cut -d ':' -f 1 | uniq doc/APIchanges libavcodec/avdct.c libavcodec/avdct.h libavfilter/vf_spp.c Also, just deprecate the functions, not the structs. Said structs are being used in places like wmavoice and mpegaudiodsp using the internal versions of this API. so if you intention is to remove the entire fft/dct/rdft/mdct code from lavc, not just the public interface, then they need to be ported to lavu tx eventually. You also need to silence the warnings in the tests with the FF_{ENA,DISA}BLE_DEPRECATION_WARNINGS pragmas, and add a new FF_API_ deprecation wrapper where corresponds. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".