From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 789894334F for ; Wed, 30 Nov 2022 01:57:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B051968BA11; Wed, 30 Nov 2022 03:56:59 +0200 (EET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3794668ADCE for ; Wed, 30 Nov 2022 03:56:53 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669773418; x=1701309418; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=rl+SEPgWEMp5nuU8JSgvzUp+vrzsgzlsGluiwLG/yKE=; b=B/OG/gShzEFZjTykbh4OBP+DrDk5QcZvPYfBO8smRBYjdLo61nYgE19H y8NqSKZEZogyI9XaoRcw+F6rg6EV8V9WGyw8T6NYMGp3uTSAPcturL8Af BYuCsQG1kK9MiQ7vzICCfh8cisl8doaZlxfeVio1gkZ/5WOLBD4HbF9iA fXAWcCDrXBqKriPfn9XhghYKRb73XW9jbOsJojurCjaJRU9po3EbVgTyP PPIlMcvU3X9EFDE5cMxlloQAyE3bLVv33xuSjNHbxwyRxVFQeTq6arp9q RW/5RCt2d1k0AbqsrTTpNCzJUDpkeNH2NSFnYGujKys8xhck4QexAMB5n w==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="316434493" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="316434493" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 17:56:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="637821417" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="637821417" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 29 Nov 2022 17:56:41 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 29 Nov 2022 17:56:41 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 29 Nov 2022 17:56:41 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 29 Nov 2022 17:56:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMk6lQSzSHqgPa28+hvWN7MFZTt75uGiH2Vq6CqsshDRkeUlRYttpNp4hNJG6F6Z2guUJv18S95YcKgl1wy5FtOyL9hCTn7sgb9N2BJlK5z8oCdPTCsROXjXy9k+8PxpBW42rV+RJhHLU7JFZO8SUAV+FbctqnxEX8qpU/mXqrF8nzrJF2z1ZIZ6o3X7Qr7I4W1g9p89lsFD7ModJzZnnO1Q6snj4oOHN6rNTHXrjN1ZVMumBUU+4rnrHgsLh8WYOfyAY5J3YY3hFExsPOdD3NDHpcMEgH8NkFyBQQrZuZjEtghP+nqke7j+aYT70wPnQwcIGka3ykQsKe9MO3EK9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rl+SEPgWEMp5nuU8JSgvzUp+vrzsgzlsGluiwLG/yKE=; b=Sx9k3gasyoCd/2URJYagVA/ZZX7/43b7umRsfrL+Anfezbjw3FKuMSh7rXkOXqYvrAx8/iacq7lVnX3C34YbRgUVCisD7Smmm7y9YJ90nQoPQfDo4lN68VJJIreKYx44w5XjIWdrB0iLiuR5VK9qloNkgtwxeYCFvhbPOujcjtXThWbinlDEqSw/YNuWgnHwldu5jE4ZhpaKlQziQPqACUCymG2zloVPIMZ2aI5qzR8cWbt2SD2VG+CLh9ZwGx2NBSOn5kgHbxoL2TOtEvqRZW4HJsS2O4u8PVI6GtneEsVSAOpI19HF0vRrWGdtTG2tOorYdEXlxk2TECEZTAuVwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SN7PR11MB6828.namprd11.prod.outlook.com (2603:10b6:806:2a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 01:56:34 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 01:56:34 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc.c: Enable MFX_GOP_STRICT when adpative gop is disabled Thread-Index: AQHY/68tB8KY+0IwFEWXwzoerNy+Eq5WvpOA Date: Wed, 30 Nov 2022 01:56:34 +0000 Message-ID: References: <20221124024729.881574-1-wenbin.chen@intel.com> In-Reply-To: <20221124024729.881574-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|SN7PR11MB6828:EE_ x-ms-office365-filtering-correlation-id: 78aa641b-8afa-4036-acc4-08dad2761c05 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YAaZJFaiLeGtUnXV4PW2sQBG7AeL3SYqlws9XhmhgaVJQB3gz0SFiLZlYkWmQ+PhbpdJASzdK1D8F9HrSDqjpRLXuGdSsLmIQypJidjIz/HEEMMT4YMgeZ2deAhEqIlzIUy8jZ5+jSeoveDCqxtuZP3C9urQT0erqefg5fOX6MRKoxT2pVeFwclP2uCvAl2WomdZRrsXU1UruYIUk/i1Vq0hJM3hPnXlxBLeb7WWBSs2vUwSCBMyqgwpsRwfI6Je2xYd8wqNNDEb7SeEC3jBfPAlX4OVZdFvTS4Ii9nwuTNiiPcCyVcgWOTRQ3pSmQIi2fuo4ODXm2nv1ctK7I998P1QPCoWdEBXyS8VKNxnxVzfYSTmEO8XHJAfjfQo/PZyCfCtCvq1Z0CyAoaNs/rjOsPnznNe0VE7TctO9t/LGAmLwTK81K7QL7kVwF7imICdpKCQQa7ZL5dM4NZRi17ZGRkolnwmMHeI4fi9TYMMudapZ8yjPFXYhjZQvfoUCXwYCm9bq+ixf6wOp34B13HGGDpONO9EhEA5eyAh/FM/FLpAKcI6f4Z0pwAa0rYme9PIQS/UdYeFLg8GdWdJkV5ase5xI3FsHTMSz8JN0F+i8NBiABSSvVcXjVZuDQNI9zdymctFEGuJ/f4qQK32Qt6V2mLU/PEeZruZq0GPW2WORGTVXPtG87V4+ws4OpCQv3TW0smKv3lzTgZpYAT2rnjM6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199015)(36756003)(38070700005)(86362001)(6486002)(6506007)(71200400001)(6512007)(26005)(5660300002)(6916009)(66556008)(478600001)(8936002)(91956017)(41300700001)(2906002)(66446008)(4001150100001)(66946007)(64756008)(8676002)(66476007)(76116006)(316002)(82960400001)(122000001)(2616005)(186003)(38100700002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UU4xNmx3SWhFQ2VTZlhoRmY5WkJTZmN5M0ttc1hNa29mQ055YUlpbHQvcDZm?= =?utf-8?B?a1ZETVFmclp6ZVcrSDMvQ1Z4T3VKT1VRamNmRmF6QkRzSklIblFPSyt2U29r?= =?utf-8?B?ZWRWOXpxTjd4V2RJQTNaeWpjeG9kZFhkYzQwMTl3ckdUcWlJTXZmRXhjbzVI?= =?utf-8?B?NUZZU0pIZm4zQzhTUTNFMmtGMWtGeDRXeDlMdFVrVWhPVWNDNFprK0xaRDZa?= =?utf-8?B?ZzR1ME1uQ2wvK0E5dWZQSVdVZzlqcG5mNytoeVA5YWdlSXgxWWdEeHpSQmFG?= =?utf-8?B?d3NJYVdFMVF0SVpIQmUvNEFrSThxRWZTVG1tYzcySEEvYWV6NEVpY3ZWVGNw?= =?utf-8?B?aUowY2xGSEhGUFlSUU9LZEYxT3NNRUIxMTlaTEF4Z1lmR1NRTWhaRFJ3WHh5?= =?utf-8?B?UnRpQmgxVzN5Skl0ejBVblFGYmpHTld4NzVLSXZzT0RYMnhHZlRjQ2pZaDhs?= =?utf-8?B?NExHckFsK1k2bGlrNHdmd3l1NUJxOVFTeFpMU0hCQUJwMFNrcERVemFwWDNj?= =?utf-8?B?UWZFRUxTN2xnMGdOeVl3WVRSN3hLZEE4N1QzUFlqK1V3ZlFTNEFmOHFIRTNm?= =?utf-8?B?SW44NzZnNGRnbEE2dmtpYlhRc3ZOei9lZ092VTZYV0x6TWRIWlo5RWwxVzhx?= =?utf-8?B?RjlYMHpTZzN0WE1HR29YUFZNYm1pSnlMcEpFYUNZd1UzaEVCcEhUa1NwRzI4?= =?utf-8?B?a1VTajlncGo2cEhoS0U1WFh2dU05aHdhaWJkN1VpV0dibnoxc3JINVptRHJU?= =?utf-8?B?YWtCVDB5U1VsS2NQbHc3L1ZGOS9wL05MQXZERnpwYzNuSUhZVHF5R3IrYWdV?= =?utf-8?B?YmR5a2FTOExtM2NpSnk0YThWZWVlMmRFMTNwd2U0RmxMMmJXYTZkVE9iRzc1?= =?utf-8?B?OG15LzluMHRXdUFYT0VNSGRTN2gvQ3ZkZFhWTVg3NktTK1ZlWUh4cFBMaUUy?= =?utf-8?B?eW9zYmxuL0RMTHJLUkhOYnM0d2Y0YXNsNzNnVkNneFBNdnFhMEJMTjI1Z0F6?= =?utf-8?B?SU80VXRacitpbHRWaU1oUUE0SVF0Y2cvMGRWNTVLZWtUbFlrM0NheXBNbGRm?= =?utf-8?B?S1ZPTE50RGJCaXZUZzNDYzl3eUlnNnZyblVrS1J6N25pSFJFbUhzSUhkNzFj?= =?utf-8?B?eVBnRks3V3REQ2QwU3hoMHVVQnlnSW11ZkV3TjVNeTE5U2huRGczMFVVZk9x?= =?utf-8?B?b0RHbEhCNG1kZ3lhZFV2NHMyZkx2VXdvZWwvU3ZtekxnY1dMMERRcGdpcjE0?= =?utf-8?B?bmpxNGJLdUZ5VlQ3dG13L1MydDJhWjEvYW9maWlJVVlhbkQzckRmdTRPNHM2?= =?utf-8?B?VUl1Y0UxdDVUaHMzTVJ2MUNlakZ1UUFlbHBvR0dDN3J2bEVNWXBNeFNiUzB4?= =?utf-8?B?cTduaG03cWF2Y0tCMk1sTTVwSWtNY3hWb3M0RDYxU2N6K05uTmJ6RU8xU3Jm?= =?utf-8?B?S3htbzJqQXRtby82NEtrY1VYUWVpQm4zSzVReFRycUJYRkNmNnhkSXMzckpL?= =?utf-8?B?WTZnbFFvVk56NXhoQ2VETlhOVVkyUllkdkZ2Vk84YjJPTGZTRzQ1S00zYjZ4?= =?utf-8?B?anovbXZBbXZ1cDAxdXUvSDkvdHdScnFVbmJVSlFvQnF2UjROZXcwUWs3dUJt?= =?utf-8?B?cVNUcGIwMU1zWjBWZGpRVnJLV1NJcWIrQlVaR3A4QWlIdUNyZmdVZm1xVkRR?= =?utf-8?B?NEVPNnl6Y0tDRFlON3ByWnU0T0VQTzBLNG13MURxWDNXdittRTN4b2ZjRFYy?= =?utf-8?B?N0dXSFpiZjRaOVlHZks1VzZORm9NT3NpeGZxZlFjd2hoajYxZTd0OHhZSENQ?= =?utf-8?B?T1RtWWZyVWtrRzBUZnBrcU9ROGVKZDZ2SGd3VnRTNmIxTnFENUk2OEdnRWRO?= =?utf-8?B?emVyV2E0aU9qNThqMFQyZ3grVmhEMnQvenJxWFR4UngvdWs5eGJLSUpIYzNC?= =?utf-8?B?Umk2ZEtGa2FTVy9ib2l5ME1PY2NXS1NVSEYzQW11UWtIcHBGVFhyRktTRWdK?= =?utf-8?B?NU9vRnRtanE2Rm00NDVXVWQvZktDNDZnbVQ1WDJjUUFmQjREUktMcFhlUG0r?= =?utf-8?B?OHhtVkFzTFNRNFFTYkpmOEZ5OGIzcFROcW4zSkFnTEwzSkc2enR3VnF3cGJE?= =?utf-8?B?OHBrczNIQmhFOExnLzFDMS9jVFNHS3krcjZ5ZWlWRkFnazVJekxSK2xDYm9w?= =?utf-8?B?V1E9PQ==?= Content-ID: <8DC554808091254A8AE5992B02A56DF0@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78aa641b-8afa-4036-acc4-08dad2761c05 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 01:56:34.3985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qDZzRMU86D3+S2bD4tBDUPivvh5jFO/I8mOozBEAvPD1GBKg5VOr1VRhiRSjBUJvtFS8/U3K8CTdpzCSlrenEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6828 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc.c: Enable MFX_GOP_STRICT when adpative gop is disabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-11-24 at 10:47 +0800, wenbin.chen-at-intel.com@ffmpeg.org wrote: > From: Wenbin Chen > > adaptive_i and adaptive_b cannot work with MFX_GOP_STRICT, > so only enable MFX_GOP_STRICT when these features are disabled. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index d5e9f2d420..514a1e8148 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -644,6 +644,12 @@ static int check_enc_param(AVCodecContext *avctx, > QSVEncContext *q) > return 1; > } > > +static int is_strict_gop(QSVEncContext *q) { > + if (q->adaptive_b == 0 && q->adaptive_i == 0) > + return 1; > + return 0; > +} > + > static int init_video_param_jpeg(AVCodecContext *avctx, QSVEncContext *q) > { > enum AVPixelFormat sw_format = avctx->pix_fmt == AV_PIX_FMT_QSV ? > @@ -755,7 +761,8 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->old_gop_size = avctx->gop_size; > q->param.mfx.GopRefDist = FFMAX(-1, avctx->max_b_frames) + 1; > q->param.mfx.GopOptFlag = avctx->flags & AV_CODEC_FLAG_CLOSED_GOP > ? > - MFX_GOP_CLOSED : MFX_GOP_STRICT; > + MFX_GOP_CLOSED : is_strict_gop(q) ? > + MFX_GOP_STRICT : 0; > q->param.mfx.IdrInterval = q->idr_interval; > q->param.mfx.NumSlice = avctx->slices; > q->param.mfx.NumRefFrame = FFMAX(0, avctx->refs); Will apply, thx -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".