From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C74E046A4C for ; Sun, 1 Oct 2023 19:40:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA9B968CCC1; Sun, 1 Oct 2023 22:40:36 +0300 (EEST) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C03768CB2F for ; Sun, 1 Oct 2023 22:40:30 +0300 (EEST) Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-57b64731334so8174016eaf.1 for ; Sun, 01 Oct 2023 12:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696189228; x=1696794028; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=etncYdjKSS0yHPXUxupwXya0oM9X19krNKaXsBD3HQk=; b=bOdKAtlrValOyfPI1mln+FFdRpgE4s7tC8tLM+STm6k1DlYbkiT+5k+ELBYSKT+C15 3noqxjPj2GGVfnOH5Y4nRe193b6R6mA7Na/DnhPe7TzbLu36pv8Egajz9ncHtMNnxqNW T0Fq5o4g+2b1sEfzFj15xWEvRa6LPhsqqzK+8j+wKN+DnsM/nMmf8MmjlVsrJk8f5Mrk jm0skqvR933fdNWhLxOVapvh3IsrsQorEYBQvutkVRbVRY7PDrrvXuz5UaF1JpMrElqe FcEgfoLOUHNzCi6zOpJJSx1p6RPpI0ab1on4uGT+2NNv5VHPaYu4I49nAmGVBipkDMc2 94Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696189228; x=1696794028; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=etncYdjKSS0yHPXUxupwXya0oM9X19krNKaXsBD3HQk=; b=M2niURnr2sqxlpwV7iWVdWRJNbn9uP0wOF3usQvaJZcbk1Y0vtFVuJtmyFc+FT/gxG rAe85mPvvKx7fXADljRSYtY0OnsByjdc7sQnflASfkEY+4lD0y345FVK1mPVx0pxrSDE huJq+fo/0JrtSPo+tesqyxOLNeFGLyntGvpvd0A+/rjwNysdF4iAYmsYQBhgX3VBBdAk C4fP7U8o60PWcLzdM4TIbCuK0DaLO3VYoiTeEMR31eznLASwWif4ZkvvdlnXKIDLQK0E 8eM/NgDLZU4i+sxJTR9XBPq2xEVrBPgzZ+gosR6po4MY+oqjb09ISCWLlCpK6vSYZytv tCsg== X-Gm-Message-State: AOJu0YzowKfZkmiJH/GNSISupIxFnY1iw+Wz3vFYLtcxeGg7ZcquOdTb SKEKVcsKVoMdGRCVASLdqaGENVVT+o8= X-Google-Smtp-Source: AGHT+IGYo2ngv/u9qwaO4ekrL9K0EDCt0rc333Wx4DZB6k6/stYFHuaVEKSSImhE+3k1pbVCMFzPcw== X-Received: by 2002:a05:6358:618c:b0:135:46d9:12f7 with SMTP id w12-20020a056358618c00b0013546d912f7mr10640310rww.26.1696189227980; Sun, 01 Oct 2023 12:40:27 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id a10-20020a62d40a000000b006926506de1csm18752410pfh.28.2023.10.01.12.40.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Oct 2023 12:40:27 -0700 (PDT) Message-ID: Date: Sun, 1 Oct 2023 16:40:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231001180106.27631-1-michael@niedermayer.cc> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/1/2023 3:24 PM, Kieran Kunhya wrote: > Sent from my mobile device > > On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, > wrote: > >> EAGAIN causes an assertion failure when it is returned from the decoder >> >> Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462 >> Fixes: assertion_IOT_instruction_decode_c_462/poc >> >> Found-by: Hardik Shah of Vehere (Dawn Treaders team) >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/h2645_parse.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h >> index 787ce971ee4..128dea09efb 100644 >> --- a/libavcodec/h2645_parse.h >> +++ b/libavcodec/h2645_parse.h >> @@ -123,7 +123,7 @@ static inline int get_nalsize(int nal_length_size, >> const uint8_t *buf, >> >> if (*buf_index >= buf_size - nal_length_size) { >> // the end of the buffer is reached, refill it >> - return AVERROR(EAGAIN); >> + return AVERROR_INVALIDDATA; >> } >> >> for (i = 0; i < nal_length_size; i++) >> -- >> 2.17.1 >> > > But these are not the same for an API user? I think that when get_nalsize() was written, this specific path was meant to be handled by internal callers (e.g, ff_h2645_packet_split) in some custom way, but ultimately none did, and simply treated all return codes < 0 as errors, propagating them all the way to the library user. So either code using get_nalsize() gets adapted to properly handle EAGAIN as "refill the buffer" (judging by the comment above), or just remove all pretensions of there being situations other than fatal errors and success, which is what Michael did. > > Kieran > >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".