* [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 [not found] <20220804230338.13682-1-gcs584.ref@yahoo.com> @ 2022-08-04 23:03 ` Gavin Smith 2022-08-06 20:44 ` Tomas Härdin 0 siblings, 1 reply; 7+ messages in thread From: Gavin Smith @ 2022-08-04 23:03 UTC (permalink / raw) To: ffmpeg-devel Some NLVEs may insert a KLV packet for EIA-608 data even though the number of encapsulated ANC packets is zero. --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 400941c348..f3d2cf4efa 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -509,7 +509,7 @@ static int mxf_get_eia608_packet(AVFormatContext *s, AVStream *st, AVPacket *pkt int did, sdid, data_length; int i, ret; - if (count != 1) + if (count > 1) av_log(s, AV_LOG_WARNING, "unsupported multiple ANC packets (%d) per KLV packet\n", count); for (i = 0; i < count; i++) { -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-08-04 23:03 ` [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 Gavin Smith @ 2022-08-06 20:44 ` Tomas Härdin 2022-09-07 14:28 ` Gavin Smith 0 siblings, 1 reply; 7+ messages in thread From: Tomas Härdin @ 2022-08-06 20:44 UTC (permalink / raw) To: FFmpeg development discussions and patches fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: > Some NLVEs may insert a KLV packet for EIA-608 data even though > the number of encapsulated ANC packets is zero. > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, but it's going to require a bit of plumbing in ffmpeg.c I think. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-08-06 20:44 ` Tomas Härdin @ 2022-09-07 14:28 ` Gavin Smith 2022-09-09 9:45 ` Tomas Härdin 0 siblings, 1 reply; 7+ messages in thread From: Gavin Smith @ 2022-09-07 14:28 UTC (permalink / raw) To: ffmpeg-devel On 06/08/2022 21:44, Tomas Härdin wrote: > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: >> Some NLVEs may insert a KLV packet for EIA-608 data even though >> the number of encapsulated ANC packets is zero. >> --- >> libavformat/mxfdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, but > it's going to require a bit of plumbing in ffmpeg.c I think. > > /Tomas Can this be merged since there have been no objections? Gavin. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-09-07 14:28 ` Gavin Smith @ 2022-09-09 9:45 ` Tomas Härdin 2022-09-09 15:33 ` Gavin Smith 0 siblings, 1 reply; 7+ messages in thread From: Tomas Härdin @ 2022-09-09 9:45 UTC (permalink / raw) To: FFmpeg development discussions and patches ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: > > On 06/08/2022 21:44, Tomas Härdin wrote: > > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: > > > Some NLVEs may insert a KLV packet for EIA-608 data even though > > > the number of encapsulated ANC packets is zero. > > > --- > > > libavformat/mxfdec.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, > > but > > it's going to require a bit of plumbing in ffmpeg.c I think. > > > > /Tomas > > Can this be merged since there have been no objections? Probably but I'm recovering from surgery, so some time next week for me unless someone else feels like pushing. I see there are other MXF patches too that I don't have the energy to deal with at the moment /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-09-09 9:45 ` Tomas Härdin @ 2022-09-09 15:33 ` Gavin Smith 2022-10-05 16:12 ` Gavin Smith 0 siblings, 1 reply; 7+ messages in thread From: Gavin Smith @ 2022-09-09 15:33 UTC (permalink / raw) To: ffmpeg-devel On 09/09/2022 10:45, Tomas Härdin wrote: > ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: >> On 06/08/2022 21:44, Tomas Härdin wrote: >>> fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: >>>> Some NLVEs may insert a KLV packet for EIA-608 data even though >>>> the number of encapsulated ANC packets is zero. >>>> --- >>>> libavformat/mxfdec.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, >>> but >>> it's going to require a bit of plumbing in ffmpeg.c I think. >>> >>> /Tomas >> Can this be merged since there have been no objections? > Probably but I'm recovering from surgery, so some time next week for me > unless someone else feels like pushing. I see there are other MXF > patches too that I don't have the energy to deal with at the moment > > /Tomas Thanks for the update. I wish you a speedy recovery. Gavin. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-09-09 15:33 ` Gavin Smith @ 2022-10-05 16:12 ` Gavin Smith 2022-10-06 8:26 ` Tomas Härdin 0 siblings, 1 reply; 7+ messages in thread From: Gavin Smith @ 2022-10-05 16:12 UTC (permalink / raw) To: FFmpeg development discussions and patches On 09/09/2022 16:33, Gavin Smith wrote: > > On 09/09/2022 10:45, Tomas Härdin wrote: >> ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: >>> On 06/08/2022 21:44, Tomas Härdin wrote: >>>> fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: >>>>> Some NLVEs may insert a KLV packet for EIA-608 data even though >>>>> the number of encapsulated ANC packets is zero. >>>>> --- >>>>> libavformat/mxfdec.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, >>>> but >>>> it's going to require a bit of plumbing in ffmpeg.c I think. >>>> >>>> /Tomas >>> Can this be merged since there have been no objections? >> Probably but I'm recovering from surgery, so some time next week for me >> unless someone else feels like pushing. I see there are other MXF >> patches too that I don't have the energy to deal with at the moment >> >> /Tomas > > > Thanks for the update. I wish you a speedy recovery. > Gavin. Any update on this? Thanks. Gavin. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 2022-10-05 16:12 ` Gavin Smith @ 2022-10-06 8:26 ` Tomas Härdin 0 siblings, 0 replies; 7+ messages in thread From: Tomas Härdin @ 2022-10-06 8:26 UTC (permalink / raw) To: FFmpeg development discussions and patches ons 2022-10-05 klockan 17:12 +0100 skrev Gavin Smith: > On 09/09/2022 16:33, Gavin Smith wrote: > > > > On 09/09/2022 10:45, Tomas Härdin wrote: > > > ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: > > > > On 06/08/2022 21:44, Tomas Härdin wrote: > > > > > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: > > > > > > Some NLVEs may insert a KLV packet for EIA-608 data even > > > > > > though > > > > > > the number of encapsulated ANC packets is zero. > > > > > > --- > > > > > > libavformat/mxfdec.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Looks OK. Also I'm looking at maybe adding S436m support to > > > > > mxfenc, > > > > > but > > > > > it's going to require a bit of plumbing in ffmpeg.c I think. > > > > > > > > > > /Tomas > > > > Can this be merged since there have been no objections? > > > Probably but I'm recovering from surgery, so some time next week > > > for me > > > unless someone else feels like pushing. I see there are other MXF > > > patches too that I don't have the energy to deal with at the > > > moment > > > > > > /Tomas > > > > > > Thanks for the update. I wish you a speedy recovery. > > Gavin. > > > > Any update on this? Thanks. Gavin. Pushed. Sorry for the delay /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-06 8:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220804230338.13682-1-gcs584.ref@yahoo.com>
2022-08-04 23:03 ` [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0 Gavin Smith
2022-08-06 20:44 ` Tomas Härdin
2022-09-07 14:28 ` Gavin Smith
2022-09-09 9:45 ` Tomas Härdin
2022-09-09 15:33 ` Gavin Smith
2022-10-05 16:12 ` Gavin Smith
2022-10-06 8:26 ` Tomas Härdin
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git