From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 278E14B292 for ; Tue, 2 Jul 2024 20:46:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C74D868D265; Tue, 2 Jul 2024 23:46:22 +0300 (EEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 924C068D54C for ; Tue, 2 Jul 2024 23:46:16 +0300 (EEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2eaae2a6dc1so61921301fa.0 for ; Tue, 02 Jul 2024 13:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1719953176; x=1720557976; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=90a8rvQbDLL4ZYBvDVQ/vJvDO8ftapYm43zNXgNWXL0=; b=IanaazRQFg03Q/zpOO4VGQAP0dkJLKnSWcsRXczkfe4UeK+PHGp1SJmheRxCmRMyqZ JqTg2ytYJ9KQYBtlCnUB8+QOqxa58AWPctusWWd/mNsLXBbtWwhqWLsXAWhmxaZXqiKl grj1CNC09pJBm1WCQEtSZidechPNldpIr8/+apOl9jGf+61juQJcxwg9OTu9J56h4U2g 6MMMLSAK+2sPKVtW6mZek7XETUeLNZ2V2mlBz3yMozCSsJ0hPxxBcZqe2iOP8GNcLhW+ fjZY2ixmqLU9u0xMb5yGH+32q3p3pY5kzQsKcf64h9LKjInxga8Ox6dcVcibf/TkUJ2O tI6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719953176; x=1720557976; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=90a8rvQbDLL4ZYBvDVQ/vJvDO8ftapYm43zNXgNWXL0=; b=VWbN6WnA/VECh4ufIPac+qrB+byO1Q8xgwjwtYodkN66rReKliALpEgQ7EJTEQ2thF UmgUwqlMuDOn6zN/pxSArfpgp2uMz3XwzFeWDr3z9rpEnDINg/kv9jSybczWRGnTJA3I hMl+s3kGCkcktJkmaEiC1AsALKghtznYjiU7k1UjADprkiaH0gna998O3CkiPbqX/l4F SfwFmfXWWcVt0FLTLuBM10WRrQXevlKQoJ+nrQUlcCnEfBdbi44KhCqSUOnkno8mGWlu N/NiJEYjyDq7lIzrrGNVt1+nkchSr3PzBZMXRKFRCiiJIxePkyjfDjMPgjy0eLxoCmQN XAvQ== X-Gm-Message-State: AOJu0YxE5KzDUaW6Qvb7cAT+OYGEjBR4gx5dxHlS6FGPzOBrqrLZmXrC icHjwNthSLhQQIv0oo5l/sANDFncYt6Na3Gd+b7QVslSMum55NHCWBxIOKrk7aok3TrwEyhR4Z1 oTw== X-Google-Smtp-Source: AGHT+IFllNPWdFAa2HNTSdFiqxhc2rLg2NuYONYRBrKPqnUZj0TQ6pjuGQjMQorDI7+RS6t13tiZuA== X-Received: by 2002:a2e:9985:0:b0:2ee:5b32:9d5d with SMTP id 38308e7fff4ca-2ee5e707c04mr70311391fa.47.1719953175539; Tue, 02 Jul 2024 13:46:15 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ee51622ad0sm17589911fa.53.2024.07.02.13.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 13:46:15 -0700 (PDT) Date: Tue, 2 Jul 2024 23:46:12 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240626105738.58427-3-martin@martin.st> Message-ID: References: <20240626105738.58427-1-martin@martin.st> <20240626105738.58427-3-martin@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 26 Jun 2024, Martin Storsj=F6 wrote: > Previously, vs->start_pos was never 0 here, unless using the > -hls_segment_size option, which wasn't allowed for SEGMENT_TYPE_FMP4. > Therefore, this if statement was practically always taken anyway. > > Remove this bogus if statement, to allow changing vs->start_pos > to reflect the right value when not using the -hls_segment_size > option. > --- > libavformat/hlsenc.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) Ping Steven, is the second version of this patchset ok? The main = difference is this patch, which is new. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".