From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: xufuji456 <839789740@qq.com>
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add hevc idct4x4 neon of aarch64 after fixed
Date: Tue, 28 Feb 2023 13:15:17 +0200 (EET)
Message-ID: <b21358bf-e7c-7ad3-2fd3-434315c6ca88@martin.st> (raw)
In-Reply-To: <tencent_EFB23DF23E97FB8578B2BF63CC1993C16B09@qq.com>
On Fri, 24 Feb 2023, xufuji456 wrote:
> ---
> libavcodec/aarch64/hevcdsp_idct_neon.S | 40 +++++++++++++++++++++++
> libavcodec/aarch64/hevcdsp_init_aarch64.c | 4 +++
> 2 files changed, 44 insertions(+)
Thanks, this looks good to me now, will push in a moment.
The subject of the commit doesn't need to include "after fixed" or such
comments - those comments are kinda irrelevant once the commit gets
pushed.
It's usually good practice to include checkasm benchmark numbers (and
mention what system the numbers are from) when posting assembly
optimizations.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-02-28 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 7:43 xufuji456
2023-02-28 11:15 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21358bf-e7c-7ad3-2fd3-434315c6ca88@martin.st \
--to=martin@martin.st \
--cc=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git