From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 09F624A89D for ; Mon, 17 Jun 2024 18:09:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 816EA68D77C; Mon, 17 Jun 2024 21:09:08 +0300 (EEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C231C68D57E for ; Mon, 17 Jun 2024 21:09:02 +0300 (EEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-704313fa830so3537204b3a.3 for ; Mon, 17 Jun 2024 11:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718647740; x=1719252540; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=jrWsNk8rO+fpxUqn7jR6d1fHHIbnngSOJI97XocxGQI=; b=IWE3RuROcWnXLL8PHlPg/HM8/y5pRZfJ3BFGsN9VODoeG3EFKv1AQ3R8tBRIoPcV+o o08MsDk2vZvIJzWOCiSyx602bAfwogvtM7QMVqh5YuUD/A67TYh+5AnTpi26Ww7B1SDt kJ41TgRCmteZo27oHFE7ERuPQWtMSa70Sgb6eZzrBXzqjDi4BZ3znZaYpU6NPhvD0g75 BAwRmn9N24N9ENOu1uGHeimtXEoj98l3lyDq69tQkRZ2ldF1/7sWPOht2zmbLXjXGg78 +fKNvUG5WghNFLhxLO+E0BprWZM8CNjFvyUh5vv+ScpvAjwQDOB4e7pe6iAvM+jJHhTm YTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718647740; x=1719252540; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jrWsNk8rO+fpxUqn7jR6d1fHHIbnngSOJI97XocxGQI=; b=EDWavAkBiWwPdoY2gHoho7/o/l8qTMI+wKuuhAg1xIGIm+R8P7+wz6HJUG5MuFbvZb t2vzxG4j4kY1ODMYqfAGwlpHgHYwQY9LzEKUzUw6ReRo4dOJQWCVMscizMkabClNo8zK lRj7dHfcB0M47wpqQM0NdNX75iPC9HDRhSQ4GwOHMLu7IbHIs8dGmikLZNAOVMcP/Zut AqeIF295BBA+KrG+7vBD6azfoOwfEwHSOFwcumMsHY9p4lYHzXCUWN2VnDvlrOPW6seo Rn+l9QNurvIXcXPAOCOSrZoiazJh52zoWhYNL83RP24dUhbbvUDXI0lcC2XZ5VggKaQO 2lyA== X-Gm-Message-State: AOJu0Yw3e1H30s315igTMCwJgfxmLJx2zW748zzDmOSbibXW5sYNhv24 uBxPI2UF3fQ9eHqR73k/l4ZPB82HPgAN92Y6hKZigWcRjQx/E37r12/mnQ== X-Google-Smtp-Source: AGHT+IEJSIeQlHXbsVq4BKcEkMWI80McXzIcbrFqzwZ5vfIS3StKX3Px3SrSlh/QpidW14Bjwe/xpg== X-Received: by 2002:a05:6a00:2716:b0:704:20b3:fe21 with SMTP id d2e1a72fcca58-705d714b66dmr9332262b3a.11.1718647739787; Mon, 17 Jun 2024 11:08:59 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb8f3ebsm7613126b3a.204.2024.06.17.11.08.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 11:08:59 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 15:09:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240617134141.224614-1-derek.buitenhuis@gmail.com> <20240617134141.224614-3-derek.buitenhuis@gmail.com> <361003f7-6234-4803-9089-5d4b69b537df@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/17/2024 2:07 PM, Derek Buitenhuis wrote: > On 6/17/2024 5:53 PM, James Almer wrote: >> Maybe this should be an AVRational then. > > While that is probably 'more correct', it does mean that in 100% places > this could be used, it'll have to be converted back to the -10000 to 10000 > range. Is there a simple way to do that with an AVRational that doesn't > involve a round trip to a double or float (i.e. lossy)? No, it's av_d2q(), av_q2d(), and av_rescale() as needed. Same as we do for Mastering Display and Ambient Viewing Environment Metadata. The reason to use AVRational is that in this specific spec the values have a denominator of 10000, but in others it doesn't need to, allowing for more precise values (Matroska would store it as a double, in fact). So we shouldn't define our API for one specific implementation but rather in a generic way that should accommodate to any potential implementation. I think we already did the former with a Google implementation (x.y fixed point values), and i want to avoid doing it again. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".