From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6F9F84F059 for ; Fri, 16 May 2025 08:19:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5722C68C886; Fri, 16 May 2025 11:19:40 +0300 (EEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D24F368C37D for ; Fri, 16 May 2025 11:19:33 +0300 (EEST) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-549b159c84cso2111602e87.3 for ; Fri, 16 May 2025 01:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1747383573; x=1747988373; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=4K14mmHZ0R4Y+lQHPdD4m2d6/LTHsA6OrpjO4mU7sdA=; b=tsh0pDkfrxuURHNQn3Q15coe1528hgJ4zzIGQfWvzDnxPe6IgBGZHD62Lxc3EA4zO2 BMylukBKGkhhAB+JiUC9AYvPDbvvVmkX5EmCZLBgGO5ZDxkxmML4xWWeZ5iFFTbaq8D2 Kq9F+NHNiCXun7MgHMfPjfC0QPN4qQIrwxXPTzERipDyQzZY0uxpjh6vwF8wz+1nbNzx BQRhToi9EzPmGpWrUnz2XspfWN3xNRmtW+dh3wChVKTAlABfHsUmCZCWo/YnO6cUzbmo HToRudqkcx7cvlrZk4yoOuTJA8TwddWl9ew4fa/5pN19GK+obBpYl1gaBUBsBkfpfJVK IkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747383573; x=1747988373; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4K14mmHZ0R4Y+lQHPdD4m2d6/LTHsA6OrpjO4mU7sdA=; b=tRAOW+gAFJNiPfky14fieDX/sBjl186ppQ8k05zHAUgoRIq8+5zzjwk/mtj7dSbPjE JWBCq0QQdEktbTT1UQtlPddm9H48f19AC9CLHBMkom87yAXdJIrrr8/zqwml5jupMlrI 4E/WUvp8Eke9HfrLtOKoyUpCqD0tUjofFLu0KfYORNPVL+4kPxEV4FNoyY3IFNEAkLTB 7iubzmrOgOqfEgJnU8sScDpYH4G0oDDEey9wEJF+RLWRdcOWKWiL7RWZ4kwmCxmyPQ39 5KpHIgbCDLVAOGuf8R3ePGNzF3tDlMTAqaojMyd4yq4Meh3Er3wnI6+o3Hvck7rSKyFy UV9w== X-Gm-Message-State: AOJu0Yz5J5pCfvmbGoSTeTEqrO/epbDQHyT5lGhCw3NJHO6dYvxQMMrK rGp4xf9ZdhrNrwuuX+k14H3TggkFjfeU45LQnwialm1ybRRryngxdHXuJXkP2H3smWo94nAu15r KJbdECg== X-Gm-Gg: ASbGnctY7FDkXevGYZPwaCRQnL9f5DebQ8+/DURHKPXA8vv3CnI9R4uENMI5w79ZgEp +ZMLWJ8ot4wdAfT4xZO0UwWsxQUoB+YyJFUhQC7tuUgnfYJ4G2G6Es3HMmNCk/Nv3hPwGv6q1TG ZEgBCUGz+fLsZ24Xd+Oo0nMcBp2jDvw/HwIWMU9BlZQxbW/Lwz/gZPjgMVyB+GjEfBZs6WxL/Ib laAj/QdUpmyN6iS/aEZ8HZpEIoRKIrxnY6AqTVsFTwfrRSJosrU/TCeFsBVZ+F66Muuu/jBI2bX pM8va8MylfbbY19kpqIijoHcM69e9fyg01N2WBX+vOnj8ymWiGf2VAU7mBnxtnevaSqcaVnn/hO 7JKCmiDjlBiCEX0BFwNoV+iclczqNbodcpqSvupfrwLozDzM= X-Google-Smtp-Source: AGHT+IEif35h3kRbirHe5pQMAl+mSnJu//+bFjzx4STM0YS1kAOvORb/CcjM4YUi4ixXXjJDfXoFcA== X-Received: by 2002:a05:6512:6310:b0:54f:c811:8b76 with SMTP id 2adb3069b0e04-550e98fd0fcmr338313e87.36.1747383572672; Fri, 16 May 2025 01:19:32 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e6f34d4bsm325825e87.83.2025.05.16.01.19.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 01:19:32 -0700 (PDT) Date: Fri, 16 May 2025 11:19:27 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: <20250515211148.6C91C4128B8@natalya.videolan.org> <3df3113a-203a-11de-6bdb-6a3ed7771c94@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 16 May 2025, softworkz . wrote: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Martin >> Storsj=F6 >> Sent: Freitag, 16. Mai 2025 08:22 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, mak= e it a >> Killer-Feature! >> >> On Thu, 15 May 2025, softworkz wrote: >> >>> ffmpeg | branch: master | softworkz | Thu May 15 >> 23:10:02 2025 +0200| [1f2b8d7238eff4ab8a4d8d6177e250b8180d51f4] | commit= ter: >> softworkz >>> >>> fftools/graphprint: Now, make it a Killer-Feature! >>> >>> remember this: -sg <=3D means Show Graph >>> >>> Signed-off-by: softworkz >>> >>>> >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D1f2b8d7238= eff4ab8a4d >> 8d6177e250b8180d51f4 >>> --- >> >> This broke compilation in a number of configurations: >> >> Windows UWP/Phone: >> https://fate.ffmpeg.org/report.cgi?slot=3Darm-msvc2022- >> winphone&time=3D20250516053009 >> >> filelauncher.o : error LNK2019: unresolved external symbol ShellExecuteA >> referenced in function ff_open_html_in_browser >> ffmpeg_g.exe : fatal error LNK1120: 1 unresolved externals >> >> iOS: >> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- >> ios18&time=3D20250516011754 >> >> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: >> not available on iOS >> 61 | if (system(cmd) !=3D 0) >> | ^ >> /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/iPhoneOS.pla= tform/ >> Developer/SDKs/iPhoneOS.sdk/usr/include/_stdlib.h:184:6: >> note: 'system' has been explicitly marked unavailable here >> 184 | int system(const char *) __DARWIN_ALIAS_C(system); >> | ^ >> 1 error generated. >> >> tvOS: >> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- >> tvos18&time=3D20250516014542 >> >> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: >> not available on tvOS >> 61 | if (system(cmd) !=3D 0) >> | ^ >> /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/AppleTVOS.pl= atform >> /Developer/SDKs/AppleTVOS.sdk/usr/include/_stdlib.h:184:6: >> note: 'system' has been explicitly marked unavailable here >> 184 | int system(const char *) __DARWIN_ALIAS_C(system); >> | ^ >> 1 error generated. >> >> // Martin >> > > Hi Martin, > > do you think this is a reasonable condition for Apple in configure? > > enable browser_launch > if test -n "$sysroot"; then > case "$sysroot" in > */iPhone*.sdk|\ > */AppleTV*.sdk|\ > */WatchOS*.sdk|\ > */BridgeOS*.sdk) > disable browser_launch > ;; > esac > fi This is not how we normally do it. String matching trying to detect things = is generally brittle. If the problem is that we can't compile a call to = system(), the configure check should try to compile a call to system(), = and if that doesn't succeed, avoid compiling the code that does that. That = also works for e.g. ShellExecuteA. That said, I also agree with everybody else that I'd rather not have = ffmpeg do this at all. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".