From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 46DC74F0D5 for ; Fri, 16 May 2025 14:52:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9E83B68CEC1; Fri, 16 May 2025 17:52:15 +0300 (EEST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1572968C25B for ; Fri, 16 May 2025 17:52:09 +0300 (EEST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5f62d3ed994so4111074a12.2 for ; Fri, 16 May 2025 07:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747407128; x=1748011928; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=mW42Wrp9r7pZt2eZPV7tOX7wgYy40jpi9HJ9c48mXMs=; b=GKBYBDdJC0zw8ykfyCrqTRR024FlhOV16PUs8dL59b6+rZkyad8fJW7IjpB2hf/A5c oDVuV3A+l5LXT7KeAYKILjWEpCpAXovCS2VuQL/ckzqP5IphIVZfGerqJkv32rPhvloy 6v6omklQXf/phNQ8p+TRWhQcMWwQOfyHesk+LgKWWWFcLlLwLY1lfbIUC+jyC7cGwV4k BIbvk6SbdWLfJpV4r5/MtNO3HdpCE4S2zM/j4QCf13dnvb9+0UvcAyC65sBRqnSOgG7W cjmg2LXsAUmDYbAR5EOHfXGSb7yGjAVNxNoVUCGnRiPb/lBcF+0ZKg8Bsqiri6kZ7tV6 VL2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747407128; x=1748011928; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mW42Wrp9r7pZt2eZPV7tOX7wgYy40jpi9HJ9c48mXMs=; b=od3NOfy+frynNaCtIXiQOx2dSO1XTUobiaG293z26h+AYA0I/pQk4fm2dBbYoT6y20 QnUglOLKeXAlJGeh065kl/WbF1UwO75cC4Hc1HckRvCrKhokIjhYQOaNt5Fg3h8z4JnY cUtDnoERGi0/oWRfDmc+ZuVJCFrxNCTaiznqcefl+TnX1n+PSTPKEtgRqIwpH2ZugFeJ l2btg4QhSg/toMyVFM0B30Cth4irl10BIy6a2byNPHLnoNcBfBJJKU9m2IRsuctok9rE OeI5hglPZNBECOIfAKA2Gmgmoa6bffWTSv7oJMlIGa2kkQxKxwIRp+uw1mXcJ2Ci1LkP YGrw== X-Gm-Message-State: AOJu0YyVzljS8lCr6EPnzKP968Iu+11KcYnNubl8794rlJj+9LmFUwlr gm2xBQRG3pSkh6a4NsCg0J8mgw03KyMXuqZ3IP6bVN9Nhy008KNxnuI/xWwURLLU X-Gm-Gg: ASbGnct16uQml5d4TF7vZQn6CkOh28yD7DdATStXqsNHMjM/B4hEHVAD1b18eF+oi8h X1WZ6G2FtzGnXmQxEMOpo89EjOGE4SUIeVXW0/SzEitB2ykmFi/sJOlQ9jWol5ASVA64nPzoUpj X788eFbueeQ53wUAdkG+Hqq9vBJpBwXNwxu71uLRv+mAUYd8be9xMsEah94WgIpfUD3QuhUDzv1 M8pwygKuVBZFBOEeF+bWIgK/sddP+zjJqd7gKfM9mcrf6yM/JtmAeUshr4UohLfvz+6aA4sTWJk ovB0i2OUgRy1JrAwIRbGQCP1WNOzFjHKTW65HgTi059Mfh1TC0ssxjYy+3Zhyjd79VukZdITY8e oCjiWSfNWKXm6v4L8POetd8Co X-Google-Smtp-Source: AGHT+IES1mUkXExUFCM51+3ItT6wjlOgV2YUa8OTH6jyVGho0GcSDJGq2EnxUzqODILLsT0r/8Cbvg== X-Received: by 2002:a17:906:6a0d:b0:ad4:c55e:ef9b with SMTP id a640c23a62f3a-ad52d5fb40dmr425973366b.58.1747407126761; Fri, 16 May 2025 07:52:06 -0700 (PDT) Received: from [192.168.1.137] (20.238-74-193.fia-dyn.isp.proximus.be. [193.74.238.20]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4ea7b7sm170816666b.177.2025.05.16.07.52.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 07:52:06 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 16:52:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Ramiro Polla In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/16/25 16:06, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Patches attached. >> >> - Andreas >> > > Will apply this patchset tomorrow unless there are objections. [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros > diff --git a/libavutil/avassert.h b/libavutil/avassert.h > index 1895fb7551..d0d5aa0c7e 100644 > --- a/libavutil/avassert.h > +++ b/libavutil/avassert.h > @@ -75,4 +76,45 @@ > */ > void av_assert0_fpu(void); > > +/** > + * Asserts that are used as compiler optimization hints depending > + * upon ASSERT_LEVEL and NBDEBUG. > + * > + * Undefined behaviour occurs if execution reaches a point marked > + * with av_unreachable() or if a condition used with av_assume() > + * is false. > + * > + * The condition used with av_assume() should not have side-effects > + * and should be visible to the compiler. > + */ > +#if defined(ASSERT_LEVEL) ? ASSERT_LEVEL > 0 : !defined(HAVE_AV_CONFIG_H) && !defined(NDEBUG) > +#define av_unreachable(msg) \ > +do { \ > + av_log(NULL, AV_LOG_PANIC, \ > + "Code at %s:%d that was supposedly unreachable due to '%s' reached\n", \ > + __FILE__, __LINE__, msg); \ The message sounds weird (especially that dangling "reached" at the end). What about: "Reached supposedly unreachable code at %s:%d: %s\n" or any other variation where the reason message gets printed at the end. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".