From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D33C547247 for ; Sat, 2 Sep 2023 09:20:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9780368C7A7; Sat, 2 Sep 2023 12:20:21 +0300 (EEST) Received: from smtp-fw-52003.amazon.com (smtp-fw-52003.amazon.com [52.119.213.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B58668C5D7 for ; Sat, 2 Sep 2023 12:20:15 +0300 (EEST) X-IronPort-AV: E=Sophos;i="6.02,222,1688428800"; d="scan'208";a="605725519" Thread-Topic: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-m6i4x-21d8d9f4.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-52003.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2023 09:20:13 +0000 Received: from EX19D005EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2a-m6i4x-21d8d9f4.us-west-2.amazon.com (Postfix) with ESMTPS id 0F602803F7; Sat, 2 Sep 2023 09:20:10 +0000 (UTC) Received: from EX19D025EUC003.ant.amazon.com (10.252.61.205) by EX19D005EUA002.ant.amazon.com (10.252.50.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Sat, 2 Sep 2023 09:20:08 +0000 Received: from EX19D025EUC002.ant.amazon.com (10.252.61.247) by EX19D025EUC003.ant.amazon.com (10.252.61.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Sat, 2 Sep 2023 09:20:08 +0000 Received: from EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087]) by EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087%3]) with mapi id 15.02.1118.037; Sat, 2 Sep 2023 09:20:08 +0000 To: "ffmpeg-devel@ffmpeg.org" , "stefasab@gmail.com" Thread-Index: AQHZ1zsnV59hqM/7gESV5Ye1dZUy/7AEe4mwgAAFcoCAAAIUgIAAKjeAgAKhlYA= Date: Sat, 2 Sep 2023 09:20:08 +0000 Message-ID: References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.212.48] Content-ID: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Carotti, Elias via ffmpeg-devel" Reply-To: FFmpeg development discussions and patches Cc: "Carotti, Elias" , "kierank@obe.tv" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > In particular why are you turning on fast_pskip silently based on a > > completely different setting? > > The patch is fixing the regression introduced by the unconditional > setting of b_fast_pskip. > > Now the question is if it makes sense to set mb_info without > b_fast_pskip (in both case this should be probably documented). > > @Elias can you comment about the mb_info/b_fast_pskip use case? Sorry again for the delay in responding. We can safely remove it altogether. It's true we don't need to set it along with mb_info. However, it doesn't do any harm, since fast_pskip is by default set to true by libx264 and only turned off either explicitly by the user, or when using the placebo preset, or when doing lossless encoding (constant QP == 0.) So, I agree, let's remove these three lines. Elias NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".