From: "Carotti, Elias via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>,
"stefasab@gmail.com" <stefasab@gmail.com>
Cc: "Carotti, Elias" <eliascrt@amazon.it>, "kierank@obe.tv" <kierank@obe.tv>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set
Date: Sat, 2 Sep 2023 09:20:08 +0000
Message-ID: <b12acdcfab44b2ac3d232cb847083c3a6c88d8a5.camel@amazon.it> (raw)
In-Reply-To: <ZPDJO7SnwEmwxbm/@mariano>
On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote:
>
<snip>
>
> > In particular why are you turning on fast_pskip silently based on a
> > completely different setting?
>
> The patch is fixing the regression introduced by the unconditional
> setting of b_fast_pskip.
>
> Now the question is if it makes sense to set mb_info without
> b_fast_pskip (in both case this should be probably documented).
>
> @Elias can you comment about the mb_info/b_fast_pskip use case?
Sorry again for the delay in responding.
We can safely remove it altogether. It's true we don't need to set it
along with mb_info.
However, it doesn't do any harm, since fast_pskip is by default set to
true by libx264 and only turned off either explicitly by the user, or
when using the placebo preset, or when doing lossless encoding
(constant QP == 0.)
So, I agree, let's remove these three lines.
Elias
NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-02 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 10:01 Stefano Sabatini
2023-08-31 14:12 ` Carotti, Elias via ffmpeg-devel
2023-08-31 14:30 ` Kieran Kunhya
2023-08-31 14:38 ` Kieran Kunhya
2023-08-31 17:09 ` Stefano Sabatini
2023-09-02 9:20 ` Carotti, Elias via ffmpeg-devel [this message]
2023-09-02 15:45 ` Stefano Sabatini
2023-09-05 12:43 ` Carotti, Elias via ffmpeg-devel
2023-09-05 23:07 ` Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b12acdcfab44b2ac3d232cb847083c3a6c88d8a5.camel@amazon.it \
--to=ffmpeg-devel@ffmpeg.org \
--cc=eliascrt@amazon.it \
--cc=kierank@obe.tv \
--cc=stefasab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git