Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/hls: relay programs to child muxers

From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/hls: relay programs to child muxers
Date: Thu, 16 Feb 2023 13:30:38 +0530
Message-ID: <b12842b9-c6ac-bac0-d309-fc02fd12bd56@gyani.pro> (raw)
In-Reply-To: <AS8P250MB07443EE65A1F297B4CC8914E8FA09@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On 2023-02-16 12:27 pm, Andreas Rheinhardt wrote:
> Gyan Doshi:
>> ---
>>   libavformat/hlsenc.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
>> index 39df9becc7..0b66efad3e 100644
>> --- a/libavformat/hlsenc.c
>> +++ b/libavformat/hlsenc.c
>> @@ -907,6 +907,12 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *vs)
>>           st->id = vs->streams[i]->id;
>>       }
>>   
>> +    for (i = 0; i < s->nb_programs; i++) {
>> +        ret = av_program_copy(oc, s, s->programs[i]->id, 0);
>> +        if (ret < 0)
>> +            av_log(s, AV_LOG_WARNING, "unable to transfer program %d to child muxer\n", s->programs[i]->id);
>> +    }
>> +
>>       vs->start_pos = 0;
>>       vs->new_start = 1;
>>   
> You intent to add this loop (including the error message) three times;
> once is enough.

Don't quite follow. You want me to break upon failure?

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".