From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6DDBC42A16 for ; Wed, 11 May 2022 19:15:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E97E068B44A; Wed, 11 May 2022 22:15:25 +0300 (EEST) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 361EA6800E0 for ; Wed, 11 May 2022 22:15:20 +0300 (EEST) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Kz4P13Q32z9swj for ; Wed, 11 May 2022 21:15:17 +0200 (CEST) Message-ID: Date: Thu, 12 May 2022 00:45:15 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220510114054.1745-1-ffmpeg@gyani.pro> <165227016292.13099.10758598518855468997@lain> <642f0f54-799f-dbc4-6724-99ef21895ee5@gyani.pro> <165229495558.13099.6133016962596120593@lain> From: Gyan Doshi In-Reply-To: <165229495558.13099.6133016962596120593@lain> X-Rspamd-Queue-Id: 4Kz4P13Q32z9swj Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-05-12 12:19 am, Anton Khirnov wrote: > Quoting Gyan Doshi (2022-05-11 14:18:49) >> >> On 2022-05-11 05:26 pm, Anton Khirnov wrote: >>> Quoting Gyan Doshi (2022-05-10 13:40:54) >>>> So far, -metadata:s:v rotate would only be applied to streamcopied >>>> video streams. >>> Using -metadata for this functionality is a hack that should be removed, >>> not extended. >> When there's a replacement for CLI users, sure. >> Till then, there's no need for the disparity to be maintained. > I disagree. You are adding new behavior, which will need to be > maintained for backward compatibility and add extra burden on the person > who would want to implement this properly. > > If you want this functionality, just add a new option. It's not that > hard. There's plenty of hacks in ffmpeg already, we don't need any new > ones. All the current state does is force the user to run a 2nd remux command to set rotation. A new option for encoded streams creates a divergent syntax for no visible benefit. If and when a display matrix can be user-specified, it will be easier to retire the metadata hack than to change the arg syntax of a newly added 'rotate' option. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".