From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA4B746D8D for ; Tue, 11 Jul 2023 01:15:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F45A68C5B4; Tue, 11 Jul 2023 04:15:08 +0300 (EEST) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2224068C30F for ; Tue, 11 Jul 2023 04:15:02 +0300 (EEST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-1b3ca17f2a6so4185631fac.0 for ; Mon, 10 Jul 2023 18:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689038100; x=1691630100; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rmS2vvfge7vmJvPFCn2UVw/VIIaiOsVSe5voZi6kwNg=; b=cCwlDyYMDHk00U3KpveSWaLQ+Zl1qRlqhU7i0unxtkeQK+zXPgGcaz/wia9+rojiOR qLtaX1rh0kvopeEyNnUXtIIRIJTvsJMyJutRUvxURGWa5+TUwRTljPsDSiuBPtDITCwX 7tYE0IJoaQeUnQMLPuu/Gjv1+GZpSUEeOFa9cRPi9SQ9sHNyNXVQMpEruvRyw4aL6IaA hd8T1MzpjO0h5BwYXKOb0bXqhgRyjPBxgK4WqVeHaM3vLZIOfx9Zy+2q33RgCzGI5l+z 8rVGrddM87pQOq3/H7bMUFmPC51VOwX2rvnC4oj2swj6DX5HYpsAu54lrcUcOyreSVZe WbEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689038100; x=1691630100; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rmS2vvfge7vmJvPFCn2UVw/VIIaiOsVSe5voZi6kwNg=; b=XYg1ZFlkliYxcpVUgwxcodf31FNKyXhShQzpdg9veAEIFo/+0YsceGCwSObK7KQef9 aa8BRADPenPUmEvRxZx3FMuqLoIketoUrtZX2jNMu0DG3z94V4X8A6K8q8LXtInHzrBW 7PExuk5JH1GMWPl7lEq8dWzWNnoDbEky4vDPYVn1FqRIPZ8Veo1H70e7PmlTyUq2nqSI NVrOu8ITno8qrxeFQMLpLQidt8VsOveeC2brk1+/OFlKN1D1uJHyCVv5Vkw0LisX16gu 3wSiiUa0oaN2Pv3MN5zVPqnQIma9JBwyT/9jAkq+Mc2uQZo9gAOif+uvKIUTzPPYSy+L nEGw== X-Gm-Message-State: ABy/qLb2aXlxOXCJNvJgH/juirFOzolHwCTUPORli/vybpQhmrOTy74j GR5n8NB439lpGtZy3mFDHodgSm8iTto= X-Google-Smtp-Source: APBJJlHaVbd2beeQO9iAKoJG8t/aM8+J4RIveXJ2lWgx+V1HcZziXZVqWosTPO5Gv9QzjZDiqSuN7A== X-Received: by 2002:a05:6870:a114:b0:19c:b5bc:e868 with SMTP id m20-20020a056870a11400b0019cb5bce868mr15196701oae.58.1689038100259; Mon, 10 Jul 2023 18:15:00 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id o1-20020a056870a50100b001b390c6e00bsm517020oal.56.2023.07.10.18.14.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 18:14:59 -0700 (PDT) Message-ID: Date: Mon, 10 Jul 2023 22:15:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote: > This allows to avoid exposing AVCodecInternal to files that > don't need it and only include internal.h for something else > (like the avpriv functions which are of course included outside > of libavcodec where AVCodecInternal should never be visible). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aacdec_template.c | 2 +- > libavcodec/amfenc.c | 2 +- > libavcodec/amfenc_av1.c | 2 +- > libavcodec/amfenc_h264.c | 2 +- > libavcodec/amfenc_hevc.c | 2 +- > libavcodec/aptxenc.c | 2 +- > libavcodec/audiotoolboxenc.c | 2 +- > libavcodec/av1dec.c | 2 +- > libavcodec/avcodec.c | 3 +- > libavcodec/avcodecinternal.h | 139 ++++++++++++++++++++++++++++++ I prefer avcodec_internal.h, to be in line with other similar internal headers from modules with a public one. That aside it LGTM if checkheaders passes. The more files include only what they need, the less likely to experience tree-wide recompilation for changing a single header. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".