From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own
Date: Mon, 10 Jul 2023 22:15:02 -0300
Message-ID: <b09889a3-8dd1-e5c9-08de-d0249a7cce81@gmail.com> (raw)
In-Reply-To: <GV1P250MB07375D3E989DC408630724448F31A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote:
> This allows to avoid exposing AVCodecInternal to files that
> don't need it and only include internal.h for something else
> (like the avpriv functions which are of course included outside
> of libavcodec where AVCodecInternal should never be visible).
>
> Signed-off-by: Andreas Rheinhardt<andreas.rheinhardt@outlook.com>
> ---
> libavcodec/aacdec_template.c | 2 +-
> libavcodec/amfenc.c | 2 +-
> libavcodec/amfenc_av1.c | 2 +-
> libavcodec/amfenc_h264.c | 2 +-
> libavcodec/amfenc_hevc.c | 2 +-
> libavcodec/aptxenc.c | 2 +-
> libavcodec/audiotoolboxenc.c | 2 +-
> libavcodec/av1dec.c | 2 +-
> libavcodec/avcodec.c | 3 +-
> libavcodec/avcodecinternal.h | 139 ++++++++++++++++++++++++++++++
I prefer avcodec_internal.h, to be in line with other similar internal
headers from modules with a public one.
That aside it LGTM if checkheaders passes. The more files include only
what they need, the less likely to experience tree-wide recompilation
for changing a single header.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-11 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 1:10 Andreas Rheinhardt
2023-07-11 1:15 ` James Almer [this message]
2023-07-11 1:26 ` Andreas Rheinhardt
2023-07-11 1:32 ` James Almer
2023-07-11 10:13 ` Anton Khirnov
2023-08-02 15:37 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09889a3-8dd1-e5c9-08de-d0249a7cce81@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git