From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4043446ACA for ; Sat, 2 Sep 2023 17:02:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B696568C778; Sat, 2 Sep 2023 20:02:55 +0300 (EEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 23F6368A05D for ; Sat, 2 Sep 2023 20:02:49 +0300 (EEST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-401da71b7c5so1011825e9.2 for ; Sat, 02 Sep 2023 10:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693674168; x=1694278968; darn=ffmpeg.org; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=2G5rdN5qc852uhuCmmRnLlh7j0zjrdXsrs/0+Yiqhfs=; b=nEGOTyRgY/ouwhEzKMTcvXTqD6Ks7loxtiOLuIizP3RZAjxeyqukhYRduJuJQKP1iO cajMn5Yhbe9wgmYF6InVHJLwnSXrBfHL0CMxAh4uGQqmU/Lwo3JoSqZaOS44qv1wku5P ibKBbSi9Cr97rtzM0lNywlR5zzg2BAvpmDAJawuIdodDr5IWBmUHL9TNHwB9hz4s0/BE xouhMJPRlxSj9eC8CaB7FZOCEA+30cumAMl8hy1RnOBvey4KvHNhG/+kdI/pPeGezp8M cePSpoEAsVZo18qJzBE9WoMa/ODaicdnKhf0YWlDS1OpAT/x+pVRKfQj5QvADhLymQ7y 09Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693674168; x=1694278968; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2G5rdN5qc852uhuCmmRnLlh7j0zjrdXsrs/0+Yiqhfs=; b=jI5nIPyjI8M57cwRFEASXqrmKmjhx7817NR/w3H0JcpPQvQc5oWFXizZZ3xXZWYjjI dgm+ZXN9aQm57/vyf9FkkDmwZI8PqhCaiB6n4ac3v98uKKVXjpunCz+5SO7fgPx3ZElS rIiHt2KIb7HLBK8ZYTRsofzECRrVQiz4h4FmF0sY0bfS2Th/T9sKM2n52XCcOJp5iZLO 34m5Wz2xJg0Fw4eI3sCAJ77ytkMVe8kOMBO1SPJNf2a8SGyNS8dE81Epc6Q5UdvvMUrv yBsYrny5RXtH5iegDjJhcjyI5xVYRqcukvBmS63oirSkKyiTump6EdNx3+KQOmxDt19E xbcg== X-Gm-Message-State: AOJu0Yy/ksbdx5jkP9DZHp9wSL9MU+m7uQgxQ/OGljYRUrt6+Z+2yJQf TnMqXtcj4fcG7uaM20+PF4XaUWOp9rKteg== X-Google-Smtp-Source: AGHT+IFZlasbPqIagbgGL+cbXTvXJKps7eNwucBFlM9WqVADkwYV98ce79KK6Qmxmw2KEZbWNg1Bjw== X-Received: by 2002:a05:600c:b58:b0:401:aa8f:7570 with SMTP id k24-20020a05600c0b5800b00401aa8f7570mr3854194wmr.1.1693674168425; Sat, 02 Sep 2023 10:02:48 -0700 (PDT) Received: from [192.168.3.218] ([151.48.239.185]) by smtp.gmail.com with ESMTPSA id x15-20020a1c7c0f000000b003feef82bbefsm8396885wmc.29.2023.09.02.10.02.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Sep 2023 10:02:48 -0700 (PDT) Message-ID: Date: Sat, 2 Sep 2023 19:02:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Alessandro Ros To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In order to send VP9 tracks with RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs currently returns invalid boxes, that are lacking the Version and Flag fields, inherited from FullBox. For some reason, both flags were being added manually in movenc. This patch fixes the issue. Signed-off-by: Alessandro Ros --- libavformat/movenc.c | 3 --- libavformat/vpcc.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7ef6cef46a..696ae5a6c9 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *tra avio_wb32(pb, 0); ffio_wfourcc(pb, "vpcC"); - avio_w8(pb, 1); /* version */ - avio_wb24(pb, 0); /* flags */ ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, track->par); - return update_size(pb, pos); } diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c index ea66959abf..256407dd6d 100644 --- a/libavformat/vpcc.c +++ b/libavformat/vpcc.c @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, AVIOContext *pb, if (ret < 0) return ret; + avio_w8(pb, 1); /* version */ + avio_wb24(pb, 0); /* flags */ avio_w8(pb, vpcc.profile); avio_w8(pb, vpcc.level); avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1) | vpcc.full_range_flag); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".