Re: [FFmpeg-devel] [PATCH] SDL2 verison for pkg_config fallback

[Marton Balint <cus@passwd.hu>]

On Sun, 19 Jun 2022, Martin Storsjö wrote:

> On Mon, 20 Jun 2022, dvhh wrote:
>
>>  On Sun, 19 Jun 2022 17:46:58 +0200
>>  Timo Rothenpieler <timo@rothenpieler.org> wrote:
>>
>>>  On 17.06.2022 18:46, dvhh wrote:
>>>>  pkg_config fallback for SDL2 use 2.1.0 as max (excluded) version
>>>>  where the pkg_config specify 3.0.0
>>>>  Correcting fallback version to be in line with the pkg_config version
>>>
>>>  Why? Any version the new versioning scheme will have a pkg-config file.
>>
>>  I am cross-compiling for Windows aarch64 and noticed the discrepancy,
>>  pkg_config does not appear to be an option in that case.
>>
>>  this is what I got from the log:
>>  -------------------
>>  test_pkg_config sdl2 sdl2 >= 2.0.1 sdl2 < 3.0.0 SDL_events.h SDL_PollEvent
>>  false --exists --print-errors sdl2 >= 2.0.1 sdl2 < 3.0.0
>>  -------------------
>
> Instead of an aarch64-w64-mingw32-pkg-config, you can configure with 
> --pkg-config=pkg-config, and set PKG_CONFIG_LIBDIR=<your/lib/pkgconfig>.
>
> That said, this patch seems like a consistent followup to 
> e5163b1d34381a3319214a902ef1df923dd2eeba - so either we apply this, or decide 
> to scrap the non-pkgconfig fallback for this library. (Applying this patch in 
> the meantime probably doesn't hurt, while deciding on whether pkg-config can 
> be required here.)

Agreed, will apply the patch for now.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".