From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/riffdec: add ch_layout used av_channel_layout_default.
Date: Wed, 8 May 2024 23:30:26 -0300
Message-ID: <b02b9ed4-56f5-4548-98a8-4071ba51398f@gmail.com> (raw)
In-Reply-To: <20240509022818.132382-1-hiccupzhu@gmail.com>
On 5/8/2024 11:28 PM, shiqizhu wrote:
> Signed-off-by: shiqizhu <hiccupzhu@gmail.com>
> ---
> libavformat/riffdec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c
> index b7a85a6ab2..89267e879d 100644
> --- a/libavformat/riffdec.c
> +++ b/libavformat/riffdec.c
> @@ -197,8 +197,7 @@ int ff_get_wav_header(void *logctx, AVIOContext *pb,
> /* ignore WAVEFORMATEXTENSIBLE layout if different from channel count */
> if (channels != par->ch_layout.nb_channels) {
> av_channel_layout_uninit(&par->ch_layout);
> - par->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> - par->ch_layout.nb_channels = channels;
> + av_channel_layout_default(&par->ch_layout, channels);
No, guessing is left to the caller. lavf should export what's signaled
in the file.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-09 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 2:28 shiqizhu
2024-05-09 2:30 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b02b9ed4-56f5-4548-98a8-4071ba51398f@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git