From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EF49844B52 for ; Sun, 18 May 2025 19:24:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9368068DAEC; Sun, 18 May 2025 22:24:26 +0300 (EEST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8563968D761 for ; Sun, 18 May 2025 22:24:19 +0300 (EEST) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-550ef1da73dso2273498e87.0 for ; Sun, 18 May 2025 12:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1747596258; x=1748201058; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=x8zOgn0iZBCQOR1R8/c+rzY1r8jjRIkx+4awYbulzFg=; b=oLbJVY4/E9XTl9HuWxxWUs8tX4OPaPMcwBi/g+5HPrkmpAvMEQn2xOxqChyuch4FG8 ayBgNVHBmL5xo1Qiaq+Orkur7dEsRwP9DVhbDb0jZH5mMNAEK83CCSBALMmWqL/ga74X 7ceXJR8ocLrhyAr56Mqp8FZo2OEiy6EM5IuXcoHmI0ypWuUJEhewgmVME9Uol9Gvyscr ODHmsN7Rv7Q6OBAnEwNWnqO7wCYKCdq5CcrQ1NNSVEAwipD2VbvfN0Lpr3RojmlzJ8tR W7aDVrH63cMAGs3+g+ic1O7YvsU8nhkImzT7zl8UVc66+jkGHtgFMsVQPEFO0TIgNu63 WY+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747596258; x=1748201058; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x8zOgn0iZBCQOR1R8/c+rzY1r8jjRIkx+4awYbulzFg=; b=cUr9f7MFAH0fWDb3aGRVxrUP7ZsFiZleix3ZefV9WbcbjzFx+atFAFmTAqfu/4libX I1kMxJkv2AT5Igg7EUjNyK5eMVlJ9OYr0vtfESkqK/z2l7RRQTxuyTTOU3oJrwRTOsec BuSbe8N4lqHATGAeS2LHSmy5MiaISJ3IeeDVHFWe+HBXgtal5kiB+G5WpB0PhZN4poBa XbrbKTMu6FsvdScMu7Sqao9iOmhJss4aiti+8nyLLDc9nU7WCh+62UgKFSfKMBDLKcoC e02qxqbBC3DbAwnd7wlp9T6yNYqE30XwXuUT7hODMHaM7z2fnjaH2jUXSLD8Ob6QIEGn 6fQg== X-Gm-Message-State: AOJu0YxfOaz5hXPnSggbc4S5OP7AdZZl0sHYHBhPyXxr9BjQ8LKiGQ+i dh/y+U0d7uvLL415/X2Ia/kG0NVvEXJcoh3j13lNmLQFN5jQDU6FzVrnxWsQoshLU8SYyw/vTB2 HETEVpw== X-Gm-Gg: ASbGncs/wXgYJKpw0rh6TfM5evoQnVLa9U0js0bjsQVzgJxiaK3cNmwaVyCGnne3hvq AkXyrgRcyhhl6KIBsv6YiEiMS2qNDjh9KVEF5q8AUfJntSA/VBHIaavpgIyugXFgxqpPmYF+dLg zSkvT9EE/eN3j6NvuP+TBz4vWmxgRMcOFOpx+wFgsxYs36QzxznuAOfRn9lTJeUfD+9tVNA+sb/ ErUSHkk6BctffeiwDeOxvi91wjap6rtrm1zOKIckosddr+o9yD1pHcwUzf9UhsBWCkVD0JYF2+M /JC0bu79CQmDYKP1rOKbEZwPONsdKP8fNhl8kNfwrzRO1RLzIk51o5PjBoFu6rKaL9iFyApRw1Y 9W1cipiUSqQjhYrj1ngNDOP99F1BkMxen97AaGco3uyEqCUg= X-Google-Smtp-Source: AGHT+IF2T2b351g9xr939niqtbVnVDCyaOu6KyTKsh0AQUBk6Lv00jCcj+SnghhCvbS97sq/tjyGuQ== X-Received: by 2002:a05:6512:428b:b0:54f:c505:5c66 with SMTP id 2adb3069b0e04-550e97d2a5emr2006462e87.29.1747596258322; Sun, 18 May 2025 12:24:18 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e702a294sm1509328e87.159.2025.05.18.12.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 May 2025 12:24:17 -0700 (PDT) Date: Sun, 18 May 2025 22:24:16 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250518145953.234284-4-ffmpeg@haasn.xyz> Message-ID: References: <20250518145953.234284-1-ffmpeg@haasn.xyz> <20250518145953.234284-4-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 04/17] tests/checkasm: add checkasm_check_float X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 18 May 2025, Niklas Haas wrote: > From: Niklas Haas > > --- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 71d1e5766c..c77216ed57 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -1265,3 +1265,4 @@ DEF_CHECKASM_CHECK_FUNC(uint16_t, "%04x") > DEF_CHECKASM_CHECK_FUNC(uint32_t, "%08x") > DEF_CHECKASM_CHECK_FUNC(int16_t, "%6d") > DEF_CHECKASM_CHECK_FUNC(int32_t, "%9d") > +DEF_CHECKASM_CHECK_FUNC(float, "%g") > diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h > index ad7ed10613..f1046bc035 100644 > --- a/tests/checkasm/checkasm.h > +++ b/tests/checkasm/checkasm.h > @@ -422,6 +422,7 @@ DECL_CHECKASM_CHECK_FUNC(uint16_t); > DECL_CHECKASM_CHECK_FUNC(uint32_t); > DECL_CHECKASM_CHECK_FUNC(int16_t); > DECL_CHECKASM_CHECK_FUNC(int32_t); > +DECL_CHECKASM_CHECK_FUNC(float); > > #define PASTE(a,b) a ## b > #define CONCAT(a,b) PASTE(a,b) > -- > 2.49.0 While this change in itself is ok, this uses memcmp for the check function, which usually isn't ideal for float based tests; making the tests use some given epsilon instead probably is better in general. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".