From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6AF9A45551 for ; Mon, 6 Mar 2023 02:53:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1290268B9CA; Mon, 6 Mar 2023 04:53:17 +0200 (EET) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 517CE68A4DB for ; Mon, 6 Mar 2023 04:53:10 +0200 (EET) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-17235c8dab9so9958699fac.7 for ; Sun, 05 Mar 2023 18:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DZJUXIymTfLfFLTa/dDVfOGCs8ykW0Nx6qkXw/b2vM0=; b=FB/K64KdmpzKcR15gFFu+/Nr8uLO55k6vItficJueYN06Ut+wAR8q9phHFxYVXNmjW hMzWcCiO7sObLoAjJmvbK3OizPuhMKTQvlXzzLfuhPl1HKCLYq1UTbyZXUsnvTTzDTPL NwD7c9yf4AxA//JCVqeBgOC2gqKCbPrL7uoEsWyXYkju18n4QxfDjNcAPJ1pQZbU4k0a HYjbYe64krOzvhcZcym/gk5x92adc6RdxftQkBL8dOP4CHwoa0ViXbwrctubzJ8FIknk 7kWw4shggf27FQL62jn3mKBrHUVNNH3ElzFXObMp8znaXAdLL8S8oEvbYHWUn9mcCbre iVfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DZJUXIymTfLfFLTa/dDVfOGCs8ykW0Nx6qkXw/b2vM0=; b=uUmVtINKJCKCRKB35llO4jT+niWmGCFYMQ+FNvLYmBb4I38d9GPbADjCknFYM+7kCc leozM/SdL5zGVMYtQCvyJf5FPMjIGNBhWHaJ2mVzEOdBKIql8ATkjKWYd2OM/3r2wnVF sfgyDRuVAKJRxyv0lVq/4fWfH2QGHlpEYs+mgsUWDX8cIs7NFpjP2ZxKdsdQ505rayxk Nb3QRqr5aNfDIGD+r/Bte1PJZyWhdr03XYAv7ue034Ww4zcjlEIaR71uPOUlSIsdJVPg fQs+1Ayqd4dn51VdM4HqBbp8ivH+mm3WTVowybH7jv1ELLYOjSBtMN9JnWkJZnW9iccm daFg== X-Gm-Message-State: AO0yUKVh45iYAhD7bKCe7HVZKP68r2lUaZ+ymcay+qeQRWkJVKz/xWHu DHPbHHN4Xrd9zRR0T4iMrR5K6eUpUaM= X-Google-Smtp-Source: AK7set+UgfcDbINFa64BvHjJ3wqUct0GvBVO94dGhdoKN6pCZsNQpi9iU/3CJPXhptwtRbZ1P37h6A== X-Received: by 2002:a05:6870:b251:b0:172:55c7:9b9c with SMTP id b17-20020a056870b25100b0017255c79b9cmr6240354oam.9.1678071188461; Sun, 05 Mar 2023 18:53:08 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id q17-20020a4ad551000000b0049fd5c02d25sm3390949oos.12.2023.03.05.18.53.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 18:53:08 -0800 (PST) Message-ID: Date: Sun, 5 Mar 2023 23:53:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230306023819.1014-1-zhujunxian@oss.cipunited.com> From: James Almer In-Reply-To: <20230306023819.1014-1-zhujunxian@oss.cipunited.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/mathops: Optimize generic mid_pred function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/5/2023 11:38 PM, Junxian Zhu wrote: > From: Junxian Zhu > > Rewrite mid_pred function in generic mathops.h, reduce branch jump to improve performance. And because nowadays new version compiler can compile enough short asmbbely code as handwritting in these function, so remove specified optimized mips inline asmbbely mathops.h. > > Signed-off-by: Junxian Zhu > --- > libavcodec/mathops.h | 20 ++++-------- > libavcodec/mips/mathops.h | 67 --------------------------------------- > 2 files changed, 6 insertions(+), 81 deletions(-) > delete mode 100644 libavcodec/mips/mathops.h > > diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h > index c89054d6ed..526ffe0eec 100644 > --- a/libavcodec/mathops.h > +++ b/libavcodec/mathops.h > @@ -41,8 +41,6 @@ extern const uint8_t ff_zigzag_scan[16+1]; > # include "arm/mathops.h" > #elif ARCH_AVR32 > # include "avr32/mathops.h" > -#elif ARCH_MIPS > -# include "mips/mathops.h" > #elif ARCH_PPC > # include "ppc/mathops.h" > #elif ARCH_X86 > @@ -98,18 +96,12 @@ static av_always_inline unsigned UMULH(unsigned a, unsigned b){ > #define mid_pred mid_pred > static inline av_const int mid_pred(int a, int b, int c) > { > - if(a>b){ > - if(c>b){ > - if(c>a) b=a; > - else b=c; > - } > - }else{ > - if(b>c){ > - if(c>a) b=c; > - else b=a; > - } > - } > - return b; > + int t0,t1,t2,t3; > + t0 = (a > b) ? b : a ; > + t1 = (a > b) ? a : b ; > + t2 = (t0 > c) ? t0 : c; > + t3 = (t1 > t2) ? t2 : t1; > + return t3; int t0 = FFMIN(a, b); int t1 = FFMAX(a, b); int t2 = FFMAX(t0, c); return FFMIN(t1, t2); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".