Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter
Date: Mon, 1 Aug 2022 15:56:00 +0300 (EEST)
Message-ID: <af498a31-4c69-1185-1b6e-8a0ade11988@martin.st> (raw)
In-Reply-To: <CA+anqdwzSFL8YyLbmCOLdDmjx2+TdOXadtqt8vV6EdVRCcHn9g@mail.gmail.com>

On Mon, 1 Aug 2022, Hendrik Leppkes wrote:

> On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö <martin@martin.st> wrote:
>>
>> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API
>> subsets other than "desktop", while the IDXGIOutput1 interface is
>> available for all API subsets.
>>
>> This fixes compilation for UWP/"Windows Store" configurations (and
>> older API subsets like Windows Phone).
>
> The entire desktop duplication API is not present on Phone targets
> (its called "desktop" duplication afterall). I think it would be
> better to check for a primary DDA function, instead of some auxiliary
> structure.

FWIW, based on the MSVC error output 
(http://fate.ffmpeg.org/log.cgi?log=compile&slot=arm-msvc2019-phone&time=20220730152801), 
the only hard errors it listed were the undefined types 
(DXGI_OUTDUPL_POINTER_SHAPE_INFO and DXGI_OUTDUPL_FRAME_INFO) - but I 
presume that IDXGIOutputDuplication_AcquireNextFrame and 
IDXGIOutputDuplication_ReleaseFrame could be good candidates for checking 
too - I don't see anything else in that error log that one could check 
for?

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-08-01 12:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 12:35 Martin Storsjö
2022-08-01 12:36 ` Timo Rothenpieler
2022-08-01 12:48 ` Hendrik Leppkes
2022-08-01 12:56   ` Martin Storsjö [this message]
2022-08-01 13:49     ` Hendrik Leppkes
2022-08-01 13:52       ` Timo Rothenpieler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af498a31-4c69-1185-1b6e-8a0ade11988@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git