From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9166A47DF2 for ; Mon, 27 Nov 2023 13:09:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5FC5E68CDF9; Mon, 27 Nov 2023 15:09:18 +0200 (EET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2931A68CB76 for ; Mon, 27 Nov 2023 15:09:12 +0200 (EET) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40b399a6529so16383855e9.1 for ; Mon, 27 Nov 2023 05:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1701090551; x=1701695351; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0pPKW5uli5hM41Gn7yXpaLKJ0rgnFej1nOHNYADRZVs=; b=IDxXIGayAKhzk6VJq/mIhNl3KQFHEFJ2CqZhMzBrZrd5f/LGNuKRGD6OFtQ2DOHqM5 yWEbYsAHA4I+5I2ORxnIN0Eo8hyE+Xc37+q3FYI654WsiMsdicb904SOP9qg3Nuehlcq WyGSJgQ7BTBdt5r92ruXcML6TLfeJF8QSkPHGRfFd52J00DZYjADPEYK9BQxuRY4TPBe 0UiLQGl9FG7f5lIcUFYWzZgeI6M14Dx0mpKFbskw1efi7rUi42tYtKTYk/HnUMTubGMi xpJBZJrQmB5NlphVD7WIZhpCgiPSJls/XH+n1i7S55rTX0e4ESNGPGntVk5k9MOQ9iji xY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701090551; x=1701695351; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0pPKW5uli5hM41Gn7yXpaLKJ0rgnFej1nOHNYADRZVs=; b=XNQ8mCeYet7D1cz+vyGSXEHcXf9v5D0OWUslb0rURf1gKWcBz0pZMV6e0EmCiTkxoN 73NDeAadTd+0G+kFGbw/cDigtcQmSaD0655U4Lfz4jGRwgCjhPaI3XHsfG5JaNECcEH6 B05VidhxCwIY9hNnngjav4iuq6ZDWnMBhuCFHmW5s7URiKqUwV7L5bfOqZjSMCgoXBW/ 4num1Wkbuj9272bj4o2fctPYd2+rR6GwB1A7VJ22I0rvgeO+o3b+Z/zA10GYk6RC7eoo QpDswKr/cn0yTovHVdCZxxpZpVQoEFr6/84gTWxoKFNCIoAYspEm5qvRtr6RLPFT/XIA AUzQ== X-Gm-Message-State: AOJu0YyvkuF/ROyHu9/t9hoaGrOpuwhSlDTgmpozbiAwHRinJWUbleVm vdRepY6GQ5T/qN0NRCWAnmGMrhCoxsI+/nQM+As= X-Google-Smtp-Source: AGHT+IGixacTENr/46qOpgRcgcAEd2o2zkJdX9Y/8dMbhApZHHi+m3KWpXAFYFPOA+RjwTb3EUj5ig== X-Received: by 2002:adf:ff92:0:b0:332:eacf:c9d7 with SMTP id j18-20020adfff92000000b00332eacfc9d7mr8743544wrr.8.1701090551165; Mon, 27 Nov 2023 05:09:11 -0800 (PST) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust383.5-4.cable.virginm.net. [82.13.65.128]) by smtp.gmail.com with ESMTPSA id n8-20020a5d67c8000000b00332e84210c2sm9832199wrw.88.2023.11.27.05.09.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 05:09:11 -0800 (PST) Message-ID: Date: Mon, 27 Nov 2023 13:09:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231123094246.14268-2-lucenticus@gmail.com> Content-Language: en-US From: Mark Thompson In-Reply-To: <20231123094246.14268-2-lucenticus@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23/11/2023 09:41, Evgeny Pavlov wrote: > This commit adds option for enabling SmartAccess Video (SAV) > in AMF encoders. SAV is an AMD hardware-specific feature which > enables the parallelization of encode and decode streams across > multiple Video Codec Engine (VCN) hardware instances. > > Signed-off-by: Evgeny Pavlov > --- > libavcodec/amfenc.h | 1 + > libavcodec/amfenc_av1.c | 18 ++++++++++++++++++ > libavcodec/amfenc_h264.c | 18 ++++++++++++++++++ > libavcodec/amfenc_hevc.c | 18 ++++++++++++++++++ > 4 files changed, 55 insertions(+) Can you explain a bit more about what this option actually does? I can't find any details about it beyond nebulous "make things better", but presumably there is some tradeoff so you don't always enable it. Some documentation explaining what it does and hinting when the user might want it on or off would be helpful (can be a separate patch). Patch itself seems fine for a standalone option, though I would mildly prefer not to put meaningless marketing names in the code if it's possible to have a descriptive name instead. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".