From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option
Date: Mon, 27 Nov 2023 13:09:30 +0000
Message-ID: <af3b2415-b0ab-4bd7-9711-1807f48aeaa2@jkqxz.net> (raw)
In-Reply-To: <20231123094246.14268-2-lucenticus@gmail.com>
On 23/11/2023 09:41, Evgeny Pavlov wrote:
> This commit adds option for enabling SmartAccess Video (SAV)
> in AMF encoders. SAV is an AMD hardware-specific feature which
> enables the parallelization of encode and decode streams across
> multiple Video Codec Engine (VCN) hardware instances.
>
> Signed-off-by: Evgeny Pavlov <lucenticus@gmail.com>
> ---
> libavcodec/amfenc.h | 1 +
> libavcodec/amfenc_av1.c | 18 ++++++++++++++++++
> libavcodec/amfenc_h264.c | 18 ++++++++++++++++++
> libavcodec/amfenc_hevc.c | 18 ++++++++++++++++++
> 4 files changed, 55 insertions(+)
Can you explain a bit more about what this option actually does? I can't find any details about it beyond nebulous "make things better", but presumably there is some tradeoff so you don't always enable it.
Some documentation explaining what it does and hinting when the user might want it on or off would be helpful (can be a separate patch).
Patch itself seems fine for a standalone option, though I would mildly prefer not to put meaningless marketing names in the code if it's possible to have a descriptive name instead.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-27 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:41 Evgeny Pavlov
2023-11-24 8:45 ` Dmitrii Ovchinnikov
2023-11-26 10:32 ` Anton Khirnov
2023-11-26 14:40 ` Dmitrii Ovchinnikov
2023-11-27 13:14 ` Mark Thompson
2023-11-28 14:18 ` Evgeny Pavlov
2023-11-27 13:09 ` Mark Thompson [this message]
2023-11-28 13:52 ` [FFmpeg-devel] [PATCH v3] " Evgeny Pavlov
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 16:17 [FFmpeg-devel] [PATCH] libavcodec/amfenc: " Evgeny Pavlov
2023-07-24 11:15 ` [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: " Evgeny Pavlov
2023-11-20 15:57 ` Evgeny Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af3b2415-b0ab-4bd7-9711-1807f48aeaa2@jkqxz.net \
--to=sw@jkqxz.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git