From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8FA74B1DD for ; Wed, 31 Jul 2024 22:03:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 57DAA68D8BC; Thu, 1 Aug 2024 01:03:30 +0300 (EEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3782868D87E for ; Thu, 1 Aug 2024 01:03:24 +0300 (EEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1ff3d5c6e9eso18454415ad.1 for ; Wed, 31 Jul 2024 15:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722463402; x=1723068202; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=mk7f6fJ2O0OTVksglH0E5vxPv7og6/oZn973/pr3azM=; b=LJCOsoKmJUBKlTfoAnU34jFLTsZm2vKYhBlxFs3sJNgdl3sZ5IGV6oK45TKAGg/QmY YsrQvi7uwFzQclaimVfBwofNdJbpzs64wItURk0oypV5EHCySdQ+95I0EoCMRTtfTsP3 ItPnejrs0f/d4XlMlGDQvz5hO83BPS3LI9/oTr8VcQMaxRW/d/Gi1+esiHVFe9EhTYNG SpMYV25Pkk0yzu+czQsYR8sISZLv+fV6zcjJUSkWHkfHCIzyXWq16TNhUcuEXdLMty+I MhyvBVA5UfVQ9/CPQkfuol4S4YrEJpbekTHR7tMUedXkD5fO1ftPlN9cVrLfYwjZlx/f Vwbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722463402; x=1723068202; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mk7f6fJ2O0OTVksglH0E5vxPv7og6/oZn973/pr3azM=; b=LudQKA4tEsMN5DLcgBMvJRmClB+K2YbPZqqAUrjy2JUDWHQOTxJCW3j+S5iIfXmkkC 1QNfI+xrO9tWvrgxnAKIBj6a+kzW+zGawRrp2cAI+WyccT9y1eVJ+YIncNXnLZkeX1wU YwnbiMtByEUHWnJAFm/eNPYH4PI3HTQpPuEVv8MMmjHt75BPLLU0UwczpdPqDTjwf5en DE65XlCN/cWwGfHbwhFF7dR79ygQkaMcwcvXKZp0RrrF/mhx608OpTjQJ/nU8xkVtEWc TBdbyv/AOqGkS1dkf4HKbUOpjUU83Acd7FdzGHPYIYCRE1lVpxFYIlNcUQYIwouB8c0C Xejw== X-Gm-Message-State: AOJu0YyqAnYdPrPLW0rzTp+noxFUkstIinAphk4ohN8AJ9yQVYEcgJc9 VcKPavwO1Xej8X9MNC0SbbVyDliDHWVIUxyQEJEFlK/VXQRWS0n6KJbBzg== X-Google-Smtp-Source: AGHT+IFYAXi0xxOuDhKyJTQOiXCW+rN3uy4I/QLXRVdTgOx7hCgyDSxTxBr4xwfrWC+CWnS0VRKmIA== X-Received: by 2002:a17:902:c945:b0:1fb:81ec:26da with SMTP id d9443c01a7336-1ff4d270345mr7867405ad.58.1722463402000; Wed, 31 Jul 2024 15:03:22 -0700 (PDT) Received: from [192.168.0.12] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7cb0370sm125059685ad.65.2024.07.31.15.03.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 15:03:21 -0700 (PDT) Message-ID: Date: Wed, 31 Jul 2024 19:04:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240731195410.274508-1-michael@niedermayer.cc> <20240731195410.274508-3-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240731195410.274508-3-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 3/6] avformat/iamf_parse: Check for 0 samples X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/31/2024 4:54 PM, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: 70561/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6199435013455872 > Fixes: 70565/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5783790316748800 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/iamf_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c > index cdfd5f75fef..e007d6a7af2 100644 > --- a/libavformat/iamf_parse.c > +++ b/libavformat/iamf_parse.c > @@ -252,7 +252,7 @@ static int codec_config_obu(void *s, IAMFContext *c, AVIOContext *pb, int len) > if (ret < 0) > goto fail; > > - if ((codec_config->nb_samples > INT_MAX) || > + if ((codec_config->nb_samples > INT_MAX) || codec_config->nb_samples <= 0 || > (-codec_config->audio_roll_distance > INT_MAX / codec_config->nb_samples)) { > ret = AVERROR_INVALIDDATA; > goto fail; LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".