From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 7B04141D44
	for <ffmpegdev@gitmailbox.com>; Sun, 24 Apr 2022 22:48:09 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 103DB68B26B;
	Mon, 25 Apr 2022 01:48:06 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AA8E468AEF0
 for <ffmpeg-devel@ffmpeg.org>; Mon, 25 Apr 2022 01:48:03 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id BC1F32CA5B5
 for <ffmpeg-devel@ffmpeg.org>; Mon, 25 Apr 2022 00:48:02 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1650840482;
 bh=73vFwEDzeHs/kdRvl5nDRQliataLQQH2aTT33fQmcA0=;
 h=Date:Subject:To:References:From:In-Reply-To;
 b=HVMiyh9V8yNW/+zlHF7bk1ocYD/ZXHxEkoLLQgtbi/7z22mHGE3CcHO2S62/zIM2+
 pcPGBGa1lqfPt39QwVOEMPgBqqFSKwHXztCgli7pvgKfxgBavyB7jUktoi+H6W5y1j
 t28Sk7stc7FCtrAz+9BD+uqfZlOXhCayUpxt+jfwtJZ9zuGI9+vUscQF/P320lwtim
 uYohQwUMB7e6CAUv88CqOMkPrfjxcSxufOz2bC0y00oU7b9UJMfwMRHeu7Mm6eitA6
 nK/l7JqZvFv/8PM9ILXHwjWYBT7Y71slA9JlHl/WWM2hINEtq0y56ZZlVcF6So7klb
 MxNduTJABF1sg==
Message-ID: <ae567d1e-5c73-9371-843a-be26f323bac6@rothenpieler.org>
Date: Mon, 25 Apr 2022 00:48:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220423233208.27071-1-timo@rothenpieler.org>
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <20220423233208.27071-1-timo@rothenpieler.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavf/tls_mbedtls: add support for
 mbedtls version 3
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ae567d1e-5c73-9371-843a-be26f323bac6@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 24.04.2022 01:32, Timo Rothenpieler wrote:
> - certs.h is gone. Only contains test data, and was not used at all.
> - config.h is renamed. Was seemingly not used, so can be removed.
> - MBEDTLS_ERR_SSL_NO_USABLE_CIPHERSUITE is gone, instead
>    MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE will be thrown.
> - mbedtls_pk_parse_keyfile now needs to be passed a properly seeded
>    RNG. Hence, move the call to after RNG seeding.
> 

I'd really like some review on this, and merge it rather sooner than later.

Also, I think this should be backported to all currently maintained 
branches, since mbedtls<3 is no longer maintained, so lack of support 
for recent versions is a potential security issue.

Would hate to just push it without review, even though it looks trivial 
enough to me, it is touching TLS code.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".