From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CFEAC42284 for ; Tue, 1 Mar 2022 13:43:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64C4C68B209; Tue, 1 Mar 2022 15:43:22 +0200 (EET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6EC9E68B0D5 for ; Tue, 1 Mar 2022 15:43:16 +0200 (EET) Received: by mail-ot1-f48.google.com with SMTP id j9-20020a9d7d89000000b005ad5525ba09so12169735otn.10 for ; Tue, 01 Mar 2022 05:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=Ias0+840VsW2rxCmj2Wgkx/QPG9qymXwpZc3U0WsUHw=; b=IHtrf+ttIQtIRRXZL/O0EEoeD4oy9xOQwcQmD9qrh6OgRRlBeLKnhmKIJKva5yANcE 75MXxosT2uZ6FyQ/mzqqd9IlTK+T6npDFeaZy2K5DaZKgopje7bz7unKMpBWoGxzlAx1 MThKW2nNtjZDmbt7vuCMUiWPJpYyxbK/ChXWuCmT5bBbA2SrUJEn3cxX5hXiarzFJQ9z X0/TjTYJLDGjAKZQHo8h5XcsDwSxf+zhAq1iTfymcBp3+G4HJZmzb6/x7PDtcFJ72qbO beNfaWZ+0ms2wQVG/54oLy8FrDdf5am+h/tfGBvNSr7wpl7xjy+8Y95H/8AxDn7115Db 5Tpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=Ias0+840VsW2rxCmj2Wgkx/QPG9qymXwpZc3U0WsUHw=; b=dS6/AtQUl4lRPhItgSwG8XKgdoYpLj8YraTw/p3MmlNS8tMWM3NfuEMSSqMPORzUD8 3WVlsJHDgvauTNQ/wZmKFx6na7XaX5+G+bFVBlhTNV6roYseB3XNG9JGZMw7b9QDtNKh Kbc1J9jI28gHDpQxN4EQZMb3SWqCD9DHQwQkS8BxfTwkHEgKszmU/UI0/b3E9MYsgypz KBDc1IKxjmDsvjByyX/I474jb0Obc41yyQ2v/2dbmWGDbJCTLBXHUM9UMDjBcG8h36wI JbaedD1XtoSlt+ALpaU3wR5SDu3sE+Lgv6r0y3Frs6t6NGABI5i+L1S32xMx4/uYLfBF rSug== X-Gm-Message-State: AOAM533C8B4zP7OPMVwIBJFlgQ3b3+C7emBZm1vdFBM8cikxLRThIW48 bHuvp+YJZFz9EfbBL332d0UCeEQwxRqGsA== X-Google-Smtp-Source: ABdhPJzUIKIw6jfMYiCbYhzKWaQPuh7uf9fEyR1ZCHV8y1GvsoAXJax2+xBVbl6p0jNFaRf5iEtBqg== X-Received: by 2002:a05:6830:1394:b0:5af:6776:ea37 with SMTP id d20-20020a056830139400b005af6776ea37mr12066210otq.80.1646142194606; Tue, 01 Mar 2022 05:43:14 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id 68-20020a9d0a4a000000b005ad3287033csm6668112otg.44.2022.03.01.05.43.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 05:43:13 -0800 (PST) Message-ID: Date: Tue, 1 Mar 2022 10:43:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220221122715.424475-1-onemda@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/1/2022 4:12 AM, Xiang, Haihao wrote: > Hi, > > fate-vsynth1-mpeg2-422 is broken after this patch (commit 17a59a6). > > --- ./tests/ref/vsynth/vsynth1-mpeg2-422 2021-11-22 12:59:25.013517219 +0800 > +++ tests/data/fate/vsynth1-mpeg2-422 2022-03-01 13:30:48.446378312 +0800 > @@ -1,4 +1,4 @@ > -6e135a1a27235a320311a932147846b4 *tests/data/fate/vsynth1-mpeg2-422.mpeg2video > -730780 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > -0273cd8463d1fc115378748239951560 *tests/data/fate/vsynth1-mpeg2-422.out.rawvideo > -stddev: 10.27 PSNR: 27.90 MAXDIFF: 162 bytes: 7603200/ 7603200 > +ac2bfd738a93180bd3cb285367236d85 *tests/data/fate/vsynth1-mpeg2-422.mpeg2video > +702035 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > +b8db8de89c37fab3b9a0248c2820a5ed *tests/data/fate/vsynth1-mpeg2-422.out.rawvideo > +stddev: 10.30 PSNR: 27.87 MAXDIFF: 167 bytes: 7603200/ 7603200 > > configuration: --prefix=/usr --libdir=/usr/lib/x86_64-linux-gnu --shlibdir=/usr/lib/x86_64-linux-gnu --disable-static --enable-shared --enable-gpl > > It works with option --disable-ssse3 > > Below is the info for my CPU > > $ cat /proc/cpuinfo | grep 'model name' | head -1 > model name : Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz > > Thanks > Haihao Does this help? > diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c > index 5b510c9af9..8258a79845 100644 > --- a/libavfilter/framepool.c > +++ b/libavfilter/framepool.c > @@ -90,7 +90,7 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size), > } > > for (i = 0; i < 4 && pool->linesize[i]; i++) { > - int h = pool->height; > + int h = FFALIGN(pool->height, align); > if (i == 1 || i == 2) > h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h); It's the only behavior change i could find in the patch that could make a difference. I'll send a different approach in a bit either way. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".