From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0834451F0 for ; Thu, 12 Jan 2023 04:45:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFCCF68BD66; Thu, 12 Jan 2023 06:45:10 +0200 (EET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1882E68A2BD for ; Thu, 12 Jan 2023 06:45:03 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673498709; x=1705034709; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=9Ky40LFMMHMNJ4/rMWAV/jYAqCXxi6V9QrHND7Ixb8M=; b=h6wmx0BiTCc3+qbtUZXvXwsUSP+tYQ+HglYMdxKQChWz8EaBWfgS2tAD F9hUUB/b9yOU9mbI5t/TOZPUERL4XRAzKK4obM3AfYjFkZKOV4Zoo5yu/ qbdiYq4u8wv5+ft7nCt6iw8xP+jPqJ73Rroek0AzaUKFKgk07tc+b/13g /jKZkNFguSqxzfBhhpe/qFInzrQp2nSWmcyHbuhqM0dO2SkEZBpmVGewI uo9FNy/yGpPPYfVOA+YxxovYVImZrIflQsKDza7ELLghnJTjJwxSMi8DY IRNXKeBbp5eCgUGSN+wzfRzZG1qLnWuHQGzUefeU0p3tJnJflIo/jk2ps A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="409847564" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="409847564" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 20:45:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="607651905" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="607651905" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 11 Jan 2023 20:45:00 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 20:44:59 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 20:44:59 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 20:44:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yv5e+YNu19hdhQ5J7/Cef6f3RReC6wJMIlnESpUXw/3OhaECtW81GHSd1tCfj7FsYHjrnwYcL8UeRHTvd/i8DGLXcpL3cTWCCI+8dyjpmCGL/7JeVD83cwOg7DcOIktkczJvh3IeRupIeJY6UHGzwfBTCNGYFu7F9BSwMwjVJv/FnN0zFpR5gQkQc2lcq0Gru/nhgOOONBewOt6yB9wqftUekHsUgF0s9hcGxPSM2TOTj2vIMa8wzO5fiELyzkbn/7XI3bJL1OOY4wX6PjZMPTO0amkiI39qsrB9nXM1fjFNtHFgmiERkfGKyM6a2AiYmXLvVTJ/lmS8TiMtJgqh4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Ky40LFMMHMNJ4/rMWAV/jYAqCXxi6V9QrHND7Ixb8M=; b=XNx6kY4ThzFg261crLA0TU0yro4g/M5/DHbVnj324tyQG+0bn+7GCiVndhKZg2pACnpMTzAylebIZ56dnYXA/HpUL6+q8SNzrhfDuzCVeVXGuen5OsfeIvyYSlFHTDg0RuAkN8ikOE5jqsB1DH9nOQGqS6BUOldx7kBcVeNL1/NaxLLro22Zkmijb1J84Bp+tS+cZfxruurY9G0HlFlq8usFRZNIWbnjdC2XE0lRKmoEx/EqEpV95aBBM05uof0XgWBU6fP6C2WqmJKEZ2vhea2lc9Ncs+ipm6IODrzBTcHSusWOl3hgjoWZj4L/WbQPDb5bdc8RraMyxt1J5h/Qaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MN2PR11MB4710.namprd11.prod.outlook.com (2603:10b6:208:262::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 04:44:53 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%4]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 04:44:53 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 4/8] lavfi/vf_vpp_qsv: add vpp_preinit callback Thread-Index: AQHZJjvfv/Mn8ZTfxUC9FD2VnpqyUK6aNL0A Date: Thu, 12 Jan 2023 04:44:52 +0000 Message-ID: References: <20230109071210.1829699-1-haihao.xiang@intel.com> <20230109071210.1829699-4-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|MN2PR11MB4710:EE_ x-ms-office365-filtering-correlation-id: e5febf54-92de-4965-b780-08daf457bf01 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fl5VLY10BuLIfZM5GAmUu4lI8ujIzjBtboIAMxUdK5dtfbXEmMZCa8YJ5irD+o0ZZ2pCfKNVqKI851tpVvjz6ZfoDjaQ6EqG1XDpN8M+coLlctvNd30uFJh17SA3oLmvARrYkXFgINtwU7KOIo5Wfy7OAsVf4ibnN7FGn+qvm8taXiGD/YENqn4odMbs+hOyDuI37kXhxGg1Er5pX/iXgMvDV4TIeumqmu8TtlAnX1Y0Mbbm2pPDBiAD0GHqQf3ff4r4CACDvKPYaXpi9uclXjRp6WxOnWJ8KQmAPH8RrlUD08R2ULAraSyseG7hhFIyeJA1mYkicFroDRyEkuxOxeUeBxHcltJgYhWf3u6heO40i8mt/Bn4aICXnBKvHK/X6RjK1ohrO4DKcwrHdsyVkQWwTaWzrGOM1bxm4j5d+EjbwgYSfeOC5d4psQIfqMp6fVxXy7jVt/p8q5+ISQkGFh8UjUkjBOaeQGJXEYBoby3t/7bmjtTpIoirQhjCl0rvZBMpvuNBUwQtS0cDJ2MmXjIx/SYkc90jsIYpnnD+PKj14Rhj4nSC7bPPiRwRgRaUgy9if4KlVb7uYUIpoM1IXE+ZPuGHcWS2rYkaiTbUVqW5SYHL3370UWAmu/VImqiPVcY96efJA84ndk1WJSHtSit+w70D/bOFrCzO+sX8HUcGm8q+i40y1LgtcOHBWVt4nVAKBp2Rw7U54hDJPb673/JILtTtDRUPyatxYfUoVqs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(346002)(136003)(39860400002)(396003)(451199015)(82960400001)(478600001)(966005)(6486002)(41300700001)(38070700005)(38100700002)(6512007)(71200400001)(86362001)(316002)(2616005)(66556008)(66946007)(26005)(66476007)(186003)(76116006)(64756008)(66899015)(36756003)(5660300002)(6506007)(2906002)(83380400001)(66446008)(91956017)(8676002)(6916009)(8936002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXdad2dUU21BRnNNSWJIc0hnZFVqOGtEU2tGTERpTmlyM3VvclZoNnFxWkUz?= =?utf-8?B?ZGlkNzExb3ZyNVRJUVpueitsN0ZEeXNJclJRM3ZPbFRnbFR5OFRNUm1jMWZB?= =?utf-8?B?ak9HMlhiOU1YK002MTBFTkZZRlZUVW9Ba1FNUU5LNE1XSi9FbjdieXlxYTl0?= =?utf-8?B?dzRGcGNqMWNVdVNhSE9UZm5JOXFjQ01zbDlpS2x0VWlyS2VsY25VNHZHd3dN?= =?utf-8?B?YWd3b3NHaFdoeDBrM2ZzcmdJVW1KdDdIN0dxZW1KaFNPY0k0RWpYMjR2blYx?= =?utf-8?B?c29uRmcvcW41VVhEQ0Z6Zjg0b001TkU2NlhMY3hjdGFFc280SHhtRWNJRHhy?= =?utf-8?B?ZkpyMy9Bd0lHMlpGZFJMdDBzdjMxQUhEMVBnYU9mcUR6M3dWa0tNUkFCS21T?= =?utf-8?B?REZ4dnJzU2RVckNhakN0a25EcnJibzUrV3JKRGk1VUZTb0ZwbkwzYWQ2Y2cx?= =?utf-8?B?MlBENmJoeUJIUk9zRjVGOXhIS05qT0k5LzRQMnI5cW1KZVhmNUlBd3JybkNC?= =?utf-8?B?aXpZdklzKzFJWlFyUnZJbEo5WVRXL0RNV09YYk9hb1B5TXFNVVRsWTZmZjVo?= =?utf-8?B?a2NMcUI1S1NJL2xPcXlNU0NsNjNJNWk0d1pJLzU4YlhsVUsvRVFRbURuTWhq?= =?utf-8?B?b3RYT2NQTjR6VlFVWXg0ekFhVWdXRjh6bmI4bmJvbTdid0ZVLytITnhaWnh4?= =?utf-8?B?elJNd2k5NWo0SkZKczhadTNOeFZDcnhVU1BQWnVITjZwZmd4UlhtUmVRSXpO?= =?utf-8?B?WlNUMTVRa0xCbDNDbFZLYi9zVERHU0dCRHpRdzhZMTRIb3JEUVNYR3BudjZX?= =?utf-8?B?Ni9xV1lCK25HeHZGUmc3a1BTdHcvdVpzNDF5Z2d0VkNMWXVSdUhYRzJscEtV?= =?utf-8?B?YUwrMWRHdW1Jb0lYUEc1N1pVVkN5YkpLVk9pd2RLZGlZdlM5MDRTOHkxM3V5?= =?utf-8?B?c2JWVHZBVmFJTFJGcmZaNWxKampyd2M5cHNFUzk1RVJBZ1BFVUNHQUV4OEF1?= =?utf-8?B?RmRnS05oaWtXZVBYZk42bG5TaU5qdEliRHc1bGxETWU2QU92amZtVUk0Qi9R?= =?utf-8?B?Zk9Hek1DazZGSUhXOXpIaEY3dkRXaVh0T0VtcWZvZ25pelROM05xU1FaUzhZ?= =?utf-8?B?WkVnWmFUb3hHdUo3REF3WXRtbE1aZGZmU2s1Q2pBdEZmTnNHd0JUZzV1Rmhz?= =?utf-8?B?SGltL004MW9hbjRtSHJPZ3ZoZWlwYzhLdWhEUXFvQmNmVC83NGNLem0vV1ZW?= =?utf-8?B?MXpUNVNqanNJZHVjOFZBdWtpSk1HbTlsNWJPdU5LL3R4K1Niclc0S1I5dG5j?= =?utf-8?B?Zm54RWJiUklZNC9sbS8rYVgwa0U0MmV2a21sS3NHY002RlYzWTBrKzVKR211?= =?utf-8?B?NkpITVV6MTEyOVE5Qm54NG15NHhleWFjRUtpRWgwbFNjZXJZYUNLbFU0ek0r?= =?utf-8?B?UEd2eEdnaHNkY1dmd29RdkdwQWRWbTJXVXpDVVJoQVRWN3BVVlNEUXFtK0Rh?= =?utf-8?B?VnVsU0ZjK1FYUFphcjlnVWFscHIyRGg3WEVKdnFMR1R5ZnRNVEY0OWt4Zjhq?= =?utf-8?B?THBCRjIyS3hLTCtmTG4waHFEcTBwTndnYTd0MTNFREJKcGVBMFFTbXAyM3Bm?= =?utf-8?B?c0VNckU1N2pNejh5UldkWm81bHRrdlhRUzlHbVBPVUF5WlBMREsrNlBTZ25G?= =?utf-8?B?bUJ2UzZkSzVPM0JrNkFZaXVyckhDL3gzdGxLLzZFZEN0cFlDTmNSN3ozdXQ3?= =?utf-8?B?Q0hReUhlMGVudTkzNXJZMXp2KzJta0R4STVVV3hHNG90a0NJR1Nzbk5mcktS?= =?utf-8?B?ZHZzNWs2SEFwV2JCL2RnVS8xZ0Z4M3p0cmlObldoSEc5Qm1wUVp2ZVhnMTQ1?= =?utf-8?B?T1R5bU9iSWlWZmZRWC9JK3o2ZW41RndCZzJQY245eTdqcHlZWTlzVWxhQkw5?= =?utf-8?B?bUpGR2RVN3dreFdNSEdTNC95d0dBWjhUL2dmcVdjdkNoNm80VWh4eDlDQ08w?= =?utf-8?B?dnl5QlBNd2xTU2gwL2hLc0xzM25MSzFOVUkrUkNYZHpYQUdBMjRIeU5EYmg4?= =?utf-8?B?cGNRSDhzT1ByZ08xTzROdmdheFVBWG9vdEhDMWNDVkIrOFZxek1zZXhSRlV0?= =?utf-8?B?NTUvczR0MkZIT0UrSG1abHZYaTcxQkdVc3hXWncyOEN4UXJhTGpkWEoyWkI2?= =?utf-8?B?emc9PQ==?= Content-ID: <3A208714EF32374D87BC1DA664544321@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5febf54-92de-4965-b780-08daf457bf01 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 04:44:52.9926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5iyOBxgvrg51SZ2g2CtqSx13BrfochVnhBbZpLvz8Hsedm1X1JyHAwzocHBu4j1yHxCNaunEHKH3tqI3Ui/Tvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4710 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 4/8] lavfi/vf_vpp_qsv: add vpp_preinit callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Do, 2023-01-12 at 05:11 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > From: Haihao Xiang > > > > Set the expected default value for options in this callback, hence we > > have the right values even if these options are not included in the > > option arrray. > > > > This is in preparation for reusing the code for other QSV filters. > > > > Signed-off-by: Haihao Xiang > > --- > > libavfilter/vf_vpp_qsv.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > > index cf11cd7fdc..2a7b06fa33 100644 > > --- a/libavfilter/vf_vpp_qsv.c > > +++ b/libavfilter/vf_vpp_qsv.c > > @@ -259,6 +259,19 @@ release: > > return ret; > > } > > > > +static av_cold int vpp_preinit(AVFilterContext *ctx) > > +{ > > + VPPContext *vpp = ctx->priv; > > + /* For AV_OPT_TYPE_STRING options, NULL is handled in other way so > > + * we needn't set default value here > > + */ > > + vpp->saturation= 1.0; > > + vpp->contrast = 1.0; > > + vpp->transpose = -1; > > + > > + return 0; > > +} > > + > > static av_cold int vpp_init(AVFilterContext *ctx) > > { > > VPPContext *vpp = ctx->priv; > > @@ -683,6 +696,7 @@ const AVFilter ff_vf_vpp_qsv = { > > .name = "vpp_qsv", > > .description = NULL_IF_CONFIG_SMALL("Quick Sync Video VPP."), > > .priv_size = sizeof(VPPContext), > > + .preinit = vpp_preinit, > > .init = vpp_init, > > .uninit = vpp_uninit, > > FILTER_INPUTS(vpp_inputs), > > I do not get the point of this at all: None of these options are of type > AV_OPT_TYPE_STRING. You are merely setting the default values that > av_opt_set_defaults() would set lateron anyway. > > I also fail to see how this would facilitate reusing this code for other > QSV filters. Actually this is a part of an old patchset, see https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=4467, I want to use use functions and data structures defined in vf_vpp_qsv.c and qsvvpp.c to implement scale_qsv and deinterlace_qsv filters, hence we may remove vf_scale_qsv.c and vf_deinterlace_qsv.c E.g. saturation option is used in vpp_qsv filter but not in other qsv filters, so av_opt_set_defaults() works for saturation in vpp_qsv filter but not for other filters, we need to set a default value to vpp->saturation for other filters, otherwise vpp->saturation is 0 for other other filters. Thanks Haihao > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".