Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format
Date: Fri, 8 Mar 2024 02:14:36 +0000
Message-ID: <ae2dc231036dd8672c2d8223a25bcd5b4b0a14fa.camel@intel.com> (raw)
In-Reply-To: <NsM4h3w--7-9@lynne.ee>

On Do, 2024-03-07 at 05:05 +0100, Lynne wrote:
> Mar 6, 2024, 06:26 by haihao.xiang-at-intel.com@ffmpeg.org:
> 
> > From: Haihao Xiang <haihao.xiang@intel.com>
> > 
> > Otherwise s->input_format is always yuv420p.
> > 
> > This fixes invalid output format for hwframe download in the command
> > below:
> > ./ffmpeg -init_hw_device vulkan -f lavfi \
> >  -i testsrc=duration=1,format=nv12 \
> >  -vf 'hwupload,format=vulkan,scale_vulkan=1024:768,hwdownload,format=nv12' \
> >  -f null -
> > 
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> >  libavfilter/vulkan_filter.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavfilter/vulkan_filter.c b/libavfilter/vulkan_filter.c
> > index d3dc2fdacb..cef42eeb4d 100644
> > --- a/libavfilter/vulkan_filter.c
> > +++ b/libavfilter/vulkan_filter.c
> > @@ -187,6 +187,7 @@ int ff_vk_filter_config_input(AVFilterLink *inlink)
> >  s->input_frames_ref = inlink->hw_frames_ctx;
> >  
> >  /* Defaults */
> > +    s->input_format = input_frames->sw_format;
> >  s->output_format = input_frames->sw_format;
> >  s->output_width = inlink->w;
> >  s->output_height = inlink->h;
> > 
> 
> LGTM
> Thanks

Thanks for reviewing the patch, pushed.

BRs
Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-03-08  2:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  5:25 Xiang, Haihao
2024-03-07  4:05 ` Lynne
2024-03-08  2:14   ` Xiang, Haihao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae2dc231036dd8672c2d8223a25bcd5b4b0a14fa.camel@intel.com \
    --to=haihao.xiang-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git