From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 147D645A00
	for <ffmpegdev@gitmailbox.com>; Tue,  7 Mar 2023 20:55:01 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3547B68BD2D;
	Tue,  7 Mar 2023 22:55:00 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 522FF68A4DE
 for <ffmpeg-devel@ffmpeg.org>; Tue,  7 Mar 2023 22:54:53 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 327KsqbQ003221-327KsqbR003221;
 Tue, 7 Mar 2023 22:54:52 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 5591BA1469;
 Tue,  7 Mar 2023 22:54:52 +0200 (EET)
Date: Tue, 7 Mar 2023 22:54:52 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <tencent_589821465B70B06CFC3CB6657BA194ECD207@qq.com>
Message-ID: <ade93f5f-cf2f-63a0-bfb1-26b350fa7db2@martin.st>
References: <tencent_589821465B70B06CFC3CB6657BA194ECD207@qq.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] codec/arm/hevcdsp_idct_neon: remove
 duplicate mov
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: xufuji456 <839789740@qq.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ade93f5f-cf2f-63a0-bfb1-26b350fa7db2@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 6 Mar 2023, xufuji456 wrote:

> ---
> libavcodec/arm/hevcdsp_idct_neon.S | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S
> index 41ca3b83a8..66ed1c6785 100644
> --- a/libavcodec/arm/hevcdsp_idct_neon.S
> +++ b/libavcodec/arm/hevcdsp_idct_neon.S
> @@ -877,33 +877,27 @@ function func_tr_32x4_\name
>         vld1.s16        {q0}, [r9, :128]!
>         vld1.s16        {q1}, [r9, :128]
>         add             r4, sp, #2048
> +        mov             r2, #64
> +        mov             r8, #-64
>
>         bl              tr_block1
>         mov             r1, r11
> -        mov             r2, #64
> -        mov             r8, #-64
>         add             r3, r11, #(56 + 3 * 64)
>         scale_store     \shift
>
>         bl              tr_block2
>         add             r1, r11, #8
>         add             r3, r11, #(48 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bl              tr_block3
>         add             r1, r11, #16
>         add             r3, r11, #(40 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bl              tr_block4
>         add             r1, r11, #24
>         add             r3, r11, #(32 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bx               r10
> -- 
> 2.32.0 (Apple Git-132)

LGTM, thanks, will push in a moment.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".