Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: xufuji456 <839789740@qq.com>
Subject: Re: [FFmpeg-devel] [PATCH] codec/arm/hevcdsp_idct_neon: remove duplicate mov
Date: Tue, 7 Mar 2023 22:54:52 +0200 (EET)
Message-ID: <ade93f5f-cf2f-63a0-bfb1-26b350fa7db2@martin.st> (raw)
In-Reply-To: <tencent_589821465B70B06CFC3CB6657BA194ECD207@qq.com>

On Mon, 6 Mar 2023, xufuji456 wrote:

> ---
> libavcodec/arm/hevcdsp_idct_neon.S | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S
> index 41ca3b83a8..66ed1c6785 100644
> --- a/libavcodec/arm/hevcdsp_idct_neon.S
> +++ b/libavcodec/arm/hevcdsp_idct_neon.S
> @@ -877,33 +877,27 @@ function func_tr_32x4_\name
>         vld1.s16        {q0}, [r9, :128]!
>         vld1.s16        {q1}, [r9, :128]
>         add             r4, sp, #2048
> +        mov             r2, #64
> +        mov             r8, #-64
>
>         bl              tr_block1
>         mov             r1, r11
> -        mov             r2, #64
> -        mov             r8, #-64
>         add             r3, r11, #(56 + 3 * 64)
>         scale_store     \shift
>
>         bl              tr_block2
>         add             r1, r11, #8
>         add             r3, r11, #(48 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bl              tr_block3
>         add             r1, r11, #16
>         add             r3, r11, #(40 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bl              tr_block4
>         add             r1, r11, #24
>         add             r3, r11, #(32 + 3 * 64)
> -        mov             r2, #64
> -        mov             r8, #-64
>         scale_store     \shift
>
>         bx               r10
> -- 
> 2.32.0 (Apple Git-132)

LGTM, thanks, will push in a moment.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-03-07 20:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06  2:18 xufuji456
2023-03-07 20:54 ` Martin Storsjö [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ade93f5f-cf2f-63a0-bfb1-26b350fa7db2@martin.st \
    --to=martin@martin.st \
    --cc=839789740@qq.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git