From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy
Date: Mon, 30 Oct 2023 10:01:13 -0400
Message-ID: <adb258d6-e240-49d2-b782-25dc43927af5@gmail.com> (raw)
In-Reply-To: <ZT+1xuIwyqW/btzY@phare.normalesup.org>
On 10/30/23 09:55, Nicolas George wrote:
> Leo Izen (12023-10-30):
>>> difference: user data should not be silently truncated.
>> There isn't really a bug here, just an extraneous compiler warning.
>
> Truncating user data silently is a bug. The warning is right and needs
> proper fix.
>
> Regards,
>
The warning is not that truncation might occur, but that if it does
occur, the buffer won't be nul-terminated. This is not actually the case
because the size passed to strncpy is one smaller than the buffer size,
and the buffer is zeroed. However, the compiler doesn't know this.
Also, fwiw, info->assoc_language is the name of a language. It shouldn't
actually ever be 63 characters long for real streams in the wild, and
truncating it is just a memory-safety precaution. It's not a bug.
- Leo Izen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-30 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 12:47 Leo Izen
2023-10-29 12:49 ` Leo Izen
2023-10-30 0:23 ` Andreas Rheinhardt
2023-10-30 0:33 ` Leo Izen
2023-10-30 7:51 ` Nicolas George
2023-10-30 13:52 ` Leo Izen
2023-10-30 13:55 ` Nicolas George
2023-10-30 14:01 ` Leo Izen [this message]
2023-10-30 14:16 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb258d6-e240-49d2-b782-25dc43927af5@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git