From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4248F47290 for ; Sun, 3 Sep 2023 16:17:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4080468C62F; Sun, 3 Sep 2023 19:17:21 +0300 (EEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44FC868C55E for ; Sun, 3 Sep 2023 19:17:14 +0300 (EEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1a28de15c8aso668642fac.2 for ; Sun, 03 Sep 2023 09:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693757832; x=1694362632; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F2GNahuU286OBdCGNs+X+GLNAGkfstKO02KRHQQiwDs=; b=F7H/QpKXwOU2vNx9UOsyoMZP2DfJUjYjZLs/2FiAvm56Y8WBHfvD9FzNo2/LNGSxgJ XJwLp0oibw/jj219QvBVqrsWB5ErZhpBaEM715g8Lt31CoSJGe61yB/a7aAoNr/chgua bf0lp2ldCHLrQPRSPRW4t5XJb8+qbbQog0pjQfktn/z9+9LfbrIfyS1uT9sw6E3ZEM0l n27LtNW6nV718VQnZkCh2KScx18xW6WSr/07GeW4hS34stnosPMQjpw8oAK6Y1cWZLqD 9hCyEHBtOy3CcBr+4j4eJmX/5F6It1mURKGtj97283mwd9DxTu1Uj5BmjsQQy16psBWk 55vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693757832; x=1694362632; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F2GNahuU286OBdCGNs+X+GLNAGkfstKO02KRHQQiwDs=; b=MD8AblxRY2KpwXY/yHxMqWAAC3t8bntcBkx1gC/3NdVhlNJbvHN4A6yhOsEOWIFTMV /ftWyuCoVvQD2xdTcY5laMumzVRtlGAjUZZKBs0zh3UhA7LSeVw4GsY+8c4hIpb27UDL UtVxijmZz5EUGPdtVvAccqo5bhma578fLstaYUeNAmbXbjDl58qk1sB1lqjcxnCuLPk/ 1pJULyCqGqzxzNCk7BZjTWUXDKqjwvd7p6e9BMeQVkr74Vs3u4o+8Q2EPMhHX4Ez0bnS A64ZG+wKqlSEZxsja0fPLtQkg0FlK3HsyG2Xt9u0TBP1YQlLn+14YjuvYJI1Ulg6QXJM Uhew== X-Gm-Message-State: AOJu0Ywh2p+nUvYYNSlDItjl8fIzBmZJBz/Z41rwdLchT0A4Ubd0OiMb N6eEPcpStbdhxZd1b6wNI+NCkZa9kcg= X-Google-Smtp-Source: AGHT+IF78Ob1l/LCLyeobVW4wF3knOi7D9HTf5ZU+wqFy7osfnCTVt5fBXWPxqpSb8mP7YBI9J/U1A== X-Received: by 2002:a05:6870:c14b:b0:1b0:653a:af92 with SMTP id g11-20020a056870c14b00b001b0653aaf92mr9890533oad.8.1693757832238; Sun, 03 Sep 2023 09:17:12 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id br13-20020a056871b40d00b001cc9bc7b569sm4480756oac.27.2023.09.03.09.17.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Sep 2023 09:17:11 -0700 (PDT) Message-ID: Date: Sun, 3 Sep 2023 13:17:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230903160013.833742-1-aler9.dev@gmail.com> <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/3/2023 1:15 PM, aler9 wrote: > sorry, to git add what? You say you integrated my comment, but the contents of the patch are exactly the same. > > Il giorno dom 3 set 2023 alle ore 18:02 James Almer ha > scritto: > >> On 9/3/2023 1:00 PM, Alessandro Ros wrote: >>> I integrated James A. comment and fixed patch format. >> >> I think you forgot to git add. >> >>> >>> In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP >>> specification tells that VPCodecConfigurationRecord, a.k.a. vpcC >>> ISO-BMFF box, must be inserted into a metadata message. However, the >>> function responsible for generating vpcCs currently returns invalid >>> boxes, that are lacking the Version and Flag fields, inherited from >>> FullBox. For some reason, both flags were being added manually in >>> movenc. This patch fixes the issue. >>> >>> Signed-off-by: Alessandro Ros >>> --- >>> libavformat/movenc.c | 3 --- >>> libavformat/vpcc.c | 2 ++ >>> 2 files changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >>> index 7ef6cef46a..696ae5a6c9 100644 >>> --- a/libavformat/movenc.c >>> +++ b/libavformat/movenc.c >>> @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s, >> AVIOContext *pb, MOVTrack *tra >>> >>> avio_wb32(pb, 0); >>> ffio_wfourcc(pb, "vpcC"); >>> - avio_w8(pb, 1); /* version */ >>> - avio_wb24(pb, 0); /* flags */ >>> ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, >> track->par); >>> - >>> return update_size(pb, pos); >>> } >>> >>> diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c >>> index ea66959abf..256407dd6d 100644 >>> --- a/libavformat/vpcc.c >>> +++ b/libavformat/vpcc.c >>> @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, >> AVIOContext *pb, >>> if (ret < 0) >>> return ret; >>> >>> + avio_w8(pb, 1); /* version */ >>> + avio_wb24(pb, 0); /* flags */ >>> avio_w8(pb, vpcc.profile); >>> avio_w8(pb, vpcc.level); >>> avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1) >> | vpcc.full_range_flag); >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".