Re: [FFmpeg-devel] [FATE PATCH] Properly list test errors when there are no failed tests

["Martin Storsjö" <martin@martin.st>]

On Wed, 18 Jun 2025, Michael Niedermayer wrote:

> Hi Martin
>
> On Fri, Jun 13, 2025 at 01:57:05PM +0300, Martin Storsjö wrote:
>> If there were failures while running tests, e.g. if failing to
>> compile checkasm or any other of the test programs, there are no
>> failed tests per se, and the number of succeessful tests is
>> equal to the total number of tests.
>>
>> For these cases, check the job status code instead of declaring
>> them as a full success.
>> ---
>>  history.cgi | 2 +-
>>  index.cgi   | 2 +-
>>  report.cgi  | 6 +++++-
>>  3 files changed, 7 insertions(+), 3 deletions(-)
>
> sounds reasonable, but ill leave the perl review to someone who actually
> knows perl

I've tested it locally, so if we have nobody else volunteering to review 
it, is that enough?

> Its a few years since the last change to fateserver, i think we dont
> have a script to update the checkout on the server from a git push.
> Its a while, i dont remember exactly :)
> so you have to update that checkout after pushing possibly

I don't think I have access to any such server, but if it's ok with you 
can I (try to) push this patch to the gitosis repo, and then ask some 
admin (Timo?) to possibly update a checkout somewhere.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".