From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CD55430DF for ; Wed, 20 Jul 2022 08:43:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 387E568B62B; Wed, 20 Jul 2022 11:43:07 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 618FD68B0E2 for ; Wed, 20 Jul 2022 11:43:00 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658306585; x=1689842585; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=O/Kgcj6EQQPv8YHAF/YhZb88X9ydjlqLYlwY250w/S0=; b=WpsSEeezpeBwfT/2D9AjbK3gX9Wqhh8EoXRHgLksH80RCTIirUJBkw4k XvlQlMNYoT9YXbUAMxLpoXUyByfc7aaf7tmAQp9G49KZU7r+jTOcl7ZML ZMrLlk5nkoWaJr6vCbNw9Q0pqKICOvZ6sckyrS60/DYlRc/OX/YIb0Mmc vYOjb3gu83bSGQJz2skmCMKtT3i2Uew2anYxufezpm5Cc2pM7AI/YoYR6 pj70BDLDgDEaS9Di9xbihklRtHZ7HBlcr/vR0XmehU0a7s02iZmONGqS4 NZmzMQVjmOKoK9F8k4aCsguqkRUEAkbRftczavlLglHuXzcuZ7OI9Hrcp A==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="273555773" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="273555773" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 01:42:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="843970191" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2022 01:42:58 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 01:42:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 20 Jul 2022 01:42:57 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 01:42:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bfl0eycGfoKBMTwGNLtz9j3p1pSH+LlgMAQfvwHosYnfWe2JlSMLF/Y0Dr+fmx4GIp5khKteibBbkEZgAoowvCncHTPE0YH5Z90v4uLSPZ3shZcixpL8QT3q6jkPIkotDCaFsFwHacsW7X1jzLgqLJxiVnnSKQqacGd+LwBuU17SXpmbQr1iU5hw0N4Fh067P4EXgqrvoaHv/hfZfiAHBujwv3TWYPLPYNqyVM2Qp/BHX71DN/lXDoaXk3WUL4Y7RxlNhN5pb7cu037Gzv4Dbe0zNuRitdyFvjNGVmmGRrhGV/akM8+B2Xw+AkXxJe7nkL4W0iRjQ6axSwUDHrLMKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/Kgcj6EQQPv8YHAF/YhZb88X9ydjlqLYlwY250w/S0=; b=CpYvbiihSAFUPJtFe+68spc6Yqik1k9WgDLC7kGMrZupcSxaXmCECXDA9Np+l8TmVetbUG9gJ7yJbkZacUySDUL1udNmVlqlV5vPZcyZXuI3NS5vPt5WsoCTiJfiEW6xHnwY/OwaEVNzxNveDHWWRpcaC10u2VPKG89cMLSAgHRsSuH6rnuh0cKWe8PplBgUvSCIWAQjXg+hwVJD47YiF5wL4a3+yUC+0mJgqD8aDOd2xrlJu4SiyFh3gQqgmDVxtECjYWnv6GpD5HmCI/SpgE9F6atctXgGP70hKDQ7223sGkpjFz6nKFes6vxhh0IsDD2zdS/kdd2uCKnpF9R84w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BY5PR11MB4149.namprd11.prod.outlook.com (2603:10b6:a03:192::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Wed, 20 Jul 2022 08:42:56 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5458.018; Wed, 20 Jul 2022 08:42:55 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL Thread-Index: AQHYlbiWkh+MsRsxrU+Jvg1jZyJRRq2EIewAgAEyPICAAanNgA== Date: Wed, 20 Jul 2022 08:42:54 +0000 Message-ID: References: <20220712062735.20339-1-haihao.xiang@intel.com> <20220712062735.20339-11-haihao.xiang@intel.com> <165814937028.25016.15272296385260114959@lain.khirnov.net> <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> In-Reply-To: <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: afab9751-b142-4eee-ceca-08da6a2bd70c x-ms-traffictypediagnostic: BY5PR11MB4149:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VYd9CV3sgAOlX/w+HmJ7127Y/IdXEZVdRlb+zXNYcxkM5kyYGDq3cRKVcAP0CD4VOuF5W+ELAEv5qyjOir+Wh7oxY0bRNGCFKaRXSDJ5Kl1QyCYPzqVZ6BPVgD0SxzhLy4UHx7f8GSHWzokVRqwd46FQ/w831UnrjU0SkpPFRZ9tUsT/i0Ug9WVeYj+73Udlm9kol2cJpYz17mNX8fS10PYo/jULzUFFw9xMud6bJ+OprkRn9U2k9IPvaIQ1K9qWBPsoDo2vXDaF1E7LID+1j+ol2N9kSeiaSjGeN8wcIfTGMw095DIpwm/qkavw5AlCJYCx/hqTSPz4Iyr8M/XnbPqTeTqtgvQgWkfJdj5SyHmc7TXmTV130s0WNUgqHrfKjQ/opaG7Ovwwaza8SMN2jIOEezwNsDu0xm2HANj+WX/eDgq4EPavPvAqrUaIQgI4qH6FDQA6YoGbvSCTHoSnRlgoC3h4eq+EIOm3n59+1rerak8fREKUu4eKLikFQUS+GFDxhuLGiI/qUtfG9p5D3V0/uaMH1JD7ADpeTajPmNmdTcNNUsDxqNG129t+eJ+8yne99cpq0pqInPiaE2P32t8cArdk8ISTzXwf8E45lSdDeTi8CBI1+YI/0d0l9hZzidXYIn43aJ8SU9T5F+6TOQ9q4HM9ktfI0Y241Yu9t5UlnIdFN9BGfMOfwGm9iMmX9zm/UqdxYsxjLq2oXiN23z6vPa98r6ThqdB4D92QiQLCeQDo/u1BxdHwCRAzORwrfY+JJBUuQGsFmm6retQGuBdmcMUSq1SPh6KcXG/vRBe0R6HKlOjoXa7j/0YJ/irDPV2epUR2aWfQMwg23rzCTg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(346002)(366004)(396003)(39860400002)(8936002)(4326008)(66946007)(38100700002)(71200400001)(66446008)(8676002)(66556008)(66476007)(64756008)(19627235002)(110136005)(91956017)(38070700005)(76116006)(6506007)(82960400001)(2906002)(36756003)(41300700001)(26005)(316002)(107886003)(186003)(478600001)(2616005)(122000001)(5660300002)(6512007)(86362001)(83380400001)(6486002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WERlTmJaL0ErakQ5d2pyVjBwL3FVRG43U1BpNW53R1hyaDdBdXI5SFVzUVhD?= =?utf-8?B?aTZTZHhzRDJ1YmtUcTFOZ294dmwrUDRXTURreVd4TSt3ZWZvSFlzTzNVSCsy?= =?utf-8?B?V09VL2RxRGpIWVc5QVdZNHgxNktGaVV3TjZYeFMwS1krN1llclY3WWpKMHZu?= =?utf-8?B?bXpGOXlMV2hMYStWQy9nOWZ1MFdDNHpMVHczc2thbDF0SjkzUWVBVGRTeVVB?= =?utf-8?B?cldqODlLREE5UDVXTHA0NHFwZk1aTE9MalFPai9odTYvaUJLMjh4TkRPdmFT?= =?utf-8?B?TVVpQUxackpBTTdCQXdPY2syLzFEOEVJNnBGcm1ReXZBSXZpRzJ2eDNYNnI3?= =?utf-8?B?bTZNQnYveVlzZUFjT3Q4TUtETTRNM1NhWHlvSUlhN1pjOUV4UU5ldnFkUENL?= =?utf-8?B?VGNZd2FOTmdvWndURFhLcU9WcjNGVkJRcjVuTy96LzZNOFFUbm4wamVieElS?= =?utf-8?B?dWF0K2xxNjZyVWtqMG9qYUs0V0RzdkwzZEc0eWkwY3FSRXRFakw2MTU4ajFk?= =?utf-8?B?VGVmT084VVVhSnlqOGZPZTJNczd0NDN2T3BWSVZUSmgyanhkbE9BY01PeTFx?= =?utf-8?B?UEMzOTBqd3d5anhOKzltd2dvbk5MYTZhWUd6ems0UVgrZnVwelFPTXNpbjF1?= =?utf-8?B?RHo0UDZzTzcxSGdySjVsclZuU3hOaXhvdXpNUW80QVZmeDhsdmd4RFAzMmhQ?= =?utf-8?B?dS9nVDNrMi9STDRhc3l0dkNEbERxWmRiTTgwUkN1eEpFdklGajFsQ1NEZUM1?= =?utf-8?B?RjFhcUpKL2hscDIxL2lTb3EvQlBuNU5IWUorSXhjNnFaREJrSHpVTWlZQUZo?= =?utf-8?B?eG5USG5UV2Z4eWRJWkdTNUJ5OGdKSlV4ZER2ak04SnZnb0VhTWJ3TVg4ZjJn?= =?utf-8?B?WGlJRjN5R3BOS0JMeE9wUTZybUpKUkU3OFlYaUJuOTVsQXpTZFhvL1dqSS9V?= =?utf-8?B?K0w4ektDVlh4SU5WcDlUaE9OQnJjdDJCU2M2T3NtM2ZaMDl3SVVIMy8rbWxY?= =?utf-8?B?blJnamRydTlacUZQeHAzWWpXaE1kcllwR05wdjlOTzVqbnF0bkRBZ1dPcHky?= =?utf-8?B?VDBsRlBGSVBrSjFFNVhPVDhQUHByaFJlZ2lRVW9WMEUvQjVqUkJGeVJQM09j?= =?utf-8?B?d0txb0EweUdZNVEweDFISy8xV2FCYkRNeW5TVEc5Ry93RTFFb045VzA4Y0JP?= =?utf-8?B?YXZJL1kzcmVnVUJreVo4QkNRUmhGUDhaT2Q3NDlXNEJUSTR2RHVFdno5aGY5?= =?utf-8?B?ZStadytJR0FMSVArYVkvVG45Y2Z0Q3I3dXJBdmMvRmZIckxDYU1WR2xXQ1hi?= =?utf-8?B?YUxveXRtd1JoSTY3TEllOWJGUTJPazBBTmdyNDlLOUk5Ymx2TEZIYU1kRjU4?= =?utf-8?B?UHRzekoxMFZBVGxKdXhQU0RXakZBVUpmYXoyYytXMEEyNnVpYXc4M1o0TWc5?= =?utf-8?B?eDl3S2d2T1FJanJCdjJNTm5PMk9UTFdtUzZzMnA5K1Z0eWlzbkdrV0tQYklw?= =?utf-8?B?eEs3NmZmendIRVZ4LysvOURrSVZSenN1QVR2Y3F3d05DUFB1ZWowMlZZNGZ6?= =?utf-8?B?WmR4dFVoejRDR2I1TEVGTDVXZVZUS3dqeEN5TThpTVpQME1WUUx3ODVaSnRF?= =?utf-8?B?SUh0WWI1Q3dBbmlxZzF6MTYrOEgyQmJTQjhvTTNiMFBFOXlaOTZJeWNJbjRT?= =?utf-8?B?c2RCNE9JNG42UzZmOTJyREo2clNYUDBUaTVCZFVnWU9BampkaXNBOUJtenEx?= =?utf-8?B?azJXWlFsSmU5RS8rWmdpOVB6MjJzRVRrbTdLdHR4M2lMUDJVRHBRb3cxbk5I?= =?utf-8?B?QnJjbUdyRCtkVGFiK2JSUEFaQjhmdFZJUTFOUmFQMkFDRTdmU3BjTUU5QVo4?= =?utf-8?B?dWpzdkl6ZHQ1c21NbHJrT1RjaTJZaUQ1WGdWeXoyTGJBdjJjblNwUmZLc1Vx?= =?utf-8?B?L1ZWWm9yKzgyTUQrMzZZUFpzK1pRV3Q1M2tjNjNzV3pZZERZL091TGRLS2lw?= =?utf-8?B?S3RJdzV3ZCt1bmFGcXVSZFFjM05xRkVMdnlCT3N5YjZqaXFMZVI3dmhVYXhM?= =?utf-8?B?azFmTTRmZHhDYVV4YlZxM0xscy9ja1htYmpOdndPR2JQbWF3a3A2anE2eW9m?= =?utf-8?B?elEzR09qR3YvWE5JcFFuQndmNklDbkVDanJnaUFoQy9jTEV6Qm5IQ3RDTFFZ?= =?utf-8?B?TkE9PQ==?= Content-ID: <6150BE8E3E406A498FA3B1AFAA51BAFD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afab9751-b142-4eee-ceca-08da6a2bd70c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 08:42:55.0265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AiS91GNhKjHBHA7DAfeWdsVqfL32lhfhwY/wAwpw0wXH47dcTiMcWMNIF/CkgAPywvYDRkl2tmJraKQ5mgmmvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4149 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Galin, Artem" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-07-19 at 07:18 +0000, Xiang, Haihao wrote: > On Mon, 2022-07-18 at 15:02 +0200, Anton Khirnov wrote: > > Quoting Xiang, Haihao (2022-07-12 08:27:32) > > > +static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) > > > +{ > > > +#if CONFIG_VAAPI > > > +#if VA_CHECK_VERSION(1, 5, 0) > > > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > > > +#else > > > +#define LOCAL_VADISPLAYPCIID 21 > > > +#endif > > > + mfxStatus sts; > > > + VADisplay dpy = handle; > > > + VAStatus vas; > > > + VADisplayAttribute attr = { > > > + .type = LOCAL_VADISPLAYPCIID > > > + }; > > > + mfxVariant impl_value; > > > + > > > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > > > + if (vas == VA_STATUS_SUCCESS && attr.flags != > > > VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > > > + impl_value.Type = MFX_VARIANT_TYPE_U16; > > > + impl_value.Data.U16 = (attr.value & 0xFFFF); > > > + sts = MFXSetConfigFilterProperty(cfg, > > > + (const mfxU8 > > > *)"mfxExtendedDeviceId.DeviceID", impl_value); > > > + if (sts != MFX_ERR_NONE) { > > > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" > > > + "DeviceID property: %d.\n", sts); > > > + goto fail; > > > + } > > > + } else > > > + av_log(ctx, AV_LOG_WARNING, "Cannot get device id from the > > > driver, > > > the default " > > > + "MFX implementation will be loaded for this device. Please > > > consider to " > > > + "upgrade the driver to support VAAPI 1.5.0. \n"); > > > > I would still prefer to fail here. The user requested a specific device, > > disregarding that request is evil. > > Thanks for the comment. There is only one available device for most users, so > the default one and the given one from user should be the same, otherwise it > won't work. I don't want to make them in trouble if they don't have a driver > to > support the new interface. However I agree with you it is a little evil to > ignore the request. I'll update the patch to return error here. > Fixed in v11, Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".