From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2EE5742B60 for ; Wed, 12 Jan 2022 03:01:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BDA968AC71; Wed, 12 Jan 2022 05:01:33 +0200 (EET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BB2B68A199 for ; Wed, 12 Jan 2022 05:01:27 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641956492; x=1673492492; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=WAebmIC5/BSFtPLDJWPhWjHnnZqXThEEwzaSc2EoYN4=; b=AwZrcopm0XSpw1hHgfe+r0/eMSXdwiOOyx/Vzlf6ik0BzHRdciF06Eyg EXKJ4z6Ur/7OUxGDsnB59S7b0gNpC4yBPpV7SAYVOBHv30FBfR9J7Ljaz hVORLNfuaxOPE2Z4rK8TufEzwJ4Xq7qGT6o2lu0VuAXwKOSLFAsG1XayS FnsUnwFnuOVznZql8IVwCgEv7jxgPVf8jH0Bn6lrBb2IE7j5BZ2ZxmHHR JkPnBYnw5hbn53GBn6TmDL5yCblags+RDPOYZIqfv/3q8XZZm/WmSGhCA zgXg/y15s9Tkz5lVeo+v0iqXUuZVpo71A58kEfQzU8n+zGPyKKL+cdB7F g==; X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="243603662" X-IronPort-AV: E=Sophos;i="5.88,281,1635231600"; d="scan'208";a="243603662" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2022 19:01:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,281,1635231600"; d="scan'208";a="472683355" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 11 Jan 2022 19:01:24 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 11 Jan 2022 19:01:24 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 11 Jan 2022 19:01:23 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 11 Jan 2022 19:01:23 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 11 Jan 2022 19:01:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cf+e3bB9WouF7+R5HHJtOaZVWooGqBJ11PJ3vhUcex7dg3tkam8wAEGIMg7TV9ueSKTLBW477kC9KyeKdM81NyyTOvT717j4IZ1NAQETSOHGC7IPuYEnCJbzwrf7i1T5JYZBAKXkvssNAoVhMpwE/QPX8GKnrDiLiEZFstquE3g35w4g8mEhgl3fjXY6Zy3m99/L1EBvDcpkjDYlpegdUvFBBuEE3zwinWjDCHyaC1NzX6nUK8kcsqfCWStRYy6RUg1cBPUo4SSIhInWXoJ4fkT5A/6jRzpFN1vT62RThxpFR6C1Y9S9l4EdCeuP4cop/zYIKyC1xmD8PjSYkavMHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WAebmIC5/BSFtPLDJWPhWjHnnZqXThEEwzaSc2EoYN4=; b=Ts5c252McmbFi2My3+PoJv7zs56EqNlx6o7vGTsxIfLSkFFaIbhCefN2s9V4BKeqmgdKIIcO63SRK7NR47KN/Xas2jad8hJ5jxcJTuufQ22tib6Xe/jfTGoB7ul9qjDGO/IC6H+onl7qbgdzVTT9CESY/+krNDtdFxigC3X/JtI2WjPI1G6FG3GqkpkQXwBPB2oBrbb2zYt4v3k/J3Uo6X18IFn0waq0eG63baFqQlJ5CzmPnm/mJ/NCIV/ORwXAc7HhWC+iWY8ZZl4N5zQ6eNm39qMYcBEKF5IbLvHUn3Ezcbe2DsRSJWH+DNuDe8gChMWNY9aEe8jpJjV/8yDzEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Wed, 12 Jan 2022 03:01:22 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%6]) with mapi id 15.20.4867.012; Wed, 12 Jan 2022 03:01:22 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V2] libavcodec/qsvdec.c: using queue count to unref frame Thread-Index: AQHXFwf3Esgu+xxVI0SBX+ZkLqm0XKxgk0qA Date: Wed, 12 Jan 2022 03:01:22 +0000 Message-ID: References: <20210312024406.642094-1-wenbin.chen@intel.com> <05b6e2ada495b719c2d45fe9e1cd7d8aaa883558.camel@intel.com> In-Reply-To: <05b6e2ada495b719c2d45fe9e1cd7d8aaa883558.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ca880d3-ccd5-4d41-df98-08d9d577d088 x-ms-traffictypediagnostic: BN9PR11MB5515:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1SZA7ruAD6qN8aniGDqPX0tvLLdFs24Uo8LYzCUUL+vM0quhV3MJ3xIkrgDMQGvY91zRt5Hv6lZ1G/8bLBsDvsWyDGNcouoDG8i3heHugv/0W29hzDixIIwVIbUaLHSIj8IDNvo/BcZgWDry99EoDmWpTrCwUeB9e4uiWtEXZOBbybwVMfoat/NB9v/X7HvOHKvm12DCVgqjnCM93eeCB5tWFSYSaYIRPkNcm2/lczTYZYUSnyKblKNc4ghLBgEQ9iCBpTK3LvQPFPY+vqc7o71z7fc5ap+kjHejjc81K/lVg9WIiBEBjkfrntEFHNncyPZSF+T2iY5uoN2eoC1B0m0EJBnKI7urE8GoQceIVEFvWZiVn9uVGO80+pfkr68fAwGPl7jKmvBnuVUvqwKo3vXg9M8WCQhCXRin4cvPyaeAZgu6Y260cDeUuk2Z9JTAZ7XXEP87XfwXn1kX89hR46gUshQyCNkwSJX3m6xqbwQdZAmHKBzzizeHmsMRJd11TfzHGvMqQWnhq5gnqA8BpuupPVSfkvCOn7Ci6urhZltsaqdxaATfcaQcIfGIsa44umJcC2dL0fC0kwaV0syyabtkCbbAOKn/C599skWUfLm4BpsrRtTPXNalLdzZYcf/qlJzMwZgOdxuk/Yv4gVpNzj+q7u8xmwB2k6pcHDJsoB6oCx0L6B+DAY3sbOa28Tpf0Nk+ZWYJ8UKtvyIwN98aRVtGgh4Fs6u9f4yXzmlvk0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(186003)(26005)(8936002)(4326008)(38070700005)(86362001)(6916009)(2906002)(71200400001)(2616005)(508600001)(36756003)(66556008)(64756008)(6506007)(6486002)(122000001)(5660300002)(83380400001)(76116006)(38100700002)(8676002)(316002)(91956017)(107886003)(82960400001)(66476007)(66946007)(66446008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T2NicG91NUtManFpUU1tYzVpVXFVcGM5WGVEdE1tamE1M2UyVzU5NmF3ajlu?= =?utf-8?B?L2RNUXZ2NWpweFV1UGdVaE42RWFEMHZrSFRRN3JjbWZmTHZuTzJ2aGUydnhC?= =?utf-8?B?bWJkc0YxeUl6elZuVHlwRFp1RnByOWZQOG0veDFVaW1pYWNwTnpOMThNVU0v?= =?utf-8?B?MUV4cTNkeWZvc0tyZm9aRjE1U1FxY1VIMWJCeUgreXJXZ3Y0NUtXL0RjaUFC?= =?utf-8?B?OEdJMTdiZmUrK25Gb2k2NmRnVHhBOWJUT0lUQmpvTTFIT0JJejFOcHVuckVo?= =?utf-8?B?UzZ5eEY0ekVGNkx2SmRrNEFreDZIV0hnRGtBWER3Z3Q0azVtM0VIcC9rL1cx?= =?utf-8?B?Ry90UGZyRjNrUlhKbkdveGJEdWovakNxMlkvRGFjdzVYb3hiS2RLZ2ZyN3JX?= =?utf-8?B?bitlZVJLYnRJYlFkbi96eFJ2RHg1emJmVVNqL2piUTJGemNxTEJqZ3E3eEJr?= =?utf-8?B?aUZLdXZrSEdpNDAvclpxSzdhaTFGbThlek5vK0R4aWRQUzFwN0prZVA3SXFN?= =?utf-8?B?aVpLczlmWU5oT1R1K1BzYTJyRGJzU1NRS09WamkvSDZVcVBtNkJPQ1k5T0Ru?= =?utf-8?B?VlBEdGQzTW5UUVZqdTMyam40TkY5OVVqMHFPYTBoa1dFclpzQllCVUNwd3RW?= =?utf-8?B?WDBmcW91ek1xM1RuOFJUU3hNUFhxOFZrUWhJNVI5SFBDSmR6N3JwZUFPU3RQ?= =?utf-8?B?T3FhcHBqaW9XMXIrYnA1SGtqOWVtTHI1RXFWb2dmQU1vOTkwaElHRDZxTjhD?= =?utf-8?B?SWhoVjRwcCsrQmNhRFdqYjlkZ3o0WVpGWDNtblpqWFRIeEZVMHpTdGNMYTMr?= =?utf-8?B?VW9vcFZXdDNoS1d5SjJGWGhnRmExd0YvSXpwemFyWDNMMmc3MTNTTXRERDFh?= =?utf-8?B?bTZPNmpDNEM4MklDL0J4emFsQk9ueVczSGxmTmUrRnFUVk5HZ3lwWEJFL2tB?= =?utf-8?B?MU5iOUN2cmxBMWRVQXZYeU4rSDltdjV5aEVNVWQ1VUdvSnZoVk5veTFtakVk?= =?utf-8?B?dG5PZzhjNEV3SS9qbHlrM0RRWXU2QzdpTWZNL05QSTBMUEZpeFVmTkRBSldv?= =?utf-8?B?cTlSeElTNzV4U3l0SW5MQVM3cnRpaTBYYmlmcThXYkpZd3pENDdSbStyaG9t?= =?utf-8?B?dEtxa04yQ0xwN3BtT2d6Mk5raDFxWEQ2eDl2YTM0VnRuV3FoV0tuKy93ZFQx?= =?utf-8?B?S3F1U3ladjJRZ0them5UNGNzQ3JSbVRPbFVwS1VwSFNTT0ZhM1RPaXRRL2hv?= =?utf-8?B?QWl1WWVvN0NnN0dlbGV3cTI3Y0gxRTlHdGJGTDJCTnY3cXd4ZmlWU1ZBVWY4?= =?utf-8?B?YkFBanNsWDRRbnY5a0s3UDAxMk9Oa3dMcnlFZlFaeHRtYS9lcjZHUlkrUWZk?= =?utf-8?B?NkJReGVycFo1NTcxMjJlV3JWYWdtdDY0L3ZWU2U0bVowWG50NmF0RzJMd2hK?= =?utf-8?B?YXg1YmZKL2dvOXRSS0g4ZlM2NUZiaC8xYmhFUGRsNjZVWjY1SVpobG9WaWtu?= =?utf-8?B?d2hRTHRUOVhQb1lXc0N5ellCakZsUmtqaXh3RG1uYS9LUDk1QnV0YnNHMi9P?= =?utf-8?B?ZW1zUmMrTGR2NFhpQ1NWdjhSN29CVXBXYkp5MjJCT01aM1lNWThtNzh3L2JG?= =?utf-8?B?c0N0NFBRZ1NBaWtZeTd5V1NXbkhrZXhQdmFlZmZzRDBxTWVSVWxPZGtkVlVx?= =?utf-8?B?ZDUwaVBtaTA5S0g5Mkw2cGV6SVhDL3Arb1dZamxaVTAyRzNyNGcwTUNDeXJi?= =?utf-8?B?K1Z5YzM3SVk5Z0tRRjQ2cWdXYkU2bENjODF3QTBsZm9haWpDN0Yrd2taRDRs?= =?utf-8?B?OUd2cUhFdUhsL2tCa1RjckVmZjhIYjBwVzB1Q0RrRHdFVVVXS2s5QXkrL2g4?= =?utf-8?B?QWlpSnhObVZKdnBxcy84ZkF0UmYwWlV1bzZwTkk4QjltempjSnIrV3hmdGNZ?= =?utf-8?B?MmMxWHFrZ0lxRlNDT0ZaN1hUTUdYWk9BSmEySUdJZVJ5a2g1VGJUUUVCcjBh?= =?utf-8?B?TXdDQWUwT0RiUXFSUTJVTGpRRTYxTXhUMFJzMDkxOXEyaitJNmIyNVFMamRr?= =?utf-8?B?TWZLNFhuNXp1VE1HbDhvY0J3ZU4vRmovc2hNeDBmVEQvVDJDcmtaNFFadndr?= =?utf-8?B?Z1ovWU5wd3k3Sk5NSnNkOWtlK2JFbXgrcFphM25uRHcwdjV5KzhObUU5REVW?= =?utf-8?Q?5snxOMh6SOFPh1g/+Fc2Vl8=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca880d3-ccd5-4d41-df98-08d9d577d088 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 03:01:22.4997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YoZX22724GHzBF3av/hHHOrUjhF8ThfhyUo/ldVvDmARYrgKei5Ui4/XVkE4Zf0afyS3e+FxnnQeeQmScgtNeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5515 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V2] libavcodec/qsvdec.c: using queue count to unref frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Chen, Wenbin" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-03-12 at 06:21 +0000, Xiang, Haihao wrote: > On Fri, 2021-03-12 at 10:44 +0800, wenbin.chen@intel.com wrote: > > From: "Chen,Wenbin" > > > > MSDK vc1 and av1 sometimes output frame into the same suface, but > > ffmpeg-qsv assume the surface will be used only once, so it will > > unref the frame when it receives the output surface. Now change > > it to unref frame according to queue count. > > > > Signed-off-by Wenbin Chen > > --- > > libavcodec/qsvdec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > > index 5f2e641373..3abd7bd4a2 100644 > > --- a/libavcodec/qsvdec.c > > +++ b/libavcodec/qsvdec.c > > @@ -513,7 +513,7 @@ static int qsv_decode(AVCodecContext *avctx, QSVContext > > *q, > > return AVERROR_BUG; > > } > > > > - out_frame->queued = 1; > > + out_frame->queued += 1; > > av_fifo_generic_write(q->async_fifo, &out_frame, sizeof(out_frame), > > NULL); > > av_fifo_generic_write(q->async_fifo, > > &sync, sizeof(sync), NULL); > > } else { > > @@ -526,7 +526,7 @@ static int qsv_decode(AVCodecContext *avctx, QSVContext > > *q, > > > > av_fifo_generic_read(q->async_fifo, &out_frame, sizeof(out_frame), > > NULL); > > av_fifo_generic_read(q->async_fifo, > > &sync, sizeof(sync), NULL); > > - out_frame->queued = 0; > > + out_frame->queued -= 1; > > > > if (avctx->pix_fmt != AV_PIX_FMT_QSV) { > > do { > > LGTM, thanks! Applied, thx! -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".