From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62BB643A37 for ; Fri, 5 Aug 2022 06:12:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 42B5468BAA4; Fri, 5 Aug 2022 09:12:56 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB8F868B8A2 for ; Fri, 5 Aug 2022 09:12:48 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659679974; x=1691215974; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=rAdFrwOVT1UCXScS8IEJw0g1OM3vZKBjypktfa+aIjA=; b=F8DUOhK7+y9kcjMvT6T1rh01KxlLx5C3dguNZZFnK6fLpWI2z5EUVdIG tQ3v6MXZ1TeVoNzxotcI8ZpYMqos2o/0G+Lg5BKBCAaefWJwbO4AspNV8 6FXBkY2EsNgGiuNHhVP6bJ14amNYV6LXpcFBknyEgqB3FcpWjXA+RvHFb aewkqRh7+UmI7vdaSd6Ze2B+zsTw96bBzjdWTeJvxSJ5PChyL5NrP6FY/ eGOABEkuNWtQoNfwJl8twUP5wc71lvosoW8ygrj+EHoSek0X8loRq2Uob +vTDhoO8AKBnfGei3xFpdLzJdQYzqVPelCGCC94qWv3YoBQPOzHH50ePW g==; X-IronPort-AV: E=McAfee;i="6400,9594,10429"; a="290906871" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="290906871" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 23:12:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="554005199" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 04 Aug 2022 23:12:40 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 4 Aug 2022 23:12:40 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 4 Aug 2022 23:12:40 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 4 Aug 2022 23:12:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gO/egRHELd9zbS8gAX2FCFCeKQohZJfEWEex/395L4Q1YuXx7RB4+PteC4VFFD5zqC7Dr1OqV3XD7cLR972FOHDe0Io8Wo6ZLbAB3pPkXWv96dAGsGUDPzufvHOKLbRqEq1ZWUDIRE5yUGa28RbxbBCuDAJq+/GEZG/aGta5Jwb4eGat2s0IFWDg/rqH0b94oUiDmrAlU6vxMUGtPhtDn+GPgWxvk640yJ+vCUAzgvf61X2iqxKsHkaIX6t2JyBXdxQyVFg7mdGFtRSooSkKgVBNGLC5pRCf9WHNmyQaWSH2vz0+MuB3k7sM9Iezv+JKTc8kn2o9QjBHr3x8wwEtFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rAdFrwOVT1UCXScS8IEJw0g1OM3vZKBjypktfa+aIjA=; b=EermygWUWJdEl/K2zyZpajR6ZEPvjwb3YSzxmhGq3dkfw3YrWhKiF3CNB1BbYKfdHtoZh7FUDmJ6JCJ+SBZMytO45YX00Rhx+F8/RHkFf2W77Pik5thQs2oyv6VILk8RyHNQTNjTEryoZNYqfhp4O0X30S+tXNgTyplCl4YLeOq+dfldH5fsGWgIkTdSN8eLRAf/VYeT8xKioTyhzB917R1gdrIzbLMtd9mXCK12naoIpCq0TnlGnbZI5awNc756wAZfMK7io6Zvn2m0tSwWtJHpvy3KSOUvinvonjVIX9zM2Mb8LXmgIXnoa3EN+bZalYB7HtXOhPcocgmIbK5bRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by SA0PR11MB4671.namprd11.prod.outlook.com (2603:10b6:806:9f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Fri, 5 Aug 2022 06:12:38 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f%7]) with mapi id 15.20.5504.014; Fri, 5 Aug 2022 06:12:38 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0 Thread-Index: AQHYobV3nWA1uBcqckiYQARn18FvOq2SNCaAgA2tJIA= Date: Fri, 5 Aug 2022 06:12:38 +0000 Message-ID: References: <20220727123631.314004-1-fei.w.wang@intel.com> <20220727123631.314004-2-fei.w.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b118839-d826-4273-5e6a-08da76a97f7d x-ms-traffictypediagnostic: SA0PR11MB4671:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WBkpcHtkLyKYVnKYzde36d4TIa1u/MBmJCXbSG6NVtbZ7dQAGhBbMnxsvp2kndFhO7pWrlsg2M3/vmrwOplcj/l7wENlVqTRGGpfn3Jyg9qtKVGls4Y99nujNpIi1lHCVHKqamGFhAScxb6e5hVCxzb/82oSGvI4mvT+B/MIN5svX30aMzNsxWxlZ1mZ6UjblxmVLpQI3LaZGSZFkhhsuqzAoxXKoPRnfyvxo+fNqoVGJyY0/zI3pkP8DUnj9g938BO8iWAtBNL5mRHkAzil6JLaUAyqJnDvTJS1pBsYHw995jJibzUoVDZDlu1MR7GHEbxfllmZLilqj43XMV7JD4qc24jIxmrY3b8LCjAUYQyjD6asg+SWSXdeGapU/XpBUrvtXQTYB5+bPe239mH0vPQdYiOIfrKMOfvReynql5bt/QOIumBn8eCsImpdTfP2ZRRNBP43/9GtcccomNAHasGOe2nAv+mqc8DfRmegdeOuHpAXYnwuj9Ik8oTpFt3zyVD+dnysEfM5T57epCBY/k7PnA52vCcXzz5akgTUFVpLTvdNA3J/ZoqZnyiJPLsnuFnTLLdnrQxVB5gTOv0n7WlZ55WH+S9ds0X4FksRjkjN03PDjt9UjBM2yj50R/PnhlhdFYhIg0XFikVRP9menRjRExVHbcXeQuKrG3OZcFrILr2O1m3f8b0qZ9Z3gaB4FXjZ05gFXJr1815cgg1iQQD2ErcU2S8kVqZapBiNGDyYwFmQF2WcSozNpT5mnssZHG+jGXpQNsO/7kEIh9bV6M9ZVSRZILyRSQwbszogUgqBi5VMyd0h2v8Zi+RuCYxI2HP0V4nJAwvZjvnDHA6WCA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(366004)(346002)(396003)(136003)(39860400002)(2616005)(8936002)(66556008)(6916009)(6486002)(53546011)(6506007)(966005)(36756003)(83380400001)(38070700005)(478600001)(316002)(5660300002)(64756008)(86362001)(186003)(2906002)(38100700002)(26005)(6512007)(122000001)(82960400001)(76116006)(66946007)(41300700001)(66446008)(8676002)(71200400001)(66476007)(91956017); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y0hvYW44Um9CV1BNTHBoakVtQVlkcm1CTDB3Tkl1REtvYzRFY2xEUjliNG0y?= =?utf-8?B?bmp5SFVpSnF4TlRJTlpCUVVaVlpCbjNaYW9XMUZCSC9ZTE5qVWttVTc3UDRX?= =?utf-8?B?TzAwSEZTVkgvdTl1S1hYcDFwbjYzbzJjSno2eUhPZVlIOEpIeWJLbGZJQ3hM?= =?utf-8?B?RW02MkVHK282bHI3Ymc4TnN6TUUvMVJjV052RHZkK3BHMnRjNzJaWmQ5MkZR?= =?utf-8?B?QjI5cU16Y2FPSjlPZGtycXM3R3l0dUtRYUZBTmcrV3d2cUowcjR1U0hQN2Ev?= =?utf-8?B?dGp0OXV1Tnh1dURpamUvWWYyRnBZK2JoRlpHcFpiL1grdEZvck1iSWwwSmpi?= =?utf-8?B?d1R3MzdHVWhVbXBqZmYwUlVPdEtldkJzclpoVEVzLzM0dk8zVmxsK0xNTTJN?= =?utf-8?B?M2kxU3VuN1pHVERNTWJ0aFp3WkdxKzhGWXEzNGdrTi9WLzZ2K1VmL3NGeXhw?= =?utf-8?B?Q1BiY0VTK3E1dEpyU1lYUkU2Sm1zZno0Vm9acmw2VERDKzFrbnVYMk01K0RC?= =?utf-8?B?OVJaZk1ZaWJYRnJrcW9EcmdOYS9ZNUt3c1FLVkY3RDlkNEMvSGxVc0Y0dG0y?= =?utf-8?B?a0prYXdpTStFaUYvemlMNXpzRFROZjg0dlFFMUhVR29kMHpqOTgyc25MM0Vy?= =?utf-8?B?OUFLM1lUK2VNWHZjckdNNFZsdlA4WDg4MjRaY2RPUjlWaUp6R2hzdmNWWkY2?= =?utf-8?B?ZU4yeGRnbE1MMjZQVnpKYnU4ZFh5azFSbjBNbHk4TGRTSG1iODkwSU5jYkIr?= =?utf-8?B?MnVXUlpkREZEZkVpQ01jRlhlM2JjRWw2K1lxMU9CcVlQWjN2dHR3OTRQUnJG?= =?utf-8?B?Q0lkYnlwOVV4b3ZJTUc3R3YxSDFhUVpWekxXQVc5SE5MdE85VUQ4azlJZzJM?= =?utf-8?B?UEF4aklyUWh0SUlIWS9OTENkSkJSbktxWHVFdVd0bTRSb2FhTVZNU2U2NzY4?= =?utf-8?B?b0lXMC9pT2VLQTRiT1VOTGM4QUdhRkZBYWRqdjJJVk5KUGJJc2gxc1dWV09X?= =?utf-8?B?bWVrcGtoOUl3b1puZUx1ZjJRdTA4Y0hmcU9RMDNERkN0MlU4LzY4ZE9UY2M3?= =?utf-8?B?VWJwZXlNSVNYTVUxRkswRVZ3MlFONnpSaVF6NjNTMC9Qbmdwcy9mT3VGNzJ4?= =?utf-8?B?MWNsbGhPVHFleFo2UWhDMzRsQXZNa2twNUlJV21LNDE3azFuZ1VHTTRPTm5s?= =?utf-8?B?djBjNE5jbGtpSTNUV0JaTDYrdXhOSVE0Q1BseUlJL09GM043Yy9VV1hKNWdL?= =?utf-8?B?QXVmazBvbU5pRVFmQTZVSDE2elBVMTl0ck41akh0azdzYTJjZzBJQzZxT21O?= =?utf-8?B?L0VsZlk0ZGpMN3owUUYzczYxdHFFUWI0K1lqUldvcWZlYjRGQWd1TnE0SEVF?= =?utf-8?B?VkswSXJqREl1ZU8vV2tTNmpYanNHT1B3RGwwRk9oR0hyZytEZ0xkUitMUHF0?= =?utf-8?B?R3k1bnNNRzlHUVZDc1IydVpjSlQ5ci9FN1NHZDJWQUpnNysvMlZ4QWFqTHls?= =?utf-8?B?bkhiQ083aDlZUE0zWEovL3hEYmljMEgyYkU1UlBITjdZN0ExVXI2K05Rb1pv?= =?utf-8?B?amZORWg2NUZsbE9pbC8wNFF0ZUZtOGM3WFQwYnQwWnVUQVJoMm5BWDg3V1Jq?= =?utf-8?B?dU4yM1E4V1FHYzJOc2xRa1dpS3g4MXZ6OWpaUm5JK29Rcy9PTEZUSG1tbVJi?= =?utf-8?B?VUNvVjM2eTF0Tm45RTdqWk1QVDRtTFlITFZBdmdqb2p5MTluYkhpK0hEdSt4?= =?utf-8?B?YVBMbUNGWGtiTDU2eVg2N3kwdkxMeXh5QWpCeHBta0pwbkdKTVR1R1VJQTE3?= =?utf-8?B?cG1HZTI3WlFWNHJleW5URjBibDV6NFhNWHF2aGUybDE1YkxGb09uUlp6NjdM?= =?utf-8?B?N1R2RkxKeU5YYWIvWk9LVXhnNFZTUEtCOHhXRVpGNGkzNERJOFZEamFsNFps?= =?utf-8?B?Zm55NkhMNTNpY0x4d1h3WUpMUkRRYU1EVlhLTCtrVnlIbzVXbnh6UURQSWdO?= =?utf-8?B?bHpka0wzc2p1ZklxdktkOXU3c29JdTgyWGQyODFvTXZZVGlKS2Z5VktoeDdF?= =?utf-8?B?eVlJNjE5NkRTajE0ZktoeldUU0IxdjZYZHFhaHFKM01YRkRUSmdseVBmUmhH?= =?utf-8?B?UVo2M3pYNm41Y1MzOVM0SHJrdmx3aFRWdXQ1OWpjMjJvK3F2TnRtT21VZjJx?= =?utf-8?B?RHc9PQ==?= Content-ID: <1A9401F41D7C08488515F95938279905@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b118839-d826-4273-5e6a-08da76a97f7d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 06:12:38.6663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nHeETzI0qirozJ49hrf/kRGUFjuaLGNGIsxDs7ONlxdv5z7Hy6aGbdPx2voG5kgECT3+x41h60PBlu7PKNTcqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4671 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-07-27 at 18:51 +0530, Gyan Doshi wrote: > Typo in title. > > > > On 2022-07-27 06:06 pm, Fei Wang wrote: > > Previous default value 0.0 means 100% transparency for overlaid > > video, > > which make overlaid invisible. Change to 1.0 will let output video > > much > > more clear and less confuse if user doesn't specify alpha value. > > " > The present default value of 0 will render the overlay video > invisible. > A default of 1.0 is consistent with > most common use cases. > " Fixed in V2. Thanks Fei > > > > Signed-off-by: Fei Wang > > --- > > doc/filters.texi | 2 +- > > libavfilter/vf_overlay_vaapi.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/doc/filters.texi b/doc/filters.texi > > index 47ac4dc7f4..76168955c6 100644 > > --- a/doc/filters.texi > > +++ b/doc/filters.texi > > @@ -26119,7 +26119,7 @@ Default value is the height of input > > overlay video. > > @item alpha > > Set transparency of overlaid video. Allowed range is 0.0 to 1.0, > > higher value means lower transparency. > > -Default value is @code{0.0}. > > +Default value is @code{1.0}. > > > > @end table > > > > diff --git a/libavfilter/vf_overlay_vaapi.c > > b/libavfilter/vf_overlay_vaapi.c > > index b3a624ae15..3e6a0de13f 100644 > > --- a/libavfilter/vf_overlay_vaapi.c > > +++ b/libavfilter/vf_overlay_vaapi.c > > @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = > > { > > { "h", "Overlay height", > > OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, > > INT_MAX, .flags = FLAGS }, > > { "alpha", "Overlay global alpha", > > - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, > > .flags = FLAGS}, > > + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, > > .flags = FLAGS}, > > { NULL }, > > }; > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".