From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B5B0049026 for ; Sat, 2 Mar 2024 15:51:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 666A368D18D; Sat, 2 Mar 2024 17:51:43 +0200 (EET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0D9F568D065 for ; Sat, 2 Mar 2024 17:51:36 +0200 (EET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso2551039a12.1 for ; Sat, 02 Mar 2024 07:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709394693; x=1709999493; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AZizEYTHYUcVTnbJdEmECohXx2yh/Rf2FW22wBSYTNk=; b=OY9GJZ7UavQU8yziwo9uOHm6QhmbaxmhPPDM6ApV+NI//lhQa8BbdKjDyfmTZye1nB H+ZmKRalAjFcEU37Z2S0Jp9xRgDul80Z8HiGF+iWjORQGmY8BTxbnPdce6OmM44vTxyx oAS4/rziJCxJ3pnUYNfDKeIQTtjp6OQub9pmtPtRcqP7xZ6kT8rJwZ/OenyhzRcqgFDR D9x9YT3/uVsh1o6Xtu63fkIqDWK3xA5lm9lf6WGCHF8P3VSrSfGlCTsStw0LRzykZUTa lAs0cD4spz9m/gdgfW49xF3QaUxdz2GGLLC/zHYHUsRrUefdaj7NHdUDVwPtDWKULxrp TQPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709394693; x=1709999493; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AZizEYTHYUcVTnbJdEmECohXx2yh/Rf2FW22wBSYTNk=; b=Rc2FxwHW9DfLtVo17frZ2vDZrQpPl5SYeYeyc+SJsHUVNm15udPCBkMKIrdBP8Kim5 ZGosfMNUPXzyG6Ca7KvACbyOg0oq+YpImZBvHj2BpkmRrM4FRAR3d/GV1/HFi5y8oou9 FSmLi9koAOfeQmxVOKv0eBGHPnBMdSck7xjw7qvaNT+UItMw7dV6/2CfpiieTsVVZ4rb IIZNOBxnTst9+BmlcXg8O6sIC/o+Eu/i16z4Y7ySbQ2zwR+ztmj0zNI2pS5f/Cv4uP7X aLLJ9eQhs/GrunpFX/5boOMLzHYXqmuujtAlRHm5VhQAl5mantGmhlW08KJvZe/+XKEA E3RA== X-Gm-Message-State: AOJu0YxHPScOEjfSQ13AhzUOmF9PrAf61V8tMg8fAZ/C8AkbYJB74OLO +ESPEByD4cmW9/kr+bkMk5zWgZlLQpmGn8+2il33NJtHJn3moiyiwPURMVk7 X-Google-Smtp-Source: AGHT+IFHF0vCvaIgvD7MOZBacfivPVDp3J2EgqbqD7WnTqYDPrZ5alSAmfCVG2pJnK/0yEe2E/q1OQ== X-Received: by 2002:a05:6a20:2446:b0:1a1:491f:fc43 with SMTP id t6-20020a056a20244600b001a1491ffc43mr476701pzc.30.1709394692816; Sat, 02 Mar 2024 07:51:32 -0800 (PST) Received: from [192.168.0.11] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id o8-20020a17090a744800b00299d061656csm4944265pjk.41.2024.03.02.07.51.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Mar 2024 07:51:32 -0800 (PST) Message-ID: Date: Sat, 2 Mar 2024 12:51:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/2024 12:47 PM, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> How has this slipped through? > > Answer: AVIOContext starts with an AVClass* that is unset when using > ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL > pointer which does not segfault. Would setting s->av_class to &ff_avio_options in ffio_init_context() prevent this from happening again? > >> Btw: This patchset is based upon code inspection, not on reading >> actual files. >> >> libavformat/dvdvideodec.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c >> index ef2d4e6df4..f2f23affb2 100644 >> --- a/libavformat/dvdvideodec.c >> +++ b/libavformat/dvdvideodec.c >> @@ -1202,7 +1202,6 @@ static void dvdvideo_subdemux_close(AVFormatContext *s) >> DVDVideoDemuxContext *c = s->priv_data; >> >> av_freep(&c->mpeg_pb.pub.buffer); >> - av_freep(&c->mpeg_pb); >> avformat_close_input(&c->mpeg_ctx); >> } >> > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".