Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Jon Waltman <jwaltman@toyon.com>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] lavc/cbs_sei: Fix H.264/5 SEI unit ordering
Date: Mon, 24 Jan 2022 01:37:07 +0000
Message-ID: <abe4571410fa4ef3947119d5064dea3e@mx.toyon.corp> (raw)

Fixes regression from commit 8843607f495c95c1e67a3ce3d6f15dca6e252439
causing incorrect SEI unit ordering (e.g. after H264_NAL_IDR_SLICE when
prefix is specified).

Signed-off-by: Jon Waltman <jwaltman@toyon.com>
---
 libavcodec/cbs_sei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/cbs_sei.c b/libavcodec/cbs_sei.c
index 141e97ec58..4a4a58957b 100644
--- a/libavcodec/cbs_sei.c
+++ b/libavcodec/cbs_sei.c
@@ -154,14 +154,14 @@ static int cbs_sei_get_unit(CodedBitstreamContext *ctx,
     if (prefix) {
         // ... before the first VCL NAL unit.
         for (i = 0; i < au->nb_units; i++) {
-            if (au->units[i].type < highest_vcl_type)
+            if (au->units[i].type <= highest_vcl_type)
                 break;
         }
         position = i;
     } else {
         // ... after the last VCL NAL unit.
         for (i = au->nb_units - 1; i >= 0; i--) {
-            if (au->units[i].type < highest_vcl_type)
+            if (au->units[i].type <= highest_vcl_type)
                 break;
         }
         if (i < 0) {
--
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2022-01-24  1:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abe4571410fa4ef3947119d5064dea3e@mx.toyon.corp \
    --to=jwaltman@toyon.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git