From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E3D2648B57 for ; Mon, 4 Mar 2024 14:05:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 237A668D146; Mon, 4 Mar 2024 16:05:39 +0200 (EET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A25568CC90 for ; Mon, 4 Mar 2024 16:05:32 +0200 (EET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-412e68b8594so4681475e9.1 for ; Mon, 04 Mar 2024 06:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709561131; x=1710165931; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rJbJa30/rkqTCKSzXTK7SAFH/sVit6O5TbzUdHUwBYw=; b=PArVeHE79D8u2AttQKFs6aaK9Zbqm7GVOaNNwqygDv07ABTR5PiIf9eh12IowOXsnU qzuU+7qqs8obL9Hh3+bzgueV2nsBBOlFb/UckbpGKyELnjRvM26YIntMIoO88s0X7cdo 3vtg/N7AtNPm0Wf5RiK/av8OS07coJvEeaL/AheReVs6JUVfdhJ1hcr83GdRdF5Jj8hY YEVK5b3bVUjlHO6m2eMoZQIpyCSWtdAbTETJwGna+DPEb/m/pgWHxUb8gVOpW4VRsKVV 4WytQtWXo3mAOCGam9HbKgZGqzsYWX8p39LcrulrH0YkR29ZnVKCFRJzklG4CToL62fe mkBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709561131; x=1710165931; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rJbJa30/rkqTCKSzXTK7SAFH/sVit6O5TbzUdHUwBYw=; b=Zn+IsZn/tBSvZxQKUN/fajjL5seFXjjmFeMMcqNbph0eC8HQ4Hzxhwq9rgam4OV8fJ DLZyaOyxzqy4qFlzevWFBaNnuD3kn8G52UPeyEu0uhN1gEutThvaxrqK3PetQkOCqroy L9niPZ9qsMOTlyXLfvN/MlR3j9kGU/03r2+JwMUYl7HQa6e2J/w2pmt9evK9YZYxS5/1 VgKYStDPr9Zgvtv9zqSgpE6mr/VsJyPb9gl9cM0g/TrW7AW3VbaABBBR1UkEVEpT09me Pdaxdva3u/+fewrAry/NsqU25N+r0VX8drvjMxGYtH9MGvD7C7jW1U3L8NUY8wUTPI0M L1Ug== X-Gm-Message-State: AOJu0YzuZKGeXrNFQ/Y8XPrlXcxMLpsB1j8k/HmdZ+CKbpOdTnXiKGBS wL8GbqNQuLu+P80Uor8puyaxbbJM23JeGlMU35ypJ/xcnXMmGNvBauP5/gfQ X-Google-Smtp-Source: AGHT+IGWblJ+GSRqxPEpLzKzBe8G5hIHS9CmI/pT+Txa5IaJOG0LJJtMiELa70zZChloFXL1/ZPCRA== X-Received: by 2002:a05:600c:470d:b0:412:a7da:8286 with SMTP id v13-20020a05600c470d00b00412a7da8286mr6900612wmo.4.1709561131040; Mon, 04 Mar 2024 06:05:31 -0800 (PST) Received: from [192.168.1.106] (33bf3d9d.skybroadband.com. [51.191.61.157]) by smtp.googlemail.com with ESMTPSA id n44-20020a05600c502c00b00412e7f73649sm1181766wmr.12.2024.03.04.06.05.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 06:05:30 -0800 (PST) Message-ID: Date: Mon, 4 Mar 2024 14:05:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-7-anton@khirnov.net> From: Derek Buitenhuis In-Reply-To: <20240304130657.30631-7-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/4/2024 1:06 PM, Anton Khirnov wrote: > + /** > + * Decoding only. May be set by the caller before avcodec_open2() to an > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the decoder > + * afterwards. > + * > + * By default, when some side data type is present both in global > + * user-supplied coded_side_data and inside the coded bitstream, avcodec > + * will propagate the latter to the decoded frame. > + * > + * This array contains a list of AVPacketSideDataType for which this > + * preference should be switched, i.e. avcodec will prefer global side data > + * over those in stored in the bytestream. It may also contain a single -1, > + * in which case the preference is switched for all side data types. > + */ > + int *side_data_prefer_global; My only comment is that it would be nice to include some text about what the practical application of this option is, rather than just technical details. Something like: This can be useful, when, for example, input contains data in both the container and bitstream. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".