Re: [FFmpeg-devel] [PATCH 05/11] chromaber_vulkan: fix use of texture()

[Lynne <dev@lynne.ee>]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1165 bytes --]

On 17/02/2025 19:31, Lynne wrote:
> While the rest of texture() uses were fine, this one was not.
> ---
>   libavfilter/vf_chromaber_vulkan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_chromaber_vulkan.c b/libavfilter/vf_chromaber_vulkan.c
> index 65b53afd64..f8cfab1480 100644
> --- a/libavfilter/vf_chromaber_vulkan.c
> +++ b/libavfilter/vf_chromaber_vulkan.c
> @@ -142,7 +142,7 @@ static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in)
>       } else {
>           GLSLC(1, ivec2 size = imageSize(output_img[0]);                   );
>           GLSLC(1, vec2 npos = vec2(pos)/vec2(size);                        );
> -        GLSLC(1, vec4 res = texture(input_img[0], npos);                  );
> +        GLSLC(1, vec4 res = texture(input_img[0], npos + 0.5f);           );
>           GLSLC(1, imageStore(output_img[0], pos, res);                     );
>           for (int i = 1; i < planes; i++) {
>               GLSLC(0,                                                      );

This patch actually broke the filter, since the sampler is normalized 
(-1;1), so patch dropped.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".