From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C86B4327F for ; Fri, 23 Jun 2023 11:26:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A5FD68C1E8; Fri, 23 Jun 2023 14:26:38 +0300 (EEST) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC77268BEF0 for ; Fri, 23 Jun 2023 14:26:31 +0300 (EEST) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-55b85b94bb0so288495eaf.0 for ; Fri, 23 Jun 2023 04:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687519590; x=1690111590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=LeRcwBbxP8qSgReccvjmd+si5KWAvFJg2+f/IOmB80s=; b=M3P3YLiHTM4G1nT+FYr4CHNp9r6yibMz3174Z58u97ov+h7bWZTMCkYs9Ft1/9V628 6BWQev1gLSCBuoG12ERkeMY4GvAUd5tom1eigvoRhLKt1xkMIzSTu+DiziUQydpgMZ0h 6TQLF+iLxpRpDP38vXrmJ4CX4BTgCR7ASmlEryzZb4ZSlGyrHUN5xbeLIWVk3CGbzuC7 kSjYE5U3jyqVpTM7blSajsqKEzWtF7zRt6uDG69VuVSeURFtpCLq3oDVqHmjvxsvYqh7 xUjUVwidrcEvXJcAz2yNCxFhAmkPxgLaGJYqApgdgztRIcrnJgkO/BspoDgVWGwmBqU4 SLLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687519590; x=1690111590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LeRcwBbxP8qSgReccvjmd+si5KWAvFJg2+f/IOmB80s=; b=gpHOBPqWGhvioBCTswWMU9kPwmYp2f00nK0dTmeXVF6K9Hfr/+4X+EcwjITOfDixDC CDboFPJprlViJ4cONK+VUWZuD7KqwAAO4j8mLus681keQLkOsggZ2bHxgF8i+f+n+Qux iLJ2UjjVefCK6XToC1A9jCS4HIr8PVKrysJlr6lTQrwgDNUF3lO09ghma3ySaIdS6mTq hwtkQCpiNWhYQPf2yWD1dfEjgS3xKohx65btLdbFXq5NSXvUuH1Wq6B+ZuIagN7oFF3+ wLyHQ2yJsz9nByvB3EI0ITAriR9k1hB65rgHVYUCk0cRDQPJ0Cl5DrMisvd0PQ7WB/8c mOqQ== X-Gm-Message-State: AC+VfDzqnraVYMYR+3aQXnmpSa1qeYgB3pKz/kJUA21ESn+WrDRhfjmb dvlq5UtJ6rfEwIm2aEiAGLOrn589z1U= X-Google-Smtp-Source: ACHHUZ5I21Q1BFxAloUMTTip0Zxks/Vl312XCVn01dbxx8/I+xoCAVSiaD5gqg0C9aBtPRIwKdNERw== X-Received: by 2002:a4a:e04b:0:b0:560:aa1d:fe11 with SMTP id v11-20020a4ae04b000000b00560aa1dfe11mr5911455oos.2.1687519589607; Fri, 23 Jun 2023 04:26:29 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bt4-20020a0568201a8400b005630ed553e5sm135128oob.40.2023.06.23.04.26.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 04:26:28 -0700 (PDT) Message-ID: Date: Fri, 23 Jun 2023 08:26:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: ffmpeg-devel@ffmpeg.org References: <20230622145709.GB3250409@pb2> <168745018738.21886.10926077684605560333@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <168745018738.21886.10926077684605560333@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [RFC] SDR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/22/2023 1:09 PM, Anton Khirnov wrote: > Hi, > I'm sorry to say, the patch at its current state is quite far from > something I'd consider acceptable for git master. > > 1) Given that there are sdr and sdrfile demuxers, it seems to me that > the transport layer should be split into a protocol rather than be > inside the demuxer I disagree. It's not a protocol. I can't get a Matroska bitstream out of this like i could from an actual protocol like http, smb, etc. This is a capture device. > 2) Threading inside the demuxer, with pthread calls randomly sprinkled > throughout is particularly ugly and dangerous. Demuxers should not do > their own threading. > 3) sdr_read_header() and sdr_read_packet() are giant, hideous, and > unreadable. > 4) Why does there seem to be drawing code in a demuxer? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".