[FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check

[FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check

[fei.w.wang-at-intel.com]

From: Fei Wang <fei.w.wang@intel.com>

Supported formats are checked in base function ff_vaapi_vpp_config_output.

Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
 libavfilter/vf_tonemap_vaapi.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c
index 5de7faa8cc..0b767202d2 100644
--- a/libavfilter/vf_tonemap_vaapi.c
+++ b/libavfilter/vf_tonemap_vaapi.c
@@ -331,14 +331,6 @@ static av_cold int tonemap_vaapi_init(AVFilterContext *avctx)
 
     if (ctx->output_format_string) {
         vpp_ctx->output_format = av_get_pix_fmt(ctx->output_format_string);
-        switch (vpp_ctx->output_format) {
-        case AV_PIX_FMT_NV12:
-        case AV_PIX_FMT_P010:
-            break;
-        default:
-            av_log(avctx, AV_LOG_ERROR, "Invalid output format.\n");
-            return AVERROR(EINVAL);
-        }
     } else {
         vpp_ctx->output_format = AV_PIX_FMT_NV12;
         av_log(avctx, AV_LOG_WARNING, "Output format not set, use default format NV12\n");
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check

[Xiang, Haihao]

On Di, 2024-02-20 at 10:32 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
> 
> Supported formats are checked in base function ff_vaapi_vpp_config_output.
> 
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>  libavfilter/vf_tonemap_vaapi.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c
> index 5de7faa8cc..0b767202d2 100644
> --- a/libavfilter/vf_tonemap_vaapi.c
> +++ b/libavfilter/vf_tonemap_vaapi.c
> @@ -331,14 +331,6 @@ static av_cold int tonemap_vaapi_init(AVFilterContext
> *avctx)
>  
>      if (ctx->output_format_string) {
>          vpp_ctx->output_format = av_get_pix_fmt(ctx->output_format_string);
> -        switch (vpp_ctx->output_format) {
> -        case AV_PIX_FMT_NV12:
> -        case AV_PIX_FMT_P010:
> -            break;
> -        default:
> -            av_log(avctx, AV_LOG_ERROR, "Invalid output format.\n");
> -            return AVERROR(EINVAL);
> -        }
>      } else {
>          vpp_ctx->output_format = AV_PIX_FMT_NV12;
>          av_log(avctx, AV_LOG_WARNING, "Output format not set, use default
> format NV12\n");

LGTM, will apply

- Haihao



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".