From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Wang, Fei W" <fei.w.wang@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check
Date: Fri, 23 Feb 2024 05:14:06 +0000
Message-ID: <ab35a5e450d3339209ee62010b5d587337fdc10d.camel@intel.com> (raw)
In-Reply-To: <20240220023209.3962911-1-fei.w.wang@intel.com>
On Di, 2024-02-20 at 10:32 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
>
> Supported formats are checked in base function ff_vaapi_vpp_config_output.
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
> libavfilter/vf_tonemap_vaapi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c
> index 5de7faa8cc..0b767202d2 100644
> --- a/libavfilter/vf_tonemap_vaapi.c
> +++ b/libavfilter/vf_tonemap_vaapi.c
> @@ -331,14 +331,6 @@ static av_cold int tonemap_vaapi_init(AVFilterContext
> *avctx)
>
> if (ctx->output_format_string) {
> vpp_ctx->output_format = av_get_pix_fmt(ctx->output_format_string);
> - switch (vpp_ctx->output_format) {
> - case AV_PIX_FMT_NV12:
> - case AV_PIX_FMT_P010:
> - break;
> - default:
> - av_log(avctx, AV_LOG_ERROR, "Invalid output format.\n");
> - return AVERROR(EINVAL);
> - }
> } else {
> vpp_ctx->output_format = AV_PIX_FMT_NV12;
> av_log(avctx, AV_LOG_WARNING, "Output format not set, use default
> format NV12\n");
LGTM, will apply
- Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-02-23 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 2:32 fei.w.wang-at-intel.com
2024-02-23 5:14 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab35a5e450d3339209ee62010b5d587337fdc10d.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=fei.w.wang@intel.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git